From: Linus Walleij <linus.walleij@linaro.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org list"
<linuxppc-dev@lists.ozlabs.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] powerpc: sysdev: cpm: fix gpio save_regs functions
Date: Thu, 11 Aug 2016 13:54:23 +0200 [thread overview]
Message-ID: <CACRpkdZYZNyNRZMCNNUc=2FRqvb1nUjn5kZjuA8CHS=FG8G0MQ@mail.gmail.com> (raw)
In-Reply-To: <20160811085040.2EC561A2456@localhost.localdomain>
On Thu, Aug 11, 2016 at 10:50 AM, Christophe Leroy
<christophe.leroy@c-s.fr> wrote:
> of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
> setting the data. Therefore ->save_regs() cannot use
> gpiochip_get_data()
>
> [ 0.275940] Unable to handle kernel paging request for data at address 0x00000130
> [ 0.283120] Faulting instruction address: 0xc01b44cc
> [ 0.288175] Oops: Kernel access of bad area, sig: 11 [#1]
> [ 0.293343] PREEMPT CMPC885
> [ 0.296141] CPU: 0 PID: 1 Comm: swapper Not tainted 4.7.0-g65124df-dirty #68
> [ 0.304131] task: c6074000 ti: c6080000 task.ti: c6080000
> [ 0.309459] NIP: c01b44cc LR: c0011720 CTR: c0011708
> [ 0.314372] REGS: c6081d90 TRAP: 0300 Not tainted (4.7.0-g65124df-dirty)
> [ 0.322267] MSR: 00009032 <EE,ME,IR,DR,RI> CR: 24000028 XER: 20000000
> [ 0.328813] DAR: 00000130 DSISR: c0000000
> GPR00: c01b6d0c c6081e40 c6074000 c6017000 c9028000 c601d028 c6081dd8 00000000
> GPR08: c601d028 00000000 ffffffff 00000001 24000044 00000000 c0002790 00000000
> GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 c05643b0 00000083
> GPR24: c04a1a6c c0560000 c04a8308 c04c6480 c0012498 c6017000 c7ffcc78 c6017000
> [ 0.360806] NIP [c01b44cc] gpiochip_get_data+0x4/0xc
> [ 0.365684] LR [c0011720] cpm1_gpio16_save_regs+0x18/0x44
> [ 0.370972] Call Trace:
> [ 0.373451] [c6081e50] [c01b6d0c] of_mm_gpiochip_add_data+0x70/0xdc
> [ 0.379624] [c6081e70] [c00124c0] cpm_init_par_io+0x28/0x118
> [ 0.385238] [c6081e80] [c04a8ac0] do_one_initcall+0xb0/0x17c
> [ 0.390819] [c6081ef0] [c04a8cbc] kernel_init_freeable+0x130/0x1dc
> [ 0.396924] [c6081f30] [c00027a4] kernel_init+0x14/0x110
> [ 0.402177] [c6081f40] [c000b424] ret_from_kernel_thread+0x5c/0x64
> [ 0.408233] Instruction dump:
> [ 0.411168] 4182fafc 3f80c040 48234c6d 3bc0fff0 3b9c5ed0 4bfffaf4 81290020 712a0004
> [ 0.418825] 4182fb34 48234c51 4bfffb2c 81230004 <80690130> 4e800020 7c0802a6 9421ffe0
> [ 0.426763] ---[ end trace fe4113ee21d72ffa ]---
>
> fixes: e65078f1f3490 ("powerpc: sysdev: cpm1: use gpiochip data pointer")
> fixes: a14a2d484b386 ("powerpc: cpm_common: use gpiochip data pointer")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Sorry for screwing stuff up :(
Yours,
Linus Walleij
prev parent reply other threads:[~2016-08-11 11:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 8:50 [PATCH] powerpc: sysdev: cpm: fix gpio save_regs functions Christophe Leroy
2016-08-11 8:50 ` Christophe Leroy
2016-08-11 11:54 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZYZNyNRZMCNNUc=2FRqvb1nUjn5kZjuA8CHS=FG8G0MQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.