All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Mukesh Kaushik <mukesh.k4@samsung.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	vidushi.koul@samsung.com
Subject: Re: [PATCH] gpio/gpiolib.c:Fixing style issues in gpiolib.c
Date: Wed, 7 Dec 2016 16:07:43 +0100	[thread overview]
Message-ID: <CACRpkdZeytQDraQHjp_EB-Og-9RY7pEdzw+0vi5k_UO9Jw7t=g@mail.gmail.com> (raw)
In-Reply-To: <1480938325-4113-1-git-send-email-mukesh.k4@samsung.com>

On Mon, Dec 5, 2016 at 12:45 PM, Mukesh Kaushik <mukesh.k4@samsung.com> wrote:

> Fixing the following checkpatch.pl error:
>
> ERROR: else should follow close brace '}'
> +       }
> +       else if (test_bit(FLAG_OPEN_SOURCE, &desc->flags)) {
>
> ERROR: space prohibited after that open parenthesis '('
> +       if ( !desc->gdev->chip ) { \
>
> ERROR: space prohibited before that close parenthesis ')'
> +       if ( !desc->gdev->chip ) { \
>
> and following warnings :
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> WARNING: else is not generally useful after a break or return
> +                       break;
> +               else
>
> Change-Id: I9164832686efb8db1f6d365f89f278e998104f81

Gerrit? We don't need this.

> Signed-off-by: Mukesh Kaushik <mukesh.k4@samsung.com>

This does not apply to my devel branch.

Please rebase on devel or v4.9 final whatever comes first
and resend.

Yours,
Linus Walleij

  reply	other threads:[~2016-12-07 15:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 11:45 [PATCH] gpio/gpiolib.c:Fixing style issues in gpiolib.c Mukesh Kaushik
2016-12-07 15:07 ` Linus Walleij [this message]
2016-12-09  4:08 Mukesh Kaushik
2016-12-28 12:38 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZeytQDraQHjp_EB-Og-9RY7pEdzw+0vi5k_UO9Jw7t=g@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=gnurou@gmail.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mukesh.k4@samsung.com \
    --cc=vidushi.koul@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.