From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570E4C433F5 for ; Sat, 7 May 2022 12:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384817AbiEGMlV (ORCPT ); Sat, 7 May 2022 08:41:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384695AbiEGMlU (ORCPT ); Sat, 7 May 2022 08:41:20 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 069C24507E for ; Sat, 7 May 2022 05:37:32 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id y2so17187533ybi.7 for ; Sat, 07 May 2022 05:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=KCyiITVKgMi69PaUxMUe8kgt1g0I/YT1BNqXQ8g8jDYzoI10RIuW4XJdIAw+WABgPz sIoqAXB0wg2Fv4K4xa+UIk01I93aMUAh5zwWez9Y9woJgUGlFSInLIx46fZ5Gg1s601e a5i4HOw7TQkJg5Maw+WvNt0vTtgrsC6dMYDUfidiIqwE2Susa4bkzpuGE1IWxOsZTINs CB1T7vFcyxbamcJuoqj4cYj6aPJPj79FjZ60m16yN0qOI1to8EcKMqSlW8ohYQOIT3XX Y47JhHbhAM6byKlmpEHLlDWi3VANQBbeKYdvgbjI2HE4GR8wATeJNEQhXZFHSEQQgNal 1RtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=3/NRhIUTLFq+C0canLO+PlKjvDDAhgsa9cl7rs56cevoN5jKgzmvD2MlWKbgx5GJbe tdWXGSfx0QArQb3GEfh9jncSYH6dZhYDlOAlyaJO56LfGMWx+r7daL16uFF9KXzxHA1P JVXpDvNw7PPIXm+9YJqmkt3UY02NRQCLQguI459sF2HMdi3nVkBL3F5asWwLOtfWQ1Vs DHvj9PMQLyJzcRdoLNdK+zp0m4kHtsvN+tvg+j9k8mb32UjhTv07l8c5W/LYrrw2IEzj WhsbXcFt5mXPePgQRic2t+S6j0nM9Adx5ijO8WpZijoqvI2i3NdPFgoMe/gcnIrvRDZH 6niw== X-Gm-Message-State: AOAM531Jh8RRV/YtW52O971oVo/ey6v+cemeDNOLvenGxBhGALMsVeQn dNuUxDGP69abK4Vi+tdgi3KNadbhoNRM79PCySvzPA== X-Google-Smtp-Source: ABdhPJzwJpXEUtAZEUc6bZUPoenoZ5sebSG72if0MOZ/TMe4dt5l953VkaeLr4GysoaOw6EpMxKFJUOEIy1GTdxXArc= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr6256768ybh.369.1651927052069; Sat, 07 May 2022 05:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-41-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-41-arnd@kernel.org> From: Linus Walleij Date: Sat, 7 May 2022 14:37:20 +0200 Message-ID: Subject: Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org, Sebastian Reichel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Tue, Apr 19, 2022 at 6:44 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The battery driver uses a lot of GPIO lines, hardcoded from a > machine header file. > > Change it to use a gpiod lookup table instead. > > Reviewed-by: Sebastian Reichel > Acked-by: Sebastian Reichel > Cc: linux-pm@vger.kernel.org > Signed-off-by: Arnd Bergmann Oh, I've been iterating a patch for the Tosa charging code going down in MFD ans ASoC and all: https://lore.kernel.org/linux-arm-kernel/20220125003741.492954-1-linus.walleij@linaro.org/ I just rebased this on v5.18-rc1 and resent with collected ACKs. Please take a look at it, and see if you rather take that patch, at some point I realized I had to go pretty deep around the legacy code in different subsystems because the MFD device us spawning a GPIO chip... Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB222C433F5 for ; Sat, 7 May 2022 12:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HK/9IHOa9OQ3AlaT73zFFVDCZvlQ3P0zaKqW3/AAt6w=; b=VAdPFR1CDNDHSk /3eh1jOn9mKuq670tLHjgxkQg3IHGlw5UflPfr/3pVwu2QXohm32kVu/w81YJvBKiETyREybpH7HE OW9QWwYF1XN2oLxPJFIDWuQSGF/L7zG5VF18CS1MiBugrocont5A4oh1C775+Dy9Eqp/+bA/2nOss 6C0mVd7Czog8Tqhci27dBuMWp077Yz3mXPlls0DXtNcrNgI7sBdhyX6vtyOupjnaNhwHgGetXDlcH SLMYAa6D73LyDIwd1UMrgvkGz927olVNarU7TywMumt7gPVZn4YB3LRmM1r81jt2+mStvlv5PSc/x l642XEb5+emAXieZTqHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnJgl-0079XC-KM; Sat, 07 May 2022 12:37:35 +0000 Received: from mail-yb1-xb29.google.com ([2607:f8b0:4864:20::b29]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnJgj-0079WD-9q for linux-mtd@lists.infradead.org; Sat, 07 May 2022 12:37:34 +0000 Received: by mail-yb1-xb29.google.com with SMTP id i38so17165843ybj.13 for ; Sat, 07 May 2022 05:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=KCyiITVKgMi69PaUxMUe8kgt1g0I/YT1BNqXQ8g8jDYzoI10RIuW4XJdIAw+WABgPz sIoqAXB0wg2Fv4K4xa+UIk01I93aMUAh5zwWez9Y9woJgUGlFSInLIx46fZ5Gg1s601e a5i4HOw7TQkJg5Maw+WvNt0vTtgrsC6dMYDUfidiIqwE2Susa4bkzpuGE1IWxOsZTINs CB1T7vFcyxbamcJuoqj4cYj6aPJPj79FjZ60m16yN0qOI1to8EcKMqSlW8ohYQOIT3XX Y47JhHbhAM6byKlmpEHLlDWi3VANQBbeKYdvgbjI2HE4GR8wATeJNEQhXZFHSEQQgNal 1RtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=1EqTE0NdCWf1keHlhiZaupC5Sy98XOu2KyUtuqp/myisJtxKHi0RGxDTxWpTYVrAPk 4euBegOSDFc6xTfbjS6qPyESEx1dWEJ6dAOLUjEnsxiKvc//tbv+fp0IJpXoUwJm1dRr BpNFuD5/3x0bkKqyOOERAesz/szOndv2LkYJpTfjsWjlEfaLYF7UVGv+5PK/VgTE8IL2 S0DFDwshfwrKXzPA/4FCuc4Jb3J6TYWEjaasHLnOOusU2XV0adKCCtOWhfo12nxenWbZ 8SMlgnFg4dhULn+8EbCz/Viss/rTLxqavjC8ICaiQnWFPLWZazxqz/nb+Jtx84QlsZDk MrMg== X-Gm-Message-State: AOAM53033FG2Hrn0KEwd7mlN2Aptun7LAp5nwb9Kmu6ZBQhh0WnF3zWM m7/mnkw+D1CkRhdyfD3cCGMQKiPK0nrDyFx9Ym7+rQ== X-Google-Smtp-Source: ABdhPJzwJpXEUtAZEUc6bZUPoenoZ5sebSG72if0MOZ/TMe4dt5l953VkaeLr4GysoaOw6EpMxKFJUOEIy1GTdxXArc= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr6256768ybh.369.1651927052069; Sat, 07 May 2022 05:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-41-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-41-arnd@kernel.org> From: Linus Walleij Date: Sat, 7 May 2022 14:37:20 +0200 Message-ID: Subject: Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org, Sebastian Reichel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220507_053733_388567_490B4EE1 X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 6:44 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The battery driver uses a lot of GPIO lines, hardcoded from a > machine header file. > > Change it to use a gpiod lookup table instead. > > Reviewed-by: Sebastian Reichel > Acked-by: Sebastian Reichel > Cc: linux-pm@vger.kernel.org > Signed-off-by: Arnd Bergmann Oh, I've been iterating a patch for the Tosa charging code going down in MFD ans ASoC and all: https://lore.kernel.org/linux-arm-kernel/20220125003741.492954-1-linus.walleij@linaro.org/ I just rebased this on v5.18-rc1 and resent with collected ACKs. Please take a look at it, and see if you rather take that patch, at some point I realized I had to go pretty deep around the legacy code in different subsystems because the MFD device us spawning a GPIO chip... Yours, Linus Walleij ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4A4BC433F5 for ; Sat, 7 May 2022 12:37:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27CC7113151; Sat, 7 May 2022 12:37:35 +0000 (UTC) Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by gabe.freedesktop.org (Postfix) with ESMTPS id 00F8E11314F for ; Sat, 7 May 2022 12:37:32 +0000 (UTC) Received: by mail-yb1-xb35.google.com with SMTP id s30so17207429ybi.8 for ; Sat, 07 May 2022 05:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=KCyiITVKgMi69PaUxMUe8kgt1g0I/YT1BNqXQ8g8jDYzoI10RIuW4XJdIAw+WABgPz sIoqAXB0wg2Fv4K4xa+UIk01I93aMUAh5zwWez9Y9woJgUGlFSInLIx46fZ5Gg1s601e a5i4HOw7TQkJg5Maw+WvNt0vTtgrsC6dMYDUfidiIqwE2Susa4bkzpuGE1IWxOsZTINs CB1T7vFcyxbamcJuoqj4cYj6aPJPj79FjZ60m16yN0qOI1to8EcKMqSlW8ohYQOIT3XX Y47JhHbhAM6byKlmpEHLlDWi3VANQBbeKYdvgbjI2HE4GR8wATeJNEQhXZFHSEQQgNal 1RtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=rIDUmZ850kugyKNpTfg3WhHOOc2HOvFk5x2Oz6g6/QxQMOdj0xHb420m7kyMcwejmR z3KGmXwlYrVa+LeXAKBa1LiE82f6FUWdn4t2KrESCFMHjBostOHywQCQB/51xg5iEVsJ gqRhfmzuKm2E+xSu0pMCWyLZg0xzeQ7WEvXXTqgJFrNlSLDjz1X9anPbYlfZ2q1zEzKL q+nrrQilpRDJAz+OLNxLMqgQ96+D4pWsSnqlbgg03FREayen5+kMWFEKmOX7ralq4ph1 IXvFude+SUIHd4b2sUl/KTZljm3crHbgY/LL18w5j6XdQDN++KVliJGfyKBEZOSXKBI7 M1KA== X-Gm-Message-State: AOAM5330nxaY6TcYV2HMNP3Nnt/nBGTgqTob39D/kggRgRwq22aycARj N0qfv/Y5IOBpJxCUYMbBGtdaoO/w0sz85h7Z23hyHw== X-Google-Smtp-Source: ABdhPJzwJpXEUtAZEUc6bZUPoenoZ5sebSG72if0MOZ/TMe4dt5l953VkaeLr4GysoaOw6EpMxKFJUOEIy1GTdxXArc= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr6256768ybh.369.1651927052069; Sat, 07 May 2022 05:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-41-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-41-arnd@kernel.org> From: Linus Walleij Date: Sat, 7 May 2022 14:37:20 +0200 Message-ID: Subject: Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery To: Arnd Bergmann Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, "Rafael J. Wysocki" , Viresh Kumar , Sergey Lapin , linux-fbdev@vger.kernel.org, Dominik Brodowski , linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, Tomas Cech , robert.jarzmik@free.fr, linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Helge Deller , Marek Vasut , Paul Parsons , Michael Turquette , Arnd Bergmann , linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , Lubomir Rintel , Mark Brown , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Stephen Boyd , patches@opensource.cirrus.com, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , alsa-devel@alsa-project.org, Daniel Mack Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 19, 2022 at 6:44 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The battery driver uses a lot of GPIO lines, hardcoded from a > machine header file. > > Change it to use a gpiod lookup table instead. > > Reviewed-by: Sebastian Reichel > Acked-by: Sebastian Reichel > Cc: linux-pm@vger.kernel.org > Signed-off-by: Arnd Bergmann Oh, I've been iterating a patch for the Tosa charging code going down in MFD ans ASoC and all: https://lore.kernel.org/linux-arm-kernel/20220125003741.492954-1-linus.walleij@linaro.org/ I just rebased this on v5.18-rc1 and resent with collected ACKs. Please take a look at it, and see if you rather take that patch, at some point I realized I had to go pretty deep around the legacy code in different subsystems because the MFD device us spawning a GPIO chip... Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37367C433EF for ; Sat, 7 May 2022 12:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=umT6lO4nf/18vi9yljhRsyiFv5/XXm2LL3YDihdHEyY=; b=JJ4MMYBLbfu5ct w1JI4kxxtDbA5AZmWT6oPprzNmiU743FBYyT8ZbCSlmEjmBfrtU73yfatNpk3FMUsIOfuMiC9V5Ci 5WouteaXu1usBV1XhjPa2Lf86iqZfx3NiThv+oHXlrokIkWIJ4uATLRPPO4a+4zdrqKD7pHrp+5Mj 4xUWZrME6wZgLENxoTNe5ufSGaNqPuaawHsaFHmX2QOlcgOFB/6BG0PWhhwwz0+PRYvzFux5sK7mK SPCr4VLW2ZyV98Zf/8hYIBmJAlS8S4JKdVaBKpVNyOAhRx6Y9lStRMBOQuxOtJ3DLWTHpTHvJSpFn 7cz2TtHS+UU0a088nRiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnJgn-0079Xg-U0; Sat, 07 May 2022 12:37:38 +0000 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnJgj-0079WE-Qb for linux-arm-kernel@lists.infradead.org; Sat, 07 May 2022 12:37:35 +0000 Received: by mail-yb1-xb2d.google.com with SMTP id e12so17180432ybc.11 for ; Sat, 07 May 2022 05:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=KCyiITVKgMi69PaUxMUe8kgt1g0I/YT1BNqXQ8g8jDYzoI10RIuW4XJdIAw+WABgPz sIoqAXB0wg2Fv4K4xa+UIk01I93aMUAh5zwWez9Y9woJgUGlFSInLIx46fZ5Gg1s601e a5i4HOw7TQkJg5Maw+WvNt0vTtgrsC6dMYDUfidiIqwE2Susa4bkzpuGE1IWxOsZTINs CB1T7vFcyxbamcJuoqj4cYj6aPJPj79FjZ60m16yN0qOI1to8EcKMqSlW8ohYQOIT3XX Y47JhHbhAM6byKlmpEHLlDWi3VANQBbeKYdvgbjI2HE4GR8wATeJNEQhXZFHSEQQgNal 1RtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=Tl1/dqnnbBsQhyHDm/Nb9DuksN/ecZ5Ao7G+h9aGp9G8JFis5IKwLe1YIZFf9mgfrS uD1ZS0darFqtKh4eSWnxwRlOkQL2bhfhBD3A3ptXfZSsS28KC+nf7Px3M1LVQj7KMufF UK6GSJ8Oxv/r7tg9w4PqxVQtRA9iFAf8EqwOa+V+8WMG6UgC4+AdcIdmEetjIhWO1wXN iFqLwNE/9nDU+fvFcgbMyM4tYwfH/YBgbCGJXi3uoFytK4DDo3lVuIeBzeyjrRBR3g71 MtDc0AYENPulAIqs85DulD50vLOA1Ev5E4mjKXsYyYBCh4DtAj6icwpS6FzTDPFrAAFo 6E/w== X-Gm-Message-State: AOAM533Y80yhYXHKNgado8gT+Xzsml5M9/xLyE8L5QGRJjmez3Y4n0AK OY9YMkqV4tkxhyy0qFmbqkl4mewkUEc4jRL7wUzjhw== X-Google-Smtp-Source: ABdhPJzwJpXEUtAZEUc6bZUPoenoZ5sebSG72if0MOZ/TMe4dt5l953VkaeLr4GysoaOw6EpMxKFJUOEIy1GTdxXArc= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr6256768ybh.369.1651927052069; Sat, 07 May 2022 05:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-41-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-41-arnd@kernel.org> From: Linus Walleij Date: Sat, 7 May 2022 14:37:20 +0200 Message-ID: Subject: Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org, Sebastian Reichel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220507_053733_889133_42BBB74F X-CRM114-Status: GOOD ( 15.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 6:44 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The battery driver uses a lot of GPIO lines, hardcoded from a > machine header file. > > Change it to use a gpiod lookup table instead. > > Reviewed-by: Sebastian Reichel > Acked-by: Sebastian Reichel > Cc: linux-pm@vger.kernel.org > Signed-off-by: Arnd Bergmann Oh, I've been iterating a patch for the Tosa charging code going down in MFD ans ASoC and all: https://lore.kernel.org/linux-arm-kernel/20220125003741.492954-1-linus.walleij@linaro.org/ I just rebased this on v5.18-rc1 and resent with collected ACKs. Please take a look at it, and see if you rather take that patch, at some point I realized I had to go pretty deep around the legacy code in different subsystems because the MFD device us spawning a GPIO chip... Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1638BC433EF for ; Tue, 10 May 2022 12:24:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 46A3A1687; Tue, 10 May 2022 14:23:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 46A3A1687 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1652185455; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dM/HRvq+KxVIeKC+m/e18bnCQR2aTbajpn8/bryOrVVO4xLpZfhi3vZqagJm2hSyO sPbu8756hfzMA9iGk15cNS+z/IM8s7k6tRcHaDW6Y55vaiDBuJJOHBbRgjeMas4NfB xy1mbbx7S2b28KLEa5o564pyMzBSY7gjAqeHScyM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3E914F80527; Tue, 10 May 2022 14:21:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2D55CF80155; Sat, 7 May 2022 14:37:41 +0200 (CEST) Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C5F03F800FA for ; Sat, 7 May 2022 14:37:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C5F03F800FA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KCyiITVK" Received: by mail-yb1-xb34.google.com with SMTP id v59so17167600ybi.12 for ; Sat, 07 May 2022 05:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=KCyiITVKgMi69PaUxMUe8kgt1g0I/YT1BNqXQ8g8jDYzoI10RIuW4XJdIAw+WABgPz sIoqAXB0wg2Fv4K4xa+UIk01I93aMUAh5zwWez9Y9woJgUGlFSInLIx46fZ5Gg1s601e a5i4HOw7TQkJg5Maw+WvNt0vTtgrsC6dMYDUfidiIqwE2Susa4bkzpuGE1IWxOsZTINs CB1T7vFcyxbamcJuoqj4cYj6aPJPj79FjZ60m16yN0qOI1to8EcKMqSlW8ohYQOIT3XX Y47JhHbhAM6byKlmpEHLlDWi3VANQBbeKYdvgbjI2HE4GR8wATeJNEQhXZFHSEQQgNal 1RtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JUhgclDR3XBkbKooh+LIAZ5rgGQDmCxwnx2kPnqoYMA=; b=bpj/kbG0JddgjM+r4yehkqfrYWjcoypC33CuVDFRCLkFUdRtJV6DvF9UYA5UJavglr MQSngmItybE9xMQ3xsGwBYn7i1+ma5cQdHeLhb8RblwHD8bwuwiphOl89kNLSmGmkH5i i7ZKPedwIQvHtak0Eki3D8avAvVbj2tks1yABo8w0ziHf8k7i8IwYMSUQTXB3j/Dmntv oIcejJ7BvjMP1IW/nQ06DlT24FsMBZotKgRGlNqrMa0b+UbMWcZH8kbyZsTQu0vHY3vW tv2ZPxTYBnQb3mhNfzt2QfkJ3hdP/iTz9ej0BvZGfby48jZVkB97tVlANxVTKveGuAYr 7SwA== X-Gm-Message-State: AOAM533XQTdHClhuyZUPHLbRkWtacETH0cToK+K8Y/itGAPX/d1VBWL2 axRzUToDhT9BJEonv2TNbc8CiZA600d40RctuItBIw== X-Google-Smtp-Source: ABdhPJzwJpXEUtAZEUc6bZUPoenoZ5sebSG72if0MOZ/TMe4dt5l953VkaeLr4GysoaOw6EpMxKFJUOEIy1GTdxXArc= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr6256768ybh.369.1651927052069; Sat, 07 May 2022 05:37:32 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-41-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-41-arnd@kernel.org> From: Linus Walleij Date: Sat, 7 May 2022 14:37:20 +0200 Message-ID: Subject: Re: [PATCH 40/48] ARM: pxa: tosa: use gpio lookup for battery To: Arnd Bergmann Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Tue, 10 May 2022 14:21:48 +0200 Cc: Ulf Hansson , linux-usb@vger.kernel.org, Philipp Zabel , "Rafael J. Wysocki" , Viresh Kumar , Sergey Lapin , linux-fbdev@vger.kernel.org, Dominik Brodowski , linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, Tomas Cech , robert.jarzmik@free.fr, linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Helge Deller , Marek Vasut , Paul Parsons , Michael Turquette , Arnd Bergmann , linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , Lubomir Rintel , Mark Brown , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Stephen Boyd , patches@opensource.cirrus.com, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , alsa-devel@alsa-project.org, Daniel Mack X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Apr 19, 2022 at 6:44 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The battery driver uses a lot of GPIO lines, hardcoded from a > machine header file. > > Change it to use a gpiod lookup table instead. > > Reviewed-by: Sebastian Reichel > Acked-by: Sebastian Reichel > Cc: linux-pm@vger.kernel.org > Signed-off-by: Arnd Bergmann Oh, I've been iterating a patch for the Tosa charging code going down in MFD ans ASoC and all: https://lore.kernel.org/linux-arm-kernel/20220125003741.492954-1-linus.walleij@linaro.org/ I just rebased this on v5.18-rc1 and resent with collected ACKs. Please take a look at it, and see if you rather take that patch, at some point I realized I had to go pretty deep around the legacy code in different subsystems because the MFD device us spawning a GPIO chip... Yours, Linus Walleij