From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Olivier Matz <olivier.matz@6wind.com>, dpdk-dev <dev@dpdk.org>,
Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags
Date: Mon, 2 Aug 2021 14:31:41 -0700 [thread overview]
Message-ID: <CACZ4nhtT00o2uobJ-Z=1Gtf7ohhNS2OkJ4GekEYHYue4cc1vCQ@mail.gmail.com> (raw)
In-Reply-To: <ccfb6214-40ce-1699-f625-060e6b476ef1@oktetlabs.ru>
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
On Sat, Jul 31, 2021 at 5:15 AM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> On 7/30/21 6:57 PM, Olivier Matz wrote:
> > The mbuf offload flags do not match the DPDK namespace (they are
> > not prefixed by RTE_). Announce their rename in 21.11, and the
> > removal of the old names in 22.11.
> >
> > A draft coccinelle script is provided to anticipate what the
> > renaming will be.
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> [snip]
>
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index 9584d6bfd7..04cb141de7 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -147,3 +147,8 @@ Deprecation Notices
> > * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific
> > content. On Linux and FreeBSD, supported prior to DPDK 20.11,
> > original structure will be kept until DPDK 21.11.
> > +
> > +* mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``.
> > + A compatibility layer will be kept until DPDK 22.11, except for the flags
> > + that are already deprecated (ex: ``PKT_RX_L4_CKSUM_BAD``), which will
> > + be removed.
> >
>
> I think it is better to be explicit with defines to be removed:
> PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD, PKT_TX_QINQ_PKT,
> PKT_RX_EIP_CKSUM_BAD.
+1
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
next prev parent reply other threads:[~2021-08-02 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 15:57 [dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags Olivier Matz
2021-07-31 12:15 ` Andrew Rybchenko
2021-08-02 13:05 ` Jerin Jacob
2021-08-02 21:31 ` Ajit Khaparde [this message]
2021-08-04 14:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhtT00o2uobJ-Z=1Gtf7ohhNS2OkJ4GekEYHYue4cc1vCQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.