Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

From: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "kgene.kim" <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org,
	Patch Tracking <patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts
Date: Fri, 10 May 2013 08:25:33 +0530	[thread overview]
Message-ID: <CAD025yRnuk2oK1B40p5XTQ7n+aX+ta2PTdEuceCbvRUEvRgzSg@mail.gmail.com> (raw)
In-Reply-To: <4212940.hYf2k9NPUY@flatron>

[-- Attachment #1.1: Type: text/plain, Size: 2218 bytes --]

Hi Tomasz,

On 10 May 2013 05:35, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> Hi Vikas,
>
> On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote:
> > Adds display timing node for a DP panel to Arndale Board DTS file
> >
> > Signed-off-by: Vikas Sajjan <vikas.sajjan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/exynos5250-arndale.dts |   16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> > b/arch/arm/boot/dts/exynos5250-arndale.dts index f68b820..c831a5c
> > 100644
> > --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> > @@ -459,4 +459,20 @@
> >               samsung,lane-count = <4>;
> >       };
> >
> > +     display-timings {
> > +             native-mode = <&timing0>;
> > +             timing0: timing@0 {
> > +                     /* 2560x1600 DP panel */
> > +                     clock-frequency = <50000>;
> > +                     hactive = <2560>;
> > +                     vactive = <1600>;
> > +                     hfront-porch = <48>;
> > +                     hback-porch = <80>;
> > +                     hsync-len = <32>;
> > +                     vback-porch = <16>;
> > +                     vfront-porch = <8>;
> > +                     vsync-len = <6>;
> > +             };
> > +     };
>
> What display are those timings used for? Shouldn't they be placed inside
> node of that display?
>
>
This timing information will be used parsed by the FIMD probe with the help
of "Video Helper function"  as done in this link

https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=7f4596f4aebcc9fcf2d50d3fe398508d710c4dd0

Please refer to this patch which is used for exynos4412-origen and
exynos5250-smdk5250 respectively in similar way

https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=0207775d6ff7e6a6eddb9931f9328f0f0173a338

https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/commit/?h=for-next&id=06c460b73f75894cabfb1f5277f27cddbc92745c

Best regards,
> Tomasz
>
>

-- 
Thanks and Regards
 Vikas Sajjan

[-- Attachment #1.2: Type: text/html, Size: 3629 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss