From: Jacob Vosmaer <jacob@gitlab.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>,
Git Mailing List <git@vger.kernel.org>,
ps@pks.im
Subject: Re: [PATCH v3 0/2] send_ref buffering
Date: Tue, 31 Aug 2021 19:44:02 +0200 [thread overview]
Message-ID: <CADMWQoOfPr47a6bJtApt=wSE9BrgXQKJRfJuNAj0zbtio2BRHw@mail.gmail.com> (raw)
In-Reply-To: <CADMWQoPerffQcTfKh3bfesjgHaBqXGzW2805knyRW3R_q4V-YA@mail.gmail.com>
On Tue, Aug 31, 2021 at 3:08 PM Jacob Vosmaer <jacob@gitlab.com> wrote:
>
> On Tue, Aug 31, 2021 at 12:25 PM Jeff King <peff@peff.net> wrote:
> > I do think it would be nice to take the packet_writer
> > interface further (letting it replace the static buf, and use stdio
> > handles, and using it throughout upload-pack).
> I would like that too, for the sake of neatness and general
> performance, but I don't have the time to take on a larger project
> like that at the moment.
I gave solving the problem with packet_writer a couple of hours today.
The diff gets too big, and I have too little confidence I'm not
introducing deadlocks. This really is more work than I can chew off
right now. Sorry!
Jacob
next prev parent reply other threads:[~2021-08-31 17:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 14:02 [PATCH 1/1] upload-pack: buffer ref advertisement writes Jacob Vosmaer
2021-08-24 21:07 ` Taylor Blau
2021-08-24 21:42 ` Junio C Hamano
2021-08-25 0:44 ` Jeff King
2021-08-26 10:02 ` Jacob Vosmaer
2021-08-26 10:06 ` [PATCH 1/2] pkt-line: add packet_fwrite Jacob Vosmaer
2021-08-26 10:06 ` [PATCH 2/2] upload-pack: use stdio in send_ref callbacks Jacob Vosmaer
2021-08-26 16:33 ` Junio C Hamano
2021-08-26 20:21 ` Junio C Hamano
2021-08-26 22:35 ` Taylor Blau
2021-08-26 23:24 ` Jeff King
2021-08-27 16:15 ` Junio C Hamano
2021-08-31 9:34 ` [PATCH v3 0/2] send_ref buffering Jacob Vosmaer
2021-08-31 9:34 ` [PATCH v3 1/2] pkt-line: add stdio packet write functions Jacob Vosmaer
2021-08-31 10:37 ` Jeff King
2021-08-31 18:13 ` Junio C Hamano
2021-09-01 12:54 ` [PATCH v4 0/2] send_ref buffering Jacob Vosmaer
2021-09-01 12:54 ` [PATCH v4 1/2] pkt-line: add stdio packet write functions Jacob Vosmaer
2021-09-01 12:54 ` [PATCH v4 2/2] upload-pack: use stdio in send_ref callbacks Jacob Vosmaer
2021-09-02 9:18 ` [PATCH v4 0/2] send_ref buffering Jeff King
2021-08-31 9:34 ` [PATCH v3 2/2] upload-pack: use stdio in send_ref callbacks Jacob Vosmaer
2021-08-31 10:25 ` [PATCH v3 0/2] send_ref buffering Jeff King
2021-08-31 13:08 ` Jacob Vosmaer
2021-08-31 17:44 ` Jacob Vosmaer [this message]
2021-09-01 0:15 ` Jeff King
2021-08-26 23:32 ` [PATCH 2/2] upload-pack: use stdio in send_ref callbacks Jeff King
2021-08-26 16:33 ` [PATCH 1/2] pkt-line: add packet_fwrite Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADMWQoOfPr47a6bJtApt=wSE9BrgXQKJRfJuNAj0zbtio2BRHw@mail.gmail.com' \
--to=jacob@gitlab.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.