Re: [PATCH xf86-video-ati 2/2] glamor: Bail CreatePixmap on unsupported pixmap depth

From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
Cc: amd-gfx list <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH xf86-video-ati 2/2] glamor: Bail CreatePixmap on unsupported pixmap depth
Date: Mon, 21 May 2018 15:02:47 -0400	[thread overview]
Message-ID: <CADnq5_MAOthM2Y48t-+CgdFW-ByGUhJgg_hQ8ZAgFBR2C22dEQ@mail.gmail.com> (raw)
In-Reply-To: <20180518142140.20582-2-michel-otUistvHUpPR7s880joybQ@public.gmane.org>

On Fri, May 18, 2018 at 10:21 AM, Michel Dänzer <michel@daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> Fixes crash in that case.
>
> Bugzilla: https://bugs.freedesktop.org/106293
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  src/radeon_glamor.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/radeon_glamor.c b/src/radeon_glamor.c
> index 7c09abba5..10d513ea9 100644
> --- a/src/radeon_glamor.c
> +++ b/src/radeon_glamor.c
> @@ -214,6 +214,9 @@ radeon_glamor_create_pixmap(ScreenPtr screen, int w, int h, int depth,
>         struct radeon_pixmap *priv;
>         PixmapPtr pixmap, new_pixmap = NULL;
>
> +       if (!xf86GetPixFormat(scrn, depth))
> +               return NULL;
> +
>         if (!RADEON_CREATE_PIXMAP_SHARED(usage)) {
>                 if (info->shadow_primary) {
>                         if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP)
> --
> 2.17.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx