From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D81FC433DB for ; Fri, 8 Jan 2021 21:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C82FF23A5A for ; Fri, 8 Jan 2021 21:08:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729422AbhAHVII (ORCPT ); Fri, 8 Jan 2021 16:08:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729349AbhAHVIH (ORCPT ); Fri, 8 Jan 2021 16:08:07 -0500 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53B14C061574 for ; Fri, 8 Jan 2021 13:07:27 -0800 (PST) Received: by mail-oi1-x229.google.com with SMTP id s75so12901818oih.1 for ; Fri, 08 Jan 2021 13:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pcr4Tdvxc8bDQEjz7KUOR4L9kv90/P1v7PgP00kdfaM=; b=BnC4iPd0jnVFxunJsHGzISYmry9eUi/Ih0S4OS5xA6tAhcCgNxhxL2FBTScCEbZivj ezVDaKwHrzkyT6JOOkkXTcpDVgd8lGyQc4TcC9yFv6ZI3RCGdZgozMegrxAIRl33ub1I 3ZqxI50CDbmICj/FwX0d3GVeNm9lgUCAu+DLPfgcT7LWA/VzEgTkG/biENrzx7pXqLBv Vww8HweJinbROeDY3AUBQKEo4nZpVqFOgwSFy9qcqesWRHjz033DFptGDg/dWbJW3boG 5YoOsuoKsbMUqddt6My8qcbinXXUhEnyrFS1NjZUFXMZkDPM1tnDSUz1N59WSfcApQBC +eQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pcr4Tdvxc8bDQEjz7KUOR4L9kv90/P1v7PgP00kdfaM=; b=NWGxoNxn/G1xhdcNGXrWFuMe72QWuYVQ+QMVli9HwwyJO6/gFCksR00D/pl92i88bu QoVGMLBjGIR5nNIZzqYXKOOAdS56zJ+Ddtm9sgxvGyrqXFzdC6KTnCqC5ScyDeAnJ0rO n1fyDui4Yh0k6sLjRUm7jvJgVj9XOrg+ZGn0p99ET2mnJpGz8BhHyBQyRFGktfGk/uU7 vsjFQ3hDgu3DcyI2rogK8M63zsgnvTnTz87mdvvg7r6DNfz98zoYv86sMeaDGNyQjtpV K/MIH3AMb5tOxqBal9aD7sNPNMc2wrrIbHEdJU9mRMgThWtTUfRSUJtOBgcK4bR7f7ve 0/Bw== X-Gm-Message-State: AOAM532viUm5cGsv0iOy7tpJOU9w0W35A0kY4H8OTHMUOQFz8MAPzLqb SRJugndkN0aX/bdvglxhL+NXN4bZ2m1NA/IhvGw= X-Google-Smtp-Source: ABdhPJxrSdeOuaVjOtCGANRq8MeS+tK/Fe/2NYSYId6ZgxhFadUmADwANBNROTRVJcjXq6iy5M8R94Zav+YSQSBPgSA= X-Received: by 2002:a54:4083:: with SMTP id i3mr3473144oii.120.1610140046621; Fri, 08 Jan 2021 13:07:26 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-22-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-22-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:07:15 -0500 Message-ID: Subject: Re: [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused variables 'v_filter_init_mode' and 'sclk_lvl' To: Lee Jones , Harry Wentland , "Leo (Sunpeng) Li" Cc: LKML , amd-gfx list , David Airlie , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 8, 2021 at 3:15 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function = =E2=80=98calculate_bandwidth=E2=80=99: > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:109:18: warni= ng: variable =E2=80=98v_filter_init_mode=E2=80=99 set but not used [-Wunuse= d-but-set-variable] > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function = =E2=80=98bw_calcs=E2=80=99: > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:3031:21: warn= ing: variable =E2=80=98sclk_lvl=E2=80=99 set but not used [-Wunused-but-set= -variable] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones @Harry Wentland , @Leo (Sunpeng) Li I think this file is generated from a script or something. Wanted to get your take on how to properly integrate a change like this. Alex > --- > drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drivers/g= pu/drm/amd/display/dc/calcs/dce_calcs.c > index ef41b287cbe23..158d927c03e55 100644 > --- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c > +++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c > @@ -106,7 +106,6 @@ static void calculate_bandwidth( > bool lpt_enabled; > enum bw_defines sclk_message; > enum bw_defines yclk_message; > - enum bw_defines v_filter_init_mode[maximum_number_of_surfaces]; > enum bw_defines tiling_mode[maximum_number_of_surfaces]; > enum bw_defines surface_type[maximum_number_of_surfaces]; > enum bw_defines voltage; > @@ -792,12 +791,8 @@ static void calculate_bandwidth( > data->v_filter_init[i] =3D bw_add(data->v= _filter_init[i], bw_int_to_fixed(1)); > } > if (data->stereo_mode[i] =3D=3D bw_def_top_bottom= ) { > - v_filter_init_mode[i] =3D bw_def_manual; > data->v_filter_init[i] =3D bw_min2(data->= v_filter_init[i], bw_int_to_fixed(4)); > } > - else { > - v_filter_init_mode[i] =3D bw_def_auto; > - } > if (data->stereo_mode[i] =3D=3D bw_def_top_bottom= ) { > data->num_lines_at_frame_start =3D bw_int= _to_fixed(1); > } > @@ -3028,7 +3023,7 @@ bool bw_calcs(struct dc_context *ctx, > calcs_output->all_displays_in_sync =3D false; > > if (data->number_of_displays !=3D 0) { > - uint8_t yclk_lvl, sclk_lvl; > + uint8_t yclk_lvl; > struct bw_fixed high_sclk =3D vbios->high_sclk; > struct bw_fixed mid1_sclk =3D vbios->mid1_sclk; > struct bw_fixed mid2_sclk =3D vbios->mid2_sclk; > @@ -3049,7 +3044,6 @@ bool bw_calcs(struct dc_context *ctx, > calculate_bandwidth(dceip, vbios, data); > > yclk_lvl =3D data->y_clk_level; > - sclk_lvl =3D data->sclk_level; > > calcs_output->nbp_state_change_enable =3D > data->nbp_state_change_enable; > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EADFC433E0 for ; Fri, 8 Jan 2021 21:07:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8AEC23A5A for ; Fri, 8 Jan 2021 21:07:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8AEC23A5A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 423936E8DC; Fri, 8 Jan 2021 21:07:28 +0000 (UTC) Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F5446E8D2; Fri, 8 Jan 2021 21:07:27 +0000 (UTC) Received: by mail-oi1-x230.google.com with SMTP id w124so12895527oia.6; Fri, 08 Jan 2021 13:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pcr4Tdvxc8bDQEjz7KUOR4L9kv90/P1v7PgP00kdfaM=; b=BnC4iPd0jnVFxunJsHGzISYmry9eUi/Ih0S4OS5xA6tAhcCgNxhxL2FBTScCEbZivj ezVDaKwHrzkyT6JOOkkXTcpDVgd8lGyQc4TcC9yFv6ZI3RCGdZgozMegrxAIRl33ub1I 3ZqxI50CDbmICj/FwX0d3GVeNm9lgUCAu+DLPfgcT7LWA/VzEgTkG/biENrzx7pXqLBv Vww8HweJinbROeDY3AUBQKEo4nZpVqFOgwSFy9qcqesWRHjz033DFptGDg/dWbJW3boG 5YoOsuoKsbMUqddt6My8qcbinXXUhEnyrFS1NjZUFXMZkDPM1tnDSUz1N59WSfcApQBC +eQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pcr4Tdvxc8bDQEjz7KUOR4L9kv90/P1v7PgP00kdfaM=; b=lgv47QQwbEpu+6rFvweIKHhTEMvv8B2qhefqU1fwJG5Ju47AcLORUNZFTQSRdPj+k1 0Hsz6p3waLsoRx30H64dbrgp5O7XLvtoW+SAye23TeubGX/ZelRHF8hhnwej/OWJQ737 wAIeW6iVmBi8wTSu3vifxA9TlJ2COzGSMbOjXCoRMf5GWE2GhV+3unjUrkh8e4uN3VX3 T1KFD6awZOoZD42iIIILmi7vNoTscaOJ0NdT4eizoX3iTYM/eegK4lo80e/rA1+bri68 hlBOYGnRvS72rPsD1x1i8aArwvhHyzgHm1xYgBJliJK/mk+84GE8YOdpcDk27bnkqK1D //5A== X-Gm-Message-State: AOAM533nUYdTGDgCy1/VCoTIKHS6yeOzZtRVABoK7EjS2bWxTTDqQyzs 8C7/RsLD56wD3mbh+qBjmQOeM3R8uojkURtzyBk= X-Google-Smtp-Source: ABdhPJxrSdeOuaVjOtCGANRq8MeS+tK/Fe/2NYSYId6ZgxhFadUmADwANBNROTRVJcjXq6iy5M8R94Zav+YSQSBPgSA= X-Received: by 2002:a54:4083:: with SMTP id i3mr3473144oii.120.1610140046621; Fri, 08 Jan 2021 13:07:26 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-22-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-22-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:07:15 -0500 Message-ID: Subject: Re: [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused variables 'v_filter_init_mode' and 'sclk_lvl' To: Lee Jones , Harry Wentland , "Leo (Sunpeng) Li" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBKYW4gOCwgMjAyMSBhdCAzOjE1IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9kYy9j YWxjcy9kY2VfY2FsY3MuYzogSW4gZnVuY3Rpb24g4oCYY2FsY3VsYXRlX2JhbmR3aWR0aOKAmToK PiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9kYy9jYWxjcy9kY2VfY2Fs Y3MuYzoxMDk6MTg6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHZfZmlsdGVyX2luaXRfbW9kZeKAmSBz ZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jOiBJbiBmdW5j dGlvbiDigJhid19jYWxjc+KAmToKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlz cGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYzozMDMxOjIxOiB3YXJuaW5nOiB2YXJpYWJsZSDigJhz Y2xrX2x2bOKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+ Cj4gQ2M6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29tPgo+IENjOiBMZW8g TGkgPHN1bnBlbmcubGlAYW1kLmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1 Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2Zm LWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgoKQEhhcnJ5IFdlbnRsYW5kCiwg QExlbyAoU3VucGVuZykgTGkgSSB0aGluayB0aGlzIGZpbGUgaXMgZ2VuZXJhdGVkIGZyb20gYSBz Y3JpcHQgb3IKc29tZXRoaW5nLiAgV2FudGVkIHRvIGdldCB5b3VyIHRha2Ugb24gaG93IHRvIHBy b3Blcmx5IGludGVncmF0ZSBhCmNoYW5nZSBsaWtlIHRoaXMuCgpBbGV4CgoKPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jIHwgOCArLS0tLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDcgZGVsZXRpb25zKC0pCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxj cy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jCj4g aW5kZXggZWY0MWIyODdjYmUyMy4uMTU4ZDkyN2MwM2U1NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2NhbGNzLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2NhbGNzLmMKPiBAQCAtMTA2LDcgKzEw Niw2IEBAIHN0YXRpYyB2b2lkIGNhbGN1bGF0ZV9iYW5kd2lkdGgoCj4gICAgICAgICBib29sIGxw dF9lbmFibGVkOwo+ICAgICAgICAgZW51bSBid19kZWZpbmVzIHNjbGtfbWVzc2FnZTsKPiAgICAg ICAgIGVudW0gYndfZGVmaW5lcyB5Y2xrX21lc3NhZ2U7Cj4gLSAgICAgICBlbnVtIGJ3X2RlZmlu ZXMgdl9maWx0ZXJfaW5pdF9tb2RlW21heGltdW1fbnVtYmVyX29mX3N1cmZhY2VzXTsKPiAgICAg ICAgIGVudW0gYndfZGVmaW5lcyB0aWxpbmdfbW9kZVttYXhpbXVtX251bWJlcl9vZl9zdXJmYWNl c107Cj4gICAgICAgICBlbnVtIGJ3X2RlZmluZXMgc3VyZmFjZV90eXBlW21heGltdW1fbnVtYmVy X29mX3N1cmZhY2VzXTsKPiAgICAgICAgIGVudW0gYndfZGVmaW5lcyB2b2x0YWdlOwo+IEBAIC03 OTIsMTIgKzc5MSw4IEBAIHN0YXRpYyB2b2lkIGNhbGN1bGF0ZV9iYW5kd2lkdGgoCj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhLT52X2ZpbHRlcl9pbml0W2ldID0gYndfYWRk KGRhdGEtPnZfZmlsdGVyX2luaXRbaV0sIGJ3X2ludF90b19maXhlZCgxKSk7Cj4gICAgICAgICAg ICAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChkYXRhLT5zdGVy ZW9fbW9kZVtpXSA9PSBid19kZWZfdG9wX2JvdHRvbSkgewo+IC0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdl9maWx0ZXJfaW5pdF9tb2RlW2ldID0gYndfZGVmX21hbnVhbDsKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEtPnZfZmlsdGVyX2luaXRbaV0gPSBid19t aW4yKGRhdGEtPnZfZmlsdGVyX2luaXRbaV0sIGJ3X2ludF90b19maXhlZCg0KSk7Cj4gICAgICAg ICAgICAgICAgICAgICAgICAgfQo+IC0gICAgICAgICAgICAgICAgICAgICAgIGVsc2Ugewo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdl9maWx0ZXJfaW5pdF9tb2RlW2ldID0gYndf ZGVmX2F1dG87Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAgICAgICAg ICAgICAgIGlmIChkYXRhLT5zdGVyZW9fbW9kZVtpXSA9PSBid19kZWZfdG9wX2JvdHRvbSkgewo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGF0YS0+bnVtX2xpbmVzX2F0X2ZyYW1l X3N0YXJ0ID0gYndfaW50X3RvX2ZpeGVkKDEpOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIH0K PiBAQCAtMzAyOCw3ICszMDIzLDcgQEAgYm9vbCBid19jYWxjcyhzdHJ1Y3QgZGNfY29udGV4dCAq Y3R4LAo+ICAgICAgICAgICAgICAgICBjYWxjc19vdXRwdXQtPmFsbF9kaXNwbGF5c19pbl9zeW5j ID0gZmFsc2U7Cj4KPiAgICAgICAgIGlmIChkYXRhLT5udW1iZXJfb2ZfZGlzcGxheXMgIT0gMCkg ewo+IC0gICAgICAgICAgICAgICB1aW50OF90IHljbGtfbHZsLCBzY2xrX2x2bDsKPiArICAgICAg ICAgICAgICAgdWludDhfdCB5Y2xrX2x2bDsKPiAgICAgICAgICAgICAgICAgc3RydWN0IGJ3X2Zp eGVkIGhpZ2hfc2NsayA9IHZiaW9zLT5oaWdoX3NjbGs7Cj4gICAgICAgICAgICAgICAgIHN0cnVj dCBid19maXhlZCBtaWQxX3NjbGsgPSB2Ymlvcy0+bWlkMV9zY2xrOwo+ICAgICAgICAgICAgICAg ICBzdHJ1Y3QgYndfZml4ZWQgbWlkMl9zY2xrID0gdmJpb3MtPm1pZDJfc2NsazsKPiBAQCAtMzA0 OSw3ICszMDQ0LDYgQEAgYm9vbCBid19jYWxjcyhzdHJ1Y3QgZGNfY29udGV4dCAqY3R4LAo+ICAg ICAgICAgICAgICAgICBjYWxjdWxhdGVfYmFuZHdpZHRoKGRjZWlwLCB2YmlvcywgZGF0YSk7Cj4K PiAgICAgICAgICAgICAgICAgeWNsa19sdmwgPSBkYXRhLT55X2Nsa19sZXZlbDsKPiAtICAgICAg ICAgICAgICAgc2Nsa19sdmwgPSBkYXRhLT5zY2xrX2xldmVsOwo+Cj4gICAgICAgICAgICAgICAg IGNhbGNzX291dHB1dC0+bmJwX3N0YXRlX2NoYW5nZV9lbmFibGUgPQo+ICAgICAgICAgICAgICAg ICAgICAgICAgIGRhdGEtPm5icF9zdGF0ZV9jaGFuZ2VfZW5hYmxlOwo+IC0tCj4gMi4yNS4xCj4K PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7099AC433DB for ; Fri, 8 Jan 2021 21:07:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 160FE23A5A for ; Fri, 8 Jan 2021 21:07:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 160FE23A5A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC83F6E8D2; Fri, 8 Jan 2021 21:07:27 +0000 (UTC) Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F5446E8D2; Fri, 8 Jan 2021 21:07:27 +0000 (UTC) Received: by mail-oi1-x230.google.com with SMTP id w124so12895527oia.6; Fri, 08 Jan 2021 13:07:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pcr4Tdvxc8bDQEjz7KUOR4L9kv90/P1v7PgP00kdfaM=; b=BnC4iPd0jnVFxunJsHGzISYmry9eUi/Ih0S4OS5xA6tAhcCgNxhxL2FBTScCEbZivj ezVDaKwHrzkyT6JOOkkXTcpDVgd8lGyQc4TcC9yFv6ZI3RCGdZgozMegrxAIRl33ub1I 3ZqxI50CDbmICj/FwX0d3GVeNm9lgUCAu+DLPfgcT7LWA/VzEgTkG/biENrzx7pXqLBv Vww8HweJinbROeDY3AUBQKEo4nZpVqFOgwSFy9qcqesWRHjz033DFptGDg/dWbJW3boG 5YoOsuoKsbMUqddt6My8qcbinXXUhEnyrFS1NjZUFXMZkDPM1tnDSUz1N59WSfcApQBC +eQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pcr4Tdvxc8bDQEjz7KUOR4L9kv90/P1v7PgP00kdfaM=; b=lgv47QQwbEpu+6rFvweIKHhTEMvv8B2qhefqU1fwJG5Ju47AcLORUNZFTQSRdPj+k1 0Hsz6p3waLsoRx30H64dbrgp5O7XLvtoW+SAye23TeubGX/ZelRHF8hhnwej/OWJQ737 wAIeW6iVmBi8wTSu3vifxA9TlJ2COzGSMbOjXCoRMf5GWE2GhV+3unjUrkh8e4uN3VX3 T1KFD6awZOoZD42iIIILmi7vNoTscaOJ0NdT4eizoX3iTYM/eegK4lo80e/rA1+bri68 hlBOYGnRvS72rPsD1x1i8aArwvhHyzgHm1xYgBJliJK/mk+84GE8YOdpcDk27bnkqK1D //5A== X-Gm-Message-State: AOAM533nUYdTGDgCy1/VCoTIKHS6yeOzZtRVABoK7EjS2bWxTTDqQyzs 8C7/RsLD56wD3mbh+qBjmQOeM3R8uojkURtzyBk= X-Google-Smtp-Source: ABdhPJxrSdeOuaVjOtCGANRq8MeS+tK/Fe/2NYSYId6ZgxhFadUmADwANBNROTRVJcjXq6iy5M8R94Zav+YSQSBPgSA= X-Received: by 2002:a54:4083:: with SMTP id i3mr3473144oii.120.1610140046621; Fri, 08 Jan 2021 13:07:26 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-22-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-22-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:07:15 -0500 Message-ID: Subject: Re: [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused variables 'v_filter_init_mode' and 'sclk_lvl' To: Lee Jones , Harry Wentland , "Leo (Sunpeng) Li" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gRnJpLCBKYW4gOCwgMjAyMSBhdCAzOjE1IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9kYy9j YWxjcy9kY2VfY2FsY3MuYzogSW4gZnVuY3Rpb24g4oCYY2FsY3VsYXRlX2JhbmR3aWR0aOKAmToK PiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9kYy9jYWxjcy9kY2VfY2Fs Y3MuYzoxMDk6MTg6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmHZfZmlsdGVyX2luaXRfbW9kZeKAmSBz ZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jOiBJbiBmdW5j dGlvbiDigJhid19jYWxjc+KAmToKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlz cGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYzozMDMxOjIxOiB3YXJuaW5nOiB2YXJpYWJsZSDigJhz Y2xrX2x2bOKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+ Cj4gQ2M6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29tPgo+IENjOiBMZW8g TGkgPHN1bnBlbmcubGlAYW1kLmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1 Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2Zm LWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgoKQEhhcnJ5IFdlbnRsYW5kCiwg QExlbyAoU3VucGVuZykgTGkgSSB0aGluayB0aGlzIGZpbGUgaXMgZ2VuZXJhdGVkIGZyb20gYSBz Y3JpcHQgb3IKc29tZXRoaW5nLiAgV2FudGVkIHRvIGdldCB5b3VyIHRha2Ugb24gaG93IHRvIHBy b3Blcmx5IGludGVncmF0ZSBhCmNoYW5nZSBsaWtlIHRoaXMuCgpBbGV4CgoKPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jIHwgOCArLS0tLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDcgZGVsZXRpb25zKC0pCj4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxj cy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NhbGNzL2RjZV9jYWxjcy5jCj4g aW5kZXggZWY0MWIyODdjYmUyMy4uMTU4ZDkyN2MwM2U1NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2NhbGNzLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2NhbGNzLmMKPiBAQCAtMTA2LDcgKzEw Niw2IEBAIHN0YXRpYyB2b2lkIGNhbGN1bGF0ZV9iYW5kd2lkdGgoCj4gICAgICAgICBib29sIGxw dF9lbmFibGVkOwo+ICAgICAgICAgZW51bSBid19kZWZpbmVzIHNjbGtfbWVzc2FnZTsKPiAgICAg ICAgIGVudW0gYndfZGVmaW5lcyB5Y2xrX21lc3NhZ2U7Cj4gLSAgICAgICBlbnVtIGJ3X2RlZmlu ZXMgdl9maWx0ZXJfaW5pdF9tb2RlW21heGltdW1fbnVtYmVyX29mX3N1cmZhY2VzXTsKPiAgICAg ICAgIGVudW0gYndfZGVmaW5lcyB0aWxpbmdfbW9kZVttYXhpbXVtX251bWJlcl9vZl9zdXJmYWNl c107Cj4gICAgICAgICBlbnVtIGJ3X2RlZmluZXMgc3VyZmFjZV90eXBlW21heGltdW1fbnVtYmVy X29mX3N1cmZhY2VzXTsKPiAgICAgICAgIGVudW0gYndfZGVmaW5lcyB2b2x0YWdlOwo+IEBAIC03 OTIsMTIgKzc5MSw4IEBAIHN0YXRpYyB2b2lkIGNhbGN1bGF0ZV9iYW5kd2lkdGgoCj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkYXRhLT52X2ZpbHRlcl9pbml0W2ldID0gYndfYWRk KGRhdGEtPnZfZmlsdGVyX2luaXRbaV0sIGJ3X2ludF90b19maXhlZCgxKSk7Cj4gICAgICAgICAg ICAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChkYXRhLT5zdGVy ZW9fbW9kZVtpXSA9PSBid19kZWZfdG9wX2JvdHRvbSkgewo+IC0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdl9maWx0ZXJfaW5pdF9tb2RlW2ldID0gYndfZGVmX21hbnVhbDsKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGEtPnZfZmlsdGVyX2luaXRbaV0gPSBid19t aW4yKGRhdGEtPnZfZmlsdGVyX2luaXRbaV0sIGJ3X2ludF90b19maXhlZCg0KSk7Cj4gICAgICAg ICAgICAgICAgICAgICAgICAgfQo+IC0gICAgICAgICAgICAgICAgICAgICAgIGVsc2Ugewo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdl9maWx0ZXJfaW5pdF9tb2RlW2ldID0gYndf ZGVmX2F1dG87Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgfQo+ICAgICAgICAgICAgICAgICAg ICAgICAgIGlmIChkYXRhLT5zdGVyZW9fbW9kZVtpXSA9PSBid19kZWZfdG9wX2JvdHRvbSkgewo+ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGF0YS0+bnVtX2xpbmVzX2F0X2ZyYW1l X3N0YXJ0ID0gYndfaW50X3RvX2ZpeGVkKDEpOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIH0K PiBAQCAtMzAyOCw3ICszMDIzLDcgQEAgYm9vbCBid19jYWxjcyhzdHJ1Y3QgZGNfY29udGV4dCAq Y3R4LAo+ICAgICAgICAgICAgICAgICBjYWxjc19vdXRwdXQtPmFsbF9kaXNwbGF5c19pbl9zeW5j ID0gZmFsc2U7Cj4KPiAgICAgICAgIGlmIChkYXRhLT5udW1iZXJfb2ZfZGlzcGxheXMgIT0gMCkg ewo+IC0gICAgICAgICAgICAgICB1aW50OF90IHljbGtfbHZsLCBzY2xrX2x2bDsKPiArICAgICAg ICAgICAgICAgdWludDhfdCB5Y2xrX2x2bDsKPiAgICAgICAgICAgICAgICAgc3RydWN0IGJ3X2Zp eGVkIGhpZ2hfc2NsayA9IHZiaW9zLT5oaWdoX3NjbGs7Cj4gICAgICAgICAgICAgICAgIHN0cnVj dCBid19maXhlZCBtaWQxX3NjbGsgPSB2Ymlvcy0+bWlkMV9zY2xrOwo+ICAgICAgICAgICAgICAg ICBzdHJ1Y3QgYndfZml4ZWQgbWlkMl9zY2xrID0gdmJpb3MtPm1pZDJfc2NsazsKPiBAQCAtMzA0 OSw3ICszMDQ0LDYgQEAgYm9vbCBid19jYWxjcyhzdHJ1Y3QgZGNfY29udGV4dCAqY3R4LAo+ICAg ICAgICAgICAgICAgICBjYWxjdWxhdGVfYmFuZHdpZHRoKGRjZWlwLCB2YmlvcywgZGF0YSk7Cj4K PiAgICAgICAgICAgICAgICAgeWNsa19sdmwgPSBkYXRhLT55X2Nsa19sZXZlbDsKPiAtICAgICAg ICAgICAgICAgc2Nsa19sdmwgPSBkYXRhLT5zY2xrX2xldmVsOwo+Cj4gICAgICAgICAgICAgICAg IGNhbGNzX291dHB1dC0+bmJwX3N0YXRlX2NoYW5nZV9lbmFibGUgPQo+ICAgICAgICAgICAgICAg ICAgICAgICAgIGRhdGEtPm5icF9zdGF0ZV9jaGFuZ2VfZW5hYmxlOwo+IC0tCj4gMi4yNS4xCj4K PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWls aW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==