From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92BC1C433E0 for ; Fri, 8 Jan 2021 21:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5868523A9B for ; Fri, 8 Jan 2021 21:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729656AbhAHVQZ (ORCPT ); Fri, 8 Jan 2021 16:16:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727845AbhAHVQZ (ORCPT ); Fri, 8 Jan 2021 16:16:25 -0500 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBC2BC061574 for ; Fri, 8 Jan 2021 13:15:44 -0800 (PST) Received: by mail-ot1-x335.google.com with SMTP id b24so11111311otj.0 for ; Fri, 08 Jan 2021 13:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RdHU0V+l/5mQjoD9Rkq0FokpPahQQiZHJdwaPeqIFOw=; b=N/9q3tnXNvoXj9NNSpNsp/WqUeWVnlXZmfdK5XKDodktfsDUrcKtMMoGr3+ipiy+kJ LSIfJyZzXDXtETPGIqnqGxqqHpxB9795RthL27QqsKOxtHlej07Jxk+VIk02x2vd5hLJ te5c3x9ZnSsi4p3D4P/7sBKCCs2vt2qB8JSpQiaJa0FoKFMLS+4/Hyla3wFQ6nKjBGuc oWwf64peHkELSW1QZsJRj+JSDPUuNtgOdYtDy1whEUtvKRbxmLJTLlY5EfEugO4y/awo 8RjDEf2IScxGiMTzkQXE4agUt3YLLGoMaCW9jB+VtO5/0827gEWrmQQimdkjHRu1iwBZ sMeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RdHU0V+l/5mQjoD9Rkq0FokpPahQQiZHJdwaPeqIFOw=; b=JQ0co9Qm2Z2jowuE629ECXtsH/ogI47xy17RHKGXe/dCbPol1kNxwfvGGafPdaW0/3 wY+27PvORB2oRoDrYuFYUjpDHtH+4fuQ5A7D3ZnYWb+iyGJ6RIIt63CG1aajkqpq5Tge 69/KeCWComIQEgNnOg39YUeY2G3v6PLq0hY0+2sOM5MR0672gwOPEZg8jxbvOoWbwSjn sdXFFwMmqlRf5wk9cWf/rQjWA30R4r2uHb5+Ii744kxlGehwMCQZQaqA9k1+Qqa4hhE1 7cJfPNJNYvEa8MRDskFbgWoCnqQenqFlDgSxu/cDy/e5Rg3wbzx7nqzPStuXjY1YgMJT kG8A== X-Gm-Message-State: AOAM531BkIsRyrDQho2x3/pRwdZ+d8Z695OoatCO6bXqUJUrNd33az47 Oodlwp0Pn8+sHMtheGALXvstCa0waOWdI/+AZUc= X-Google-Smtp-Source: ABdhPJxUgRAka2RPKA+U8s8ytzVCIDZKjm/nFhiLdVPVHrGZ4YUvczYtQ+lBCAP0taI+zW0Tsik0GJrHRn2GsSUX9Zg= X-Received: by 2002:a05:6830:1b7b:: with SMTP id d27mr4083848ote.132.1610140544373; Fri, 08 Jan 2021 13:15:44 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-28-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-28-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:15:33 -0500 Message-ID: Subject: Re: [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy function headers, demote barely documented one To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 8, 2021 at 3:15 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1556: wa= rning: Function parameter or member 'acg_freq' not described in 'vega10_pop= ulate_single_gfx_level' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: wa= rning: Function parameter or member 'current_soc_did' not described in 'veg= a10_populate_single_soc_level' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: wa= rning: Function parameter or member 'current_vol_index' not described in 'v= ega10_populate_single_soc_level' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: wa= rning: Excess function parameter 'current_socclk_level' description in 'veg= a10_populate_single_soc_level' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: wa= rning: Function parameter or member 'current_mem_vid' not described in 'veg= a10_populate_single_memory_level' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: wa= rning: Function parameter or member 'current_memclk_level' not described in= 'vega10_populate_single_memory_level' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: wa= rning: Function parameter or member 'current_mem_soc_vind' not described in= 'vega10_populate_single_memory_level' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:2871: wa= rning: Function parameter or member 'bitmap' not described in 'vega10_start= _dpm' > > Cc: Evan Quan > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/driv= ers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c > index da470462d6e2c..29c99642d22d4 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c > @@ -1549,6 +1549,7 @@ static int vega10_populate_smc_link_levels(struct p= p_hwmgr *hwmgr) > * @hwmgr: the address of the hardware manager > * @gfx_clock: the GFX clock to use to populate the structure. > * @current_gfxclk_level: location in PPTable for the SMC GFXCLK struct= ure. > + * @acg_freq: ACG frequenty to return (MHz) > */ > static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr, > uint32_t gfx_clock, PllSetting_t *current_gfxclk_level, > @@ -1612,7 +1613,8 @@ static int vega10_populate_single_gfx_level(struct = pp_hwmgr *hwmgr, > * > * @hwmgr: the address of the hardware manager. > * @soc_clock: the SOC clock to use to populate the structure. > - * @current_socclk_level: location in PPTable for the SMC SOCCLK structu= re. > + * @current_soc_did: DFS divider to pass back to caller > + * @current_vol_index: index of current VDD to pass back to caller > * return: 0 on success > */ > static int vega10_populate_single_soc_level(struct pp_hwmgr *hwmgr, > @@ -1744,7 +1746,7 @@ static void vega10_populate_vddc_soc_levels(struct = pp_hwmgr *hwmgr) > } > } > > -/** > +/* > * Populates single SMC GFXCLK structure using the provided clock. > * > * @hwmgr: the address of the hardware manager. > @@ -2863,8 +2865,8 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, = uint32_t bitmap) > /** > * Tell SMC to enabled the supported DPMs. > * > - * @hwmgr: the address of the powerplay hardware manager. > - * @bitmap bitmap for the features to enabled. > + * @hwmgr: the address of the powerplay hardware manager. > + * @bitmap: bitmap for the features to enabled. > * return: 0 on at least one DPM is successfully enabled. > */ > static int vega10_start_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D434C433DB for ; Fri, 8 Jan 2021 21:15:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 179BE23A80 for ; Fri, 8 Jan 2021 21:15:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 179BE23A80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DA6F6E8DE; Fri, 8 Jan 2021 21:15:45 +0000 (UTC) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC38F6E8DE; Fri, 8 Jan 2021 21:15:44 +0000 (UTC) Received: by mail-ot1-x335.google.com with SMTP id q25so11037856otn.10; Fri, 08 Jan 2021 13:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RdHU0V+l/5mQjoD9Rkq0FokpPahQQiZHJdwaPeqIFOw=; b=N/9q3tnXNvoXj9NNSpNsp/WqUeWVnlXZmfdK5XKDodktfsDUrcKtMMoGr3+ipiy+kJ LSIfJyZzXDXtETPGIqnqGxqqHpxB9795RthL27QqsKOxtHlej07Jxk+VIk02x2vd5hLJ te5c3x9ZnSsi4p3D4P/7sBKCCs2vt2qB8JSpQiaJa0FoKFMLS+4/Hyla3wFQ6nKjBGuc oWwf64peHkELSW1QZsJRj+JSDPUuNtgOdYtDy1whEUtvKRbxmLJTLlY5EfEugO4y/awo 8RjDEf2IScxGiMTzkQXE4agUt3YLLGoMaCW9jB+VtO5/0827gEWrmQQimdkjHRu1iwBZ sMeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RdHU0V+l/5mQjoD9Rkq0FokpPahQQiZHJdwaPeqIFOw=; b=opJMv+0nHhWyskFBSHx3VorIHILzfM28NYGgiHNj0r15ftdONI6+YiwbawNtInMBld vYC1NeEIoAfOlPrGRXUtv0z/p9Y4T07TesU+9Y53QFKnvWVH9cOlbBuSIjtr3ZInHKAa bqGfjxg51ydhDuOb2s6fgf2g+kUdju46t2T4xX7r9ThgtcBe56xas/nIx2bSI3A09IxN zSTw4KxhsgqEKEc8YS99Cm/pU4McbhXEAcyR2R+Se+jAsRpPI8JHNwTwhTdwQblgmGPK enkzI7ZFEvw7+GIKEKl2KF2+KmvCD646oRcgRuwCxC7dr8IPIkNgyUqtik+d7j0CJgNo ZN0w== X-Gm-Message-State: AOAM532CpmSQmVszXvjN+0BOQPMf8wAEo1jkSvuigA5Td7k/b10ArdI+ 80NVFxV6Os0jEFkBQuQuDzj1hqH6fhJBquYDVwtMnPGK X-Google-Smtp-Source: ABdhPJxUgRAka2RPKA+U8s8ytzVCIDZKjm/nFhiLdVPVHrGZ4YUvczYtQ+lBCAP0taI+zW0Tsik0GJrHRn2GsSUX9Zg= X-Received: by 2002:a05:6830:1b7b:: with SMTP id d27mr4083848ote.132.1610140544373; Fri, 08 Jan 2021 13:15:44 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-28-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-28-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:15:33 -0500 Message-ID: Subject: Re: [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy function headers, demote barely documented one To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBKYW4gOCwgMjAyMSBhdCAzOjE1IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vcG0vcG93ZXJwbGF5 L2h3bWdyL3ZlZ2ExMF9od21nci5jOjE1NTY6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBv ciBtZW1iZXIgJ2FjZ19mcmVxJyBub3QgZGVzY3JpYmVkIGluICd2ZWdhMTBfcG9wdWxhdGVfc2lu Z2xlX2dmeF9sZXZlbCcKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vcG0vcG93ZXJw bGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jOjE2MjE6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRl ciBvciBtZW1iZXIgJ2N1cnJlbnRfc29jX2RpZCcgbm90IGRlc2NyaWJlZCBpbiAndmVnYTEwX3Bv cHVsYXRlX3NpbmdsZV9zb2NfbGV2ZWwnCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4u L3BtL3Bvd2VycGxheS9od21nci92ZWdhMTBfaHdtZ3IuYzoxNjIxOiB3YXJuaW5nOiBGdW5jdGlv biBwYXJhbWV0ZXIgb3IgbWVtYmVyICdjdXJyZW50X3ZvbF9pbmRleCcgbm90IGRlc2NyaWJlZCBp biAndmVnYTEwX3BvcHVsYXRlX3NpbmdsZV9zb2NfbGV2ZWwnCj4gIGRyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1Ly4uL3BtL3Bvd2VycGxheS9od21nci92ZWdhMTBfaHdtZ3IuYzoxNjIxOiB3YXJu aW5nOiBFeGNlc3MgZnVuY3Rpb24gcGFyYW1ldGVyICdjdXJyZW50X3NvY2Nsa19sZXZlbCcgZGVz Y3JpcHRpb24gaW4gJ3ZlZ2ExMF9wb3B1bGF0ZV9zaW5nbGVfc29jX2xldmVsJwo+ICBkcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9wbS9wb3dlcnBsYXkvaHdtZ3IvdmVnYTEwX2h3bWdyLmM6 MTc1Nzogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAnY3VycmVudF9tZW1f dmlkJyBub3QgZGVzY3JpYmVkIGluICd2ZWdhMTBfcG9wdWxhdGVfc2luZ2xlX21lbW9yeV9sZXZl bCcKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vcG0vcG93ZXJwbGF5L2h3bWdyL3Zl Z2ExMF9od21nci5jOjE3NTc6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIg J2N1cnJlbnRfbWVtY2xrX2xldmVsJyBub3QgZGVzY3JpYmVkIGluICd2ZWdhMTBfcG9wdWxhdGVf c2luZ2xlX21lbW9yeV9sZXZlbCcKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vcG0v cG93ZXJwbGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jOjE3NTc6IHdhcm5pbmc6IEZ1bmN0aW9uIHBh cmFtZXRlciBvciBtZW1iZXIgJ2N1cnJlbnRfbWVtX3NvY192aW5kJyBub3QgZGVzY3JpYmVkIGlu ICd2ZWdhMTBfcG9wdWxhdGVfc2luZ2xlX21lbW9yeV9sZXZlbCcKPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvLi4vcG0vcG93ZXJwbGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jOjI4NzE6IHdh cm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ2JpdG1hcCcgbm90IGRlc2NyaWJl ZCBpbiAndmVnYTEwX3N0YXJ0X2RwbScKPgo+IENjOiBFdmFuIFF1YW4gPGV2YW4ucXVhbkBhbWQu Y29tPgo+IENjOiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gQ2M6 ICJDaHJpc3RpYW4gS8O2bmlnIiA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IENjOiBEYXZp ZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBm ZndsbC5jaD4KPiBDYzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVl LmpvbmVzQGxpbmFyby5vcmc+CgpBcHBsaWVkLiAgVGhhbmtzIQoKQWxleAoKCj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jIHwgMTAg KysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L2h3 bWdyL3ZlZ2ExMF9od21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvaHdt Z3IvdmVnYTEwX2h3bWdyLmMKPiBpbmRleCBkYTQ3MDQ2MmQ2ZTJjLi4yOWM5OTY0MmQyMmQ0IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L2h3bWdyL3ZlZ2Ex MF9od21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvaHdtZ3Iv dmVnYTEwX2h3bWdyLmMKPiBAQCAtMTU0OSw2ICsxNTQ5LDcgQEAgc3RhdGljIGludCB2ZWdhMTBf cG9wdWxhdGVfc21jX2xpbmtfbGV2ZWxzKHN0cnVjdCBwcF9od21nciAqaHdtZ3IpCj4gICAqIEBo d21ncjogICAgICB0aGUgYWRkcmVzcyBvZiB0aGUgaGFyZHdhcmUgbWFuYWdlcgo+ICAgKiBAZ2Z4 X2Nsb2NrOiAgdGhlIEdGWCBjbG9jayB0byB1c2UgdG8gcG9wdWxhdGUgdGhlIHN0cnVjdHVyZS4K PiAgICogQGN1cnJlbnRfZ2Z4Y2xrX2xldmVsOiAgbG9jYXRpb24gaW4gUFBUYWJsZSBmb3IgdGhl IFNNQyBHRlhDTEsgc3RydWN0dXJlLgo+ICsgKiBAYWNnX2ZyZXE6ICAgQUNHIGZyZXF1ZW50eSB0 byByZXR1cm4gKE1IeikKPiAgICovCj4gIHN0YXRpYyBpbnQgdmVnYTEwX3BvcHVsYXRlX3Npbmds ZV9nZnhfbGV2ZWwoc3RydWN0IHBwX2h3bWdyICpod21nciwKPiAgICAgICAgICAgICAgICAgdWlu dDMyX3QgZ2Z4X2Nsb2NrLCBQbGxTZXR0aW5nX3QgKmN1cnJlbnRfZ2Z4Y2xrX2xldmVsLAo+IEBA IC0xNjEyLDcgKzE2MTMsOCBAQCBzdGF0aWMgaW50IHZlZ2ExMF9wb3B1bGF0ZV9zaW5nbGVfZ2Z4 X2xldmVsKHN0cnVjdCBwcF9od21nciAqaHdtZ3IsCj4gICAqCj4gICAqIEBod21ncjogICAgIHRo ZSBhZGRyZXNzIG9mIHRoZSBoYXJkd2FyZSBtYW5hZ2VyLgo+ICAgKiBAc29jX2Nsb2NrOiB0aGUg U09DIGNsb2NrIHRvIHVzZSB0byBwb3B1bGF0ZSB0aGUgc3RydWN0dXJlLgo+IC0gKiBAY3VycmVu dF9zb2NjbGtfbGV2ZWw6IGxvY2F0aW9uIGluIFBQVGFibGUgZm9yIHRoZSBTTUMgU09DQ0xLIHN0 cnVjdHVyZS4KPiArICogQGN1cnJlbnRfc29jX2RpZDogICBERlMgZGl2aWRlciB0byBwYXNzIGJh Y2sgdG8gY2FsbGVyCj4gKyAqIEBjdXJyZW50X3ZvbF9pbmRleDogaW5kZXggb2YgY3VycmVudCBW REQgdG8gcGFzcyBiYWNrIHRvIGNhbGxlcgo+ICAgKiByZXR1cm46ICAgICAgMCBvbiBzdWNjZXNz Cj4gICAqLwo+ICBzdGF0aWMgaW50IHZlZ2ExMF9wb3B1bGF0ZV9zaW5nbGVfc29jX2xldmVsKHN0 cnVjdCBwcF9od21nciAqaHdtZ3IsCj4gQEAgLTE3NDQsNyArMTc0Niw3IEBAIHN0YXRpYyB2b2lk IHZlZ2ExMF9wb3B1bGF0ZV92ZGRjX3NvY19sZXZlbHMoc3RydWN0IHBwX2h3bWdyICpod21ncikK PiAgICAgICAgIH0KPiAgfQo+Cj4gLS8qKgo+ICsvKgo+ICAgKiBQb3B1bGF0ZXMgc2luZ2xlIFNN QyBHRlhDTEsgc3RydWN0dXJlIHVzaW5nIHRoZSBwcm92aWRlZCBjbG9jay4KPiAgICoKPiAgICog QGh3bWdyOiAgICAgdGhlIGFkZHJlc3Mgb2YgdGhlIGhhcmR3YXJlIG1hbmFnZXIuCj4gQEAgLTI4 NjMsOCArMjg2NSw4IEBAIHN0YXRpYyBpbnQgdmVnYTEwX3N0b3BfZHBtKHN0cnVjdCBwcF9od21n ciAqaHdtZ3IsIHVpbnQzMl90IGJpdG1hcCkKPiAgLyoqCj4gICAqIFRlbGwgU01DIHRvIGVuYWJs ZWQgdGhlIHN1cHBvcnRlZCBEUE1zLgo+ICAgKgo+IC0gKiBAaHdtZ3I6ICB0aGUgYWRkcmVzcyBv ZiB0aGUgcG93ZXJwbGF5IGhhcmR3YXJlIG1hbmFnZXIuCj4gLSAqIEBiaXRtYXAgIGJpdG1hcCBm b3IgdGhlIGZlYXR1cmVzIHRvIGVuYWJsZWQuCj4gKyAqIEBod21ncjogICB0aGUgYWRkcmVzcyBv ZiB0aGUgcG93ZXJwbGF5IGhhcmR3YXJlIG1hbmFnZXIuCj4gKyAqIEBiaXRtYXA6ICBiaXRtYXAg Zm9yIHRoZSBmZWF0dXJlcyB0byBlbmFibGVkLgo+ICAgKiByZXR1cm46ICAwIG9uIGF0IGxlYXN0 IG9uZSBEUE0gaXMgc3VjY2Vzc2Z1bGx5IGVuYWJsZWQuCj4gICAqLwo+ICBzdGF0aWMgaW50IHZl Z2ExMF9zdGFydF9kcG0oc3RydWN0IHBwX2h3bWdyICpod21nciwgdWludDMyX3QgYml0bWFwKQo+ IC0tCj4gMi4yNS4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE88C433E6 for ; Fri, 8 Jan 2021 21:15:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AA0823A80 for ; Fri, 8 Jan 2021 21:15:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AA0823A80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE7FD6E8E3; Fri, 8 Jan 2021 21:15:46 +0000 (UTC) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC38F6E8DE; Fri, 8 Jan 2021 21:15:44 +0000 (UTC) Received: by mail-ot1-x335.google.com with SMTP id q25so11037856otn.10; Fri, 08 Jan 2021 13:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=RdHU0V+l/5mQjoD9Rkq0FokpPahQQiZHJdwaPeqIFOw=; b=N/9q3tnXNvoXj9NNSpNsp/WqUeWVnlXZmfdK5XKDodktfsDUrcKtMMoGr3+ipiy+kJ LSIfJyZzXDXtETPGIqnqGxqqHpxB9795RthL27QqsKOxtHlej07Jxk+VIk02x2vd5hLJ te5c3x9ZnSsi4p3D4P/7sBKCCs2vt2qB8JSpQiaJa0FoKFMLS+4/Hyla3wFQ6nKjBGuc oWwf64peHkELSW1QZsJRj+JSDPUuNtgOdYtDy1whEUtvKRbxmLJTLlY5EfEugO4y/awo 8RjDEf2IScxGiMTzkQXE4agUt3YLLGoMaCW9jB+VtO5/0827gEWrmQQimdkjHRu1iwBZ sMeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=RdHU0V+l/5mQjoD9Rkq0FokpPahQQiZHJdwaPeqIFOw=; b=opJMv+0nHhWyskFBSHx3VorIHILzfM28NYGgiHNj0r15ftdONI6+YiwbawNtInMBld vYC1NeEIoAfOlPrGRXUtv0z/p9Y4T07TesU+9Y53QFKnvWVH9cOlbBuSIjtr3ZInHKAa bqGfjxg51ydhDuOb2s6fgf2g+kUdju46t2T4xX7r9ThgtcBe56xas/nIx2bSI3A09IxN zSTw4KxhsgqEKEc8YS99Cm/pU4McbhXEAcyR2R+Se+jAsRpPI8JHNwTwhTdwQblgmGPK enkzI7ZFEvw7+GIKEKl2KF2+KmvCD646oRcgRuwCxC7dr8IPIkNgyUqtik+d7j0CJgNo ZN0w== X-Gm-Message-State: AOAM532CpmSQmVszXvjN+0BOQPMf8wAEo1jkSvuigA5Td7k/b10ArdI+ 80NVFxV6Os0jEFkBQuQuDzj1hqH6fhJBquYDVwtMnPGK X-Google-Smtp-Source: ABdhPJxUgRAka2RPKA+U8s8ytzVCIDZKjm/nFhiLdVPVHrGZ4YUvczYtQ+lBCAP0taI+zW0Tsik0GJrHRn2GsSUX9Zg= X-Received: by 2002:a05:6830:1b7b:: with SMTP id d27mr4083848ote.132.1610140544373; Fri, 08 Jan 2021 13:15:44 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-28-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-28-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 16:15:33 -0500 Message-ID: Subject: Re: [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy function headers, demote barely documented one To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gRnJpLCBKYW4gOCwgMjAyMSBhdCAzOjE1IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vcG0vcG93ZXJwbGF5 L2h3bWdyL3ZlZ2ExMF9od21nci5jOjE1NTY6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBv ciBtZW1iZXIgJ2FjZ19mcmVxJyBub3QgZGVzY3JpYmVkIGluICd2ZWdhMTBfcG9wdWxhdGVfc2lu Z2xlX2dmeF9sZXZlbCcKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vcG0vcG93ZXJw bGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jOjE2MjE6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRl ciBvciBtZW1iZXIgJ2N1cnJlbnRfc29jX2RpZCcgbm90IGRlc2NyaWJlZCBpbiAndmVnYTEwX3Bv cHVsYXRlX3NpbmdsZV9zb2NfbGV2ZWwnCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4u L3BtL3Bvd2VycGxheS9od21nci92ZWdhMTBfaHdtZ3IuYzoxNjIxOiB3YXJuaW5nOiBGdW5jdGlv biBwYXJhbWV0ZXIgb3IgbWVtYmVyICdjdXJyZW50X3ZvbF9pbmRleCcgbm90IGRlc2NyaWJlZCBp biAndmVnYTEwX3BvcHVsYXRlX3NpbmdsZV9zb2NfbGV2ZWwnCj4gIGRyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1Ly4uL3BtL3Bvd2VycGxheS9od21nci92ZWdhMTBfaHdtZ3IuYzoxNjIxOiB3YXJu aW5nOiBFeGNlc3MgZnVuY3Rpb24gcGFyYW1ldGVyICdjdXJyZW50X3NvY2Nsa19sZXZlbCcgZGVz Y3JpcHRpb24gaW4gJ3ZlZ2ExMF9wb3B1bGF0ZV9zaW5nbGVfc29jX2xldmVsJwo+ICBkcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9wbS9wb3dlcnBsYXkvaHdtZ3IvdmVnYTEwX2h3bWdyLmM6 MTc1Nzogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAnY3VycmVudF9tZW1f dmlkJyBub3QgZGVzY3JpYmVkIGluICd2ZWdhMTBfcG9wdWxhdGVfc2luZ2xlX21lbW9yeV9sZXZl bCcKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vcG0vcG93ZXJwbGF5L2h3bWdyL3Zl Z2ExMF9od21nci5jOjE3NTc6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIg J2N1cnJlbnRfbWVtY2xrX2xldmVsJyBub3QgZGVzY3JpYmVkIGluICd2ZWdhMTBfcG9wdWxhdGVf c2luZ2xlX21lbW9yeV9sZXZlbCcKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vcG0v cG93ZXJwbGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jOjE3NTc6IHdhcm5pbmc6IEZ1bmN0aW9uIHBh cmFtZXRlciBvciBtZW1iZXIgJ2N1cnJlbnRfbWVtX3NvY192aW5kJyBub3QgZGVzY3JpYmVkIGlu ICd2ZWdhMTBfcG9wdWxhdGVfc2luZ2xlX21lbW9yeV9sZXZlbCcKPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvLi4vcG0vcG93ZXJwbGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jOjI4NzE6IHdh cm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1iZXIgJ2JpdG1hcCcgbm90IGRlc2NyaWJl ZCBpbiAndmVnYTEwX3N0YXJ0X2RwbScKPgo+IENjOiBFdmFuIFF1YW4gPGV2YW4ucXVhbkBhbWQu Y29tPgo+IENjOiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gQ2M6 ICJDaHJpc3RpYW4gS8O2bmlnIiA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IENjOiBEYXZp ZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBm ZndsbC5jaD4KPiBDYzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVl LmpvbmVzQGxpbmFyby5vcmc+CgpBcHBsaWVkLiAgVGhhbmtzIQoKQWxleAoKCj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L2h3bWdyL3ZlZ2ExMF9od21nci5jIHwgMTAg KysrKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L2h3 bWdyL3ZlZ2ExMF9od21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvaHdt Z3IvdmVnYTEwX2h3bWdyLmMKPiBpbmRleCBkYTQ3MDQ2MmQ2ZTJjLi4yOWM5OTY0MmQyMmQ0IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L2h3bWdyL3ZlZ2Ex MF9od21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvaHdtZ3Iv dmVnYTEwX2h3bWdyLmMKPiBAQCAtMTU0OSw2ICsxNTQ5LDcgQEAgc3RhdGljIGludCB2ZWdhMTBf cG9wdWxhdGVfc21jX2xpbmtfbGV2ZWxzKHN0cnVjdCBwcF9od21nciAqaHdtZ3IpCj4gICAqIEBo d21ncjogICAgICB0aGUgYWRkcmVzcyBvZiB0aGUgaGFyZHdhcmUgbWFuYWdlcgo+ICAgKiBAZ2Z4 X2Nsb2NrOiAgdGhlIEdGWCBjbG9jayB0byB1c2UgdG8gcG9wdWxhdGUgdGhlIHN0cnVjdHVyZS4K PiAgICogQGN1cnJlbnRfZ2Z4Y2xrX2xldmVsOiAgbG9jYXRpb24gaW4gUFBUYWJsZSBmb3IgdGhl IFNNQyBHRlhDTEsgc3RydWN0dXJlLgo+ICsgKiBAYWNnX2ZyZXE6ICAgQUNHIGZyZXF1ZW50eSB0 byByZXR1cm4gKE1IeikKPiAgICovCj4gIHN0YXRpYyBpbnQgdmVnYTEwX3BvcHVsYXRlX3Npbmds ZV9nZnhfbGV2ZWwoc3RydWN0IHBwX2h3bWdyICpod21nciwKPiAgICAgICAgICAgICAgICAgdWlu dDMyX3QgZ2Z4X2Nsb2NrLCBQbGxTZXR0aW5nX3QgKmN1cnJlbnRfZ2Z4Y2xrX2xldmVsLAo+IEBA IC0xNjEyLDcgKzE2MTMsOCBAQCBzdGF0aWMgaW50IHZlZ2ExMF9wb3B1bGF0ZV9zaW5nbGVfZ2Z4 X2xldmVsKHN0cnVjdCBwcF9od21nciAqaHdtZ3IsCj4gICAqCj4gICAqIEBod21ncjogICAgIHRo ZSBhZGRyZXNzIG9mIHRoZSBoYXJkd2FyZSBtYW5hZ2VyLgo+ICAgKiBAc29jX2Nsb2NrOiB0aGUg U09DIGNsb2NrIHRvIHVzZSB0byBwb3B1bGF0ZSB0aGUgc3RydWN0dXJlLgo+IC0gKiBAY3VycmVu dF9zb2NjbGtfbGV2ZWw6IGxvY2F0aW9uIGluIFBQVGFibGUgZm9yIHRoZSBTTUMgU09DQ0xLIHN0 cnVjdHVyZS4KPiArICogQGN1cnJlbnRfc29jX2RpZDogICBERlMgZGl2aWRlciB0byBwYXNzIGJh Y2sgdG8gY2FsbGVyCj4gKyAqIEBjdXJyZW50X3ZvbF9pbmRleDogaW5kZXggb2YgY3VycmVudCBW REQgdG8gcGFzcyBiYWNrIHRvIGNhbGxlcgo+ICAgKiByZXR1cm46ICAgICAgMCBvbiBzdWNjZXNz Cj4gICAqLwo+ICBzdGF0aWMgaW50IHZlZ2ExMF9wb3B1bGF0ZV9zaW5nbGVfc29jX2xldmVsKHN0 cnVjdCBwcF9od21nciAqaHdtZ3IsCj4gQEAgLTE3NDQsNyArMTc0Niw3IEBAIHN0YXRpYyB2b2lk IHZlZ2ExMF9wb3B1bGF0ZV92ZGRjX3NvY19sZXZlbHMoc3RydWN0IHBwX2h3bWdyICpod21ncikK PiAgICAgICAgIH0KPiAgfQo+Cj4gLS8qKgo+ICsvKgo+ICAgKiBQb3B1bGF0ZXMgc2luZ2xlIFNN QyBHRlhDTEsgc3RydWN0dXJlIHVzaW5nIHRoZSBwcm92aWRlZCBjbG9jay4KPiAgICoKPiAgICog QGh3bWdyOiAgICAgdGhlIGFkZHJlc3Mgb2YgdGhlIGhhcmR3YXJlIG1hbmFnZXIuCj4gQEAgLTI4 NjMsOCArMjg2NSw4IEBAIHN0YXRpYyBpbnQgdmVnYTEwX3N0b3BfZHBtKHN0cnVjdCBwcF9od21n ciAqaHdtZ3IsIHVpbnQzMl90IGJpdG1hcCkKPiAgLyoqCj4gICAqIFRlbGwgU01DIHRvIGVuYWJs ZWQgdGhlIHN1cHBvcnRlZCBEUE1zLgo+ICAgKgo+IC0gKiBAaHdtZ3I6ICB0aGUgYWRkcmVzcyBv ZiB0aGUgcG93ZXJwbGF5IGhhcmR3YXJlIG1hbmFnZXIuCj4gLSAqIEBiaXRtYXAgIGJpdG1hcCBm b3IgdGhlIGZlYXR1cmVzIHRvIGVuYWJsZWQuCj4gKyAqIEBod21ncjogICB0aGUgYWRkcmVzcyBv ZiB0aGUgcG93ZXJwbGF5IGhhcmR3YXJlIG1hbmFnZXIuCj4gKyAqIEBiaXRtYXA6ICBiaXRtYXAg Zm9yIHRoZSBmZWF0dXJlcyB0byBlbmFibGVkLgo+ICAgKiByZXR1cm46ICAwIG9uIGF0IGxlYXN0 IG9uZSBEUE0gaXMgc3VjY2Vzc2Z1bGx5IGVuYWJsZWQuCj4gICAqLwo+ICBzdGF0aWMgaW50IHZl Z2ExMF9zdGFydF9kcG0oc3RydWN0IHBwX2h3bWdyICpod21nciwgdWludDMyX3QgYml0bWFwKQo+ IC0tCj4gMi4yNS4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==