From: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits
Date: Wed, 16 Sep 2020 00:12:01 +0800 [thread overview]
Message-ID: <CAE2XoE_he2L85WgAg5NBWKLT+FFy6RJDULsL-QWBH0jbhxZTpw@mail.gmail.com> (raw)
In-Reply-To: <4813770a-34a4-72ce-17f7-7ea451a7af99@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On Tue, Sep 15, 2020 at 10:27 PM Richard Henderson <
richard.henderson@linaro.org> wrote:
> On 9/14/20 11:27 PM, Paolo Bonzini wrote:
> > Looks good. Can you just add a "# Submodules" heading above the test?
> >
> > I would also like to remove the "yes" value (that is, the default fails
> if the
> > internal copy is not there) but it can be done later for all submodules.
>
> Unless you simply plan to rename {no, yes} to {disabled, enabled}, as for
> the
> Feature objects, why?
>
> That seems to be the only sensible value for --enable-foo, without the
> =system
> or =git specifiers. We *should* fail if no system library nor internal
> copy is
> present.
>
I suggest remove the capstone=system option cause the system library may
not satisfy the requirements of qemu
and create in-consistence expereince when bug or error happens about
capstone. We either have git submodule capstone
or nothing at all
>
>
> r~
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 1650 bytes --]
next prev parent reply other threads:[~2020-09-15 16:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 23:02 [PATCH v2 00/10] capstone + disassembler patches Richard Henderson
2020-09-14 23:02 ` [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits Richard Henderson
2020-09-14 23:06 ` Richard Henderson
2020-09-15 6:27 ` Paolo Bonzini
2020-09-15 14:27 ` Richard Henderson
2020-09-15 16:12 ` 罗勇刚(Yonggang Luo) [this message]
2020-09-15 16:59 ` Paolo Bonzini
2020-09-15 17:07 ` 罗勇刚(Yonggang Luo)
2020-09-15 17:14 ` Paolo Bonzini
2020-09-15 17:20 ` 罗勇刚(Yonggang Luo)
2020-09-15 16:58 ` Paolo Bonzini
2020-09-15 6:10 ` Thomas Huth
2020-09-14 23:02 ` [PATCH v2 02/10] capstone: Update to upstream "next" branch Richard Henderson
2020-09-14 23:02 ` [PATCH v2 03/10] disas: Move host asm annotations to tb_gen_code Richard Henderson
2020-09-15 16:36 ` Thomas Huth
2020-09-14 23:02 ` [PATCH v2 04/10] disas: Clean up CPUDebug initialization Richard Henderson
2020-09-17 14:39 ` Thomas Huth
2020-09-17 14:50 ` Thomas Huth
2020-09-17 17:06 ` Alex Bennée
2020-09-17 20:20 ` Richard Henderson
2020-09-14 23:02 ` [PATCH v2 05/10] disas: Use qemu/bswap.h for bfd endian loads Richard Henderson
2020-09-14 23:02 ` [PATCH v2 06/10] disas: Cleanup plugin_disas Richard Henderson
2020-09-14 23:02 ` [PATCH v2 07/10] disas: Configure capstone for aarch64 host without libvixl Richard Henderson
2020-09-17 14:44 ` Thomas Huth
2020-09-14 23:02 ` [PATCH v2 08/10] disas: Split out capstone code to disas/capstone.c Richard Henderson
2020-09-14 23:02 ` [PATCH v2 09/10] disas: Enable capstone disassembly for s390x Richard Henderson
2020-09-17 16:30 ` Thomas Huth
2020-09-14 23:02 ` [PATCH v2 10/10] disas/capstone: Add skipdata hook " Richard Henderson
2020-09-17 16:32 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2XoE_he2L85WgAg5NBWKLT+FFy6RJDULsL-QWBH0jbhxZTpw@mail.gmail.com \
--to=luoyonggang@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.