From: Alberto Faria <afaria@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH v2 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t
Date: Tue, 17 May 2022 15:48:59 +0100 [thread overview]
Message-ID: <CAELaAXzG6z1fBs-B3PqoO=HZkb+Z-Umdj5+KKRnhHmdt3nV9WA@mail.gmail.com> (raw)
In-Reply-To: <20220517143221.3vzwjierhnl4wx4x@redhat.com>
On Tue, May 17, 2022 at 3:33 PM Eric Blake <eblake@redhat.com> wrote:
> ...now end up calling QEMU_IOVEC_INIT_BUF() which tries to do
> .local_iov.iov_len = bytes, which can silently overflow on 32-bit
> platforms where iov_len is size_t. We need to add a code guard that
> callers do not pass in too large of a buffer.
I see. blk_co_pread() and blk_co_pwrite() use assert(bytes <=
SIZE_MAX). Would that be an appropriate safeguard here? Or should we
return an error?
Alberto
next prev parent reply other threads:[~2022-05-17 14:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 15:54 [PATCH v2 00/10] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper Alberto Faria
2022-05-13 15:54 ` [PATCH v2 01/10] block: Add a 'flags' param to bdrv_{pread, pwrite, pwrite_sync}() Alberto Faria
2022-05-13 15:54 ` [PATCH v2 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order Alberto Faria
2022-05-13 15:57 ` [PATCH v2 03/10] block: Make bdrv_{pread, pwrite}() return 0 on success Alberto Faria
2022-05-13 15:57 ` [PATCH v2 04/10] crypto: Make block callbacks " Alberto Faria
2022-05-17 14:26 ` Eric Blake
2022-05-13 15:57 ` [PATCH v2 05/10] block: Make bdrv_co_pwrite() take a const buffer Alberto Faria
2022-05-13 15:57 ` [PATCH v2 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t Alberto Faria
2022-05-17 14:32 ` Eric Blake
2022-05-17 14:48 ` Alberto Faria [this message]
2022-05-18 12:48 ` Eric Blake
2022-05-13 15:57 ` [PATCH v2 07/10] block: Implement bdrv_{pread, pwrite, pwrite_zeroes}() using generated_co_wrapper Alberto Faria
2022-05-13 15:57 ` [PATCH v2 08/10] block: Add bdrv_co_pwrite_sync() Alberto Faria
2022-05-17 14:35 ` Eric Blake
2022-05-13 15:57 ` [PATCH v2 09/10] block: Use bdrv_co_pwrite_sync() when caller is coroutine_fn Alberto Faria
2022-05-17 9:29 ` Vladimir Sementsov-Ogievskiy
2022-05-13 15:57 ` [PATCH v2 10/10] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty() Alberto Faria
2022-05-17 14:36 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELaAXzG6z1fBs-B3PqoO=HZkb+Z-Umdj5+KKRnhHmdt3nV9WA@mail.gmail.com' \
--to=afaria@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.