All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] i2c: designware_i2c: Add ic_enable_status to ic_regs struct
Date: Mon, 21 Mar 2016 16:54:31 +0800	[thread overview]
Message-ID: <CAEUhbmVcdM5ggijy9Vvpe7wwsFDVUXnQ8gnr+q40xjAjKDiVEA@mail.gmail.com> (raw)
In-Reply-To: <1458287661-21745-1-git-send-email-sr@denx.de>

Hi Stefan,

On Fri, Mar 18, 2016 at 3:54 PM, Stefan Roese <sr@denx.de> wrote:
> Add the ic_enable_status register to the ic_regs struct. Additionally

typo: i2c_regs

> the register offsets are added, to better check, if the offset matches
> the register description in the datasheet.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> ---
>  drivers/i2c/designware_i2c.h | 68 +++++++++++++++++++++++---------------------
>  1 file changed, 35 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h
> index 19b09df..270c29c 100644
> --- a/drivers/i2c/designware_i2c.h
> +++ b/drivers/i2c/designware_i2c.h
> @@ -9,39 +9,41 @@
>  #define __DW_I2C_H_
>
>  struct i2c_regs {
> -       u32 ic_con;
> -       u32 ic_tar;
> -       u32 ic_sar;
> -       u32 ic_hs_maddr;
> -       u32 ic_cmd_data;
> -       u32 ic_ss_scl_hcnt;
> -       u32 ic_ss_scl_lcnt;
> -       u32 ic_fs_scl_hcnt;
> -       u32 ic_fs_scl_lcnt;
> -       u32 ic_hs_scl_hcnt;
> -       u32 ic_hs_scl_lcnt;
> -       u32 ic_intr_stat;
> -       u32 ic_intr_mask;
> -       u32 ic_raw_intr_stat;
> -       u32 ic_rx_tl;
> -       u32 ic_tx_tl;
> -       u32 ic_clr_intr;
> -       u32 ic_clr_rx_under;
> -       u32 ic_clr_rx_over;
> -       u32 ic_clr_tx_over;
> -       u32 ic_clr_rd_req;
> -       u32 ic_clr_tx_abrt;
> -       u32 ic_clr_rx_done;
> -       u32 ic_clr_activity;
> -       u32 ic_clr_stop_det;
> -       u32 ic_clr_start_det;
> -       u32 ic_clr_gen_call;
> -       u32 ic_enable;
> -       u32 ic_status;
> -       u32 ic_txflr;
> -       u32 ix_rxflr;
> -       u32 reserved_1;
> -       u32 ic_tx_abrt_source;
> +       u32 ic_con;             /* 0x00 */
> +       u32 ic_tar;             /* 0x04 */
> +       u32 ic_sar;             /* 0x08 */
> +       u32 ic_hs_maddr;        /* 0x0c */
> +       u32 ic_cmd_data;        /* 0x10 */
> +       u32 ic_ss_scl_hcnt;     /* 0x14 */
> +       u32 ic_ss_scl_lcnt;     /* 0x18 */
> +       u32 ic_fs_scl_hcnt;     /* 0x1c */
> +       u32 ic_fs_scl_lcnt;     /* 0x20 */
> +       u32 ic_hs_scl_hcnt;     /* 0x24 */
> +       u32 ic_hs_scl_lcnt;     /* 0x28 */
> +       u32 ic_intr_stat;       /* 0x2c */
> +       u32 ic_intr_mask;       /* 0x30 */
> +       u32 ic_raw_intr_stat;   /* 0x34 */
> +       u32 ic_rx_tl;           /* 0x38 */
> +       u32 ic_tx_tl;           /* 0x3c */
> +       u32 ic_clr_intr;        /* 0x40 */
> +       u32 ic_clr_rx_under;    /* 0x44 */
> +       u32 ic_clr_rx_over;     /* 0x48 */
> +       u32 ic_clr_tx_over;     /* 0x4c */
> +       u32 ic_clr_rd_req;      /* 0x50 */
> +       u32 ic_clr_tx_abrt;     /* 0x54 */
> +       u32 ic_clr_rx_done;     /* 0x58 */
> +       u32 ic_clr_activity;    /* 0x5c */
> +       u32 ic_clr_stop_det;    /* 0x60 */
> +       u32 ic_clr_start_det;   /* 0x64 */
> +       u32 ic_clr_gen_call;    /* 0x68 */
> +       u32 ic_enable;          /* 0x6c */
> +       u32 ic_status;          /* 0x70 */
> +       u32 ic_txflr;           /* 0x74 */
> +       u32 ic_rxflr;           /* 0x78 */
> +       u32 ic_sda_hold;        /* 0x7c */
> +       u32 ic_tx_abrt_source;  /* 0x80 */
> +       u8 res1[0x18];          /* 0x84 */
> +       u32 ic_enable_status;   /* 0x9c */
>  };
>

Other than that,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Regards,
Bin

      parent reply	other threads:[~2016-03-21  8:54 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18  7:54 [U-Boot] [PATCH 1/6] i2c: designware_i2c: Add ic_enable_status to ic_regs struct Stefan Roese
2016-03-18  7:54 ` [U-Boot] [PATCH 2/6] i2c: designware_i2c: Add dw_i2c_enable() helper function Stefan Roese
2016-03-18 11:12   ` Marek Vasut
2016-03-18 12:04     ` Stefan Roese
2016-03-18 12:14       ` Marek Vasut
2016-03-21  8:54   ` Bin Meng
2016-03-18  7:54 ` [U-Boot] [PATCH 3/6] i2c: designware_i2c: Integrate set_speed() into dw_i2c_set_bus_speed() Stefan Roese
2016-03-18 11:13   ` Marek Vasut
2016-03-21  8:54   ` Bin Meng
2016-03-18  7:54 ` [U-Boot] [PATCH 4/6] i2c: designware_i2c: Prepare for DM driver conversion Stefan Roese
2016-03-21  8:54   ` Bin Meng
2016-03-18  7:54 ` [U-Boot] [PATCH 5/6] i2c: designware_i2c: Add DM support Stefan Roese
2016-03-21  8:54   ` Bin Meng
2016-04-09 18:35   ` Simon Glass
2016-03-18  7:54 ` [U-Boot] [PATCH 6/6] i2c: designware_i2c: Add support for PCI(e) based I2C cores (x86) Stefan Roese
2016-03-21  8:54   ` Bin Meng
2016-03-21  9:03     ` Stefan Roese
2016-03-21  9:05       ` Bin Meng
2016-03-21 12:04       ` Stefan Roese
2016-03-21 12:43         ` Bin Meng
2016-03-21 12:52           ` Stefan Roese
2016-03-21 14:04           ` Stefan Roese
2016-03-28  6:01             ` Bin Meng
2016-04-04 14:53               ` Stefan Roese
2016-04-11 15:03                 ` Stefan Roese
2016-04-20 14:40                   ` Simon Glass
2016-04-20 14:58                     ` Stefan Roese
2016-04-20 15:09                       ` Simon Glass
2016-04-20 15:17                         ` Stefan Roese
2016-03-18 11:09 ` [U-Boot] [PATCH 1/6] i2c: designware_i2c: Add ic_enable_status to ic_regs struct Marek Vasut
2016-03-21  8:54 ` Bin Meng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmVcdM5ggijy9Vvpe7wwsFDVUXnQ8gnr+q40xjAjKDiVEA@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.