From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A29AC4743C for ; Wed, 23 Jun 2021 09:22:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97E3F60FEE for ; Wed, 23 Jun 2021 09:22:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97E3F60FEE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7A0CD829F9; Wed, 23 Jun 2021 11:22:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="u9wbHecx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6DF4E82A01; Wed, 23 Jun 2021 11:22:43 +0200 (CEST) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A8B3F829F9 for ; Wed, 23 Jun 2021 11:22:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-qk1-x72e.google.com with SMTP id c23so3384082qkc.10 for ; Wed, 23 Jun 2021 02:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=aoXbtLwyPqpYjoP/ElEhs3L9ApM7jn0O0z+E84aJKOY=; b=u9wbHecxKQbJGvjZy2C9TRbbN8gag4YO30DDZzrggQCZzeTQo9Rd9VXKuv3gAhZkHR 6bY+N2btLm2+QljmnqUla9iUYShUsLmu20BBxR/V8NPrITb7H5JCA7fMqGUmgatqpih0 5/uvXhBTXG4+Y3dBu282QKRLB85zWK7QBbEOH0RkrKtyRQtRcpXp/oWOsfaC7Y+ioq4c MyrUfq5ZQcKaz2d5Kk7gYTouUMvdTFN71QxHUP22Rl+Xxb0+DmhHOoSgg3yBtTFNeG/t IzeK2CnQhNoJKGtRR58rJmkJ+5Tf5tsNgDmXo0C8iTVZB8jmpSHXJXLFe8VnhM9a3O9p 4VEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=aoXbtLwyPqpYjoP/ElEhs3L9ApM7jn0O0z+E84aJKOY=; b=AZY05rmTkmbY6+VBMaGxJu4dvfVGE99mrmm5T3YpmNtf1C3R3iGm28vosQgQ7tEhkO LGGvhWaEyLCVWucuNsRmLpNgVfTXraYWQZQHk4CwRkxulPLbOT2eFMQouaGhK77R6dxw swyGS8NCeutaxcHgeO6L0MyN9KaCe82WWt7IO+SQ8zhdqEq4g36fjx/FGfk5QvxGuj3j kuV0EFLxZECZMMTOULNPmG35m9dUT/amYX6yyINyQl2kPOqjx0pmewNjG6qiPJDwWOIv K9Q+o4rMioDsgZ5R3Vl1fZF57Zl9ojppj4yj1avHL0VOepTc1v8ubk7XOST+bhE9fSGv jlhg== X-Gm-Message-State: AOAM533lIVAzViEoUkzCBTnFstqkBA3UT/g9a1vUnpXDhVgLPzfHIxPX 9hNDfZ0QhtSah86iVU/VoAb/VKAiv5DuoQBEW1Y= X-Google-Smtp-Source: ABdhPJz7k90K1z/yatNbUsv0umo/d4TfnFOfdlJiisz9rMI5x8TS2gvFEvfzXpWBYy6hMUVmgFoEhi/2acfet41wyZA= X-Received: by 2002:a25:be09:: with SMTP id h9mr11233261ybk.239.1624440159642; Wed, 23 Jun 2021 02:22:39 -0700 (PDT) MIME-Version: 1.0 References: <20210622131623.21265-1-bmeng.cn@gmail.com> In-Reply-To: <20210622131623.21265-1-bmeng.cn@gmail.com> From: Bin Meng Date: Wed, 23 Jun 2021 17:22:28 +0800 Message-ID: Subject: Re: [PATCH v2 1/7] nvme: Move block dev creation from uclass post_probe() to driver probe() To: Tom Rini , U-Boot Mailing List Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Jun 22, 2021 at 9:16 PM Bin Meng wrote: > > At present the block device creation happens in the NVMe uclass > driver post_probe() phase. In preparation to support multiple > namespaces, we should issue namespace identify before creating > block devices but that touches the underlying hardware hence it > is not appropriate to do such in the uclass driver post_probe(). > Let's move it to driver probe() phase instead. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - drop the nvme per-child platdata change > > drivers/nvme/nvme-uclass.c | 30 ------------------------------ > drivers/nvme/nvme.c | 18 ++++++++++++++++++ > 2 files changed, 18 insertions(+), 30 deletions(-) > series applied to u-boot-x86, thanks!