All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: zhaolichang <zhaolichang@huawei.com>
Cc: qemu-trivial@nongnu.org,
	David Edmondson <david.edmondson@oracle.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH V2 03/14] riscv/: fix some comment spelling errors
Date: Fri, 9 Oct 2020 15:15:56 +0800	[thread overview]
Message-ID: <CAEUhbmXKmx+c3DtA2i4WzG3Hb5x+WPwMEB6dd1792gyqp2NSSA@mail.gmail.com> (raw)
In-Reply-To: <20201009064449.2336-4-zhaolichang@huawei.com>

Hi,

On Fri, Oct 9, 2020 at 2:55 PM zhaolichang <zhaolichang@huawei.com> wrote:
>
> I found that there are many spelling errors in the comments of qemu/target/riscv.
> I used spellcheck to check the spelling errors and found some errors in the folder.
>
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  target/riscv/cpu.c           | 2 +-
>  target/riscv/cpu_bits.h      | 2 +-
>  target/riscv/csr.c           | 6 +++---
>  target/riscv/vector_helper.c | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 0bbfd7f457..f40a0b26a3 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -472,7 +472,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
>                      return;
>                  }
>              } else {
> -                qemu_log("vector verison is not specified, "
> +                qemu_log("vector version is not specified, "
>                          "use the default value v0.7.1\n");
>              }
>              set_vext_version(env, vext_version);
> diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h
> index bd36062877..6e1155560b 100644
> --- a/target/riscv/cpu_bits.h
> +++ b/target/riscv/cpu_bits.h
> @@ -536,7 +536,7 @@
>  /* Leaf page shift amount */
>  #define PGSHIFT             12
>
> -/* Default Reset Vector adress */
> +/* Default Reset Vector address */
>  #define DEFAULT_RSTVEC      0x1000
>
>  /* Exception causes */
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index aaef6c6f20..93e117020d 100644
> --- a/target/riscv/csr.c
> +++ b/target/riscv/csr.c
> @@ -624,7 +624,7 @@ static int write_mcounteren(CPURISCVState *env, int csrno, target_ulong val)
>      return 0;
>  }
>
> -/* This regiser is replaced with CSR_MCOUNTINHIBIT in 1.11.0 */
> +/* This register is replaced with CSR_MCOUNTINHIBIT in 1.11.0 */
>  static int read_mscounteren(CPURISCVState *env, int csrno, target_ulong *val)
>  {
>      if (env->priv_ver < PRIV_VERSION_1_11_0) {
> @@ -634,7 +634,7 @@ static int read_mscounteren(CPURISCVState *env, int csrno, target_ulong *val)
>      return 0;
>  }
>
> -/* This regiser is replaced with CSR_MCOUNTINHIBIT in 1.11.0 */
> +/* This register is replaced with CSR_MCOUNTINHIBIT in 1.11.0 */
>  static int write_mscounteren(CPURISCVState *env, int csrno, target_ulong val)
>  {
>      if (env->priv_ver < PRIV_VERSION_1_11_0) {
> @@ -1278,7 +1278,7 @@ int riscv_csrrw(CPURISCVState *env, int csrno, target_ulong *ret_value,
>          !riscv_cpu_virt_enabled(env)) {
>          /*
>           * We are in S mode without virtualisation, therefore we are in HS Mode.
> -         * Add 1 to the effective privledge level to allow us to access the
> +         * Add 1 to the effective privilege level to allow us to access the
>           * Hypervisor CSRs.
>           */
>          effective_priv++;
> diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
> index a156573d28..fa89a6e6c1 100644
> --- a/target/riscv/vector_helper.c
> +++ b/target/riscv/vector_helper.c
> @@ -709,7 +709,7 @@ typedef void vext_amo_noatomic_fn(void *vs3, target_ulong addr,
>                                    uint32_t wd, uint32_t idx, CPURISCVState *env,
>                                    uintptr_t retaddr);
>
> -/* no atomic opreation for vector atomic insructions */
> +/* no atomic operation for vector atomic insructions */

There is still one typo here: instructions

>  #define DO_SWAP(N, M) (M)
>  #define DO_AND(N, M)  (N & M)
>  #define DO_XOR(N, M)  (N ^ M)
> --

Regards,
Bin


  reply	other threads:[~2020-10-09  7:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  6:44 [PATCH V2 00/14] fix some comment spelling errors zhaolichang
2020-10-09  6:44 ` [PATCH V2 01/14] cris/: " zhaolichang
2020-10-09 13:14   ` Eric Blake
2020-10-09  6:44 ` [PATCH V2 02/14] ppc/: " zhaolichang
2020-10-26  9:14   ` Thomas Huth
2020-10-26 10:04     ` Greg Kurz
2020-10-27  2:05     ` David Gibson
2020-10-27  2:07   ` David Gibson
2020-10-09  6:44 ` [PATCH V2 03/14] riscv/: " zhaolichang
2020-10-09  7:15   ` Bin Meng [this message]
2020-10-09  6:44 ` [PATCH V2 04/14] rx/: " zhaolichang
2020-10-26 22:14   ` Philippe Mathieu-Daudé
2020-10-09  6:44 ` [PATCH V2 05/14] tricore/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 06/14] mips/: " zhaolichang
2020-10-09 14:36   ` Philippe Mathieu-Daudé
2020-10-09 15:15     ` Philippe Mathieu-Daudé
2020-10-09  6:44 ` [PATCH V2 07/14] s390x/: " zhaolichang
2020-10-09  7:31   ` Thomas Huth
2020-10-09  6:44 ` [PATCH V2 08/14] m68k/: " zhaolichang
2020-12-12 17:10   ` Laurent Vivier
2020-12-12 17:56     ` Philippe Mathieu-Daudé
2020-12-12 19:58       ` Laurent Vivier
2020-12-12 20:04         ` Philippe Mathieu-Daudé
2020-10-09  6:44 ` [PATCH V2 09/14] sh4/: " zhaolichang
2020-10-25  0:37   ` Philippe Mathieu-Daudé
2020-10-09  6:44 ` [PATCH V2 10/14] i386/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 11/14] avr/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 12/14] arm/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 13/14] alpha/: " zhaolichang
2020-10-09  6:44 ` [PATCH V2 14/14] target/: " zhaolichang
2020-10-09  7:12 ` [PATCH V2 00/14] " no-reply
     [not found] ` <a5a68476-0ed8-08f9-f993-464317d798bf@huawei.com>
2020-10-20  6:42   ` Philippe Mathieu-Daudé
2020-10-29  2:22     ` Lichang Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEUhbmXKmx+c3DtA2i4WzG3Hb5x+WPwMEB6dd1792gyqp2NSSA@mail.gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=alistair.francis@wdc.com \
    --cc=david.edmondson@oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhaolichang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.