From: Li Wang <liwang@redhat.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] [RFC] lib: shell: Fix timeout process races
Date: Tue, 21 Sep 2021 11:45:57 +0800 [thread overview]
Message-ID: <CAEemH2dNhWjzjGok9Q2HbDaszd=YrtZpXvNv8WVAbn-kcW60JQ@mail.gmail.com> (raw)
In-Reply-To: <YUg6BM39OKgI5Ovl@yuki>
[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]
Hi Joerg,
On Mon, Sep 20, 2021 at 3:36 PM Cyril Hrubis <chrubis@suse.cz> wrote:
> Hi!
> > > There were actually several races in the shell library timeout
> handling.
> > >
> > > This commit fixes hopefully all of them by:
> > >
> > > * Reimplementing the backgroud timer in C
> > I did that once, but at that point it was kinda rejected ;)
>
Sorry, I was suggesting to solve the problem only in Shell ATM,
and it proved that it's not easy to cover all.
> > See https://lists.linux.it/pipermail/ltp/2021-May/022445.html
> > and https://lists.linux.it/pipermail/ltp/2021-May/022453.html
>
> I guess we found out the hard way that it's impossible to write raceless
> timeouts in shell.
+1 Indeed.
--
Regards,
Li Wang
[-- Attachment #1.2: Type: text/html, Size: 1834 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-21 3:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 14:17 [LTP] [PATCH] [RFC] lib: shell: Fix timeout process races Cyril Hrubis
2021-09-17 14:17 ` Cyril Hrubis
2021-09-20 4:51 ` Joerg Vehlow
2021-09-20 7:36 ` Cyril Hrubis
2021-09-20 12:02 ` Cyril Hrubis
2021-09-21 3:45 ` Li Wang [this message]
2021-09-20 7:52 ` Petr Vorel
2021-09-20 7:58 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEemH2dNhWjzjGok9Q2HbDaszd=YrtZpXvNv8WVAbn-kcW60JQ@mail.gmail.com' \
--to=liwang@redhat.com \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.