From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Quentin Monnet <quentin@isovalent.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v3 08/10] samples/bpf: update .gitignore
Date: Wed, 6 Oct 2021 11:25:36 -0700 [thread overview]
Message-ID: <CAEf4BzaTbHHZ3+AtRxo9_LoS3bC6RKMw-cV5ME3qdoY9eB-7kQ@mail.gmail.com> (raw)
In-Reply-To: <CAEf4Bzaq460PCWTZ7jz1dcTR-Rp2nNMUKbO3UFZ-43qSsf-JLg@mail.gmail.com>
On Wed, Oct 6, 2021 at 11:24 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Sun, Oct 3, 2021 at 12:22 PM Quentin Monnet <quentin@isovalent.com> wrote:
> >
> > Update samples/bpf/.gitignore to ignore files generated when building
> > the samples. Add:
> >
> > - vmlinux.h
> > - the generated skeleton files (*.skel.h)
> > - the samples/bpf/libbpf/ and .../bpftool/ directories, recently
> > introduced as an output directory for building libbpf and bpftool.
> >
> > Signed-off-by: Quentin Monnet <quentin@isovalent.com>
> > ---
> > samples/bpf/.gitignore | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
> > index fcba217f0ae2..09a091b8a4f3 100644
> > --- a/samples/bpf/.gitignore
> > +++ b/samples/bpf/.gitignore
> > @@ -57,3 +57,7 @@ testfile.img
> > hbm_out.log
> > iperf.*
> > *.out
> > +*.skel.h
> > +vmlinux.h
> > +bpftool/
> > +libbpf/
>
> this will match files and directories in any subdir as well, maybe
> let's add / in front to be explicit about doing this only on current
> directly level (*.skel.h is fine)?
Oh, let's also move this patch before the samples/bpf changes, so that
there is no intermediate state between commits where we have these
files not ignored
>
> > --
> > 2.30.2
> >
next prev parent reply other threads:[~2021-10-06 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 19:21 [PATCH bpf-next v3 00/10] install libbpf headers when using the library Quentin Monnet
2021-10-03 19:21 ` [PATCH bpf-next v3 01/10] tools: bpftool: remove unused includes to <bpf/bpf_gen_internal.h> Quentin Monnet
2021-10-03 19:22 ` [PATCH bpf-next v3 02/10] tools: bpftool: install libbpf headers instead of including the dir Quentin Monnet
2021-10-03 19:22 ` [PATCH bpf-next v3 03/10] tools: resolve_btfids: install libbpf headers when building Quentin Monnet
2021-10-03 19:22 ` [PATCH bpf-next v3 04/10] tools: runqslower: " Quentin Monnet
2021-10-06 18:20 ` Andrii Nakryiko
2021-10-03 19:22 ` [PATCH bpf-next v3 05/10] bpf: preload: " Quentin Monnet
2021-10-06 18:21 ` Andrii Nakryiko
2021-10-03 19:22 ` [PATCH bpf-next v3 06/10] bpf: iterators: " Quentin Monnet
2021-10-03 19:22 ` [PATCH bpf-next v3 07/10] samples/bpf: " Quentin Monnet
2021-10-06 18:23 ` Andrii Nakryiko
2021-10-03 19:22 ` [PATCH bpf-next v3 08/10] samples/bpf: update .gitignore Quentin Monnet
2021-10-06 18:24 ` Andrii Nakryiko
2021-10-06 18:25 ` Andrii Nakryiko [this message]
2021-10-03 19:22 ` [PATCH bpf-next v3 09/10] selftests/bpf: better clean up for runqslower in test_bpftool_build.sh Quentin Monnet
2021-10-03 19:22 ` [PATCH bpf-next v3 10/10] tools: bpftool: add install-bin target to install binary only Quentin Monnet
2021-10-06 18:28 ` [PATCH bpf-next v3 00/10] install libbpf headers when using the library Andrii Nakryiko
2021-10-07 19:43 ` Quentin Monnet
2021-10-07 21:24 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzaTbHHZ3+AtRxo9_LoS3bC6RKMw-cV5ME3qdoY9eB-7kQ@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.