On Tue, Jan 24, 2023 at 9:21 PM Richard Henderson < richard.henderson@linaro.org> wrote: > On 1/24/23 09:59, Christoph Muellner wrote: > > +static bool trans_th_sfence_vmas(DisasContext *ctx, arg_th_sfence_vmas > *a) > > +{ > > + (void) a; > > + REQUIRE_XTHEADSYNC(ctx); > > + > > +#ifndef CONFIG_USER_ONLY > > + REQUIRE_PRIV_MS(ctx); > > + decode_save_opc(ctx); > > + gen_helper_tlb_flush_all(cpu_env); > > Why are you using decode_save_opc() when helper_tlb_flush_all() cannot > raise an exception? > No particular reason. Will be dropped. Thanks, Christoph > > > r~ >