From: Tamas K Lengyel <tamas.lengyel@zentific.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] vm_event: Sanitize vm_event response handling
Date: Wed, 14 Sep 2016 09:14:09 -0600 [thread overview]
Message-ID: <CAErYnshjfFz+BZd6yH1j1icH-jmt6jUm5xWrz04NDHBin2RWdg@mail.gmail.com> (raw)
In-Reply-To: <20e39e5d-b2b9-aff0-3ab4-741cf2d856a1@arm.com>
On Wed, Sep 14, 2016 at 3:33 AM, Julien Grall <julien.grall@arm.com> wrote:
> Hello Tamas,
>
> On 13/09/16 19:12, Tamas K Lengyel wrote:
>>
>> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
>> index 53c4d78..5e9bc54 100644
>> --- a/xen/include/asm-arm/p2m.h
>> +++ b/xen/include/asm-arm/p2m.h
>> @@ -121,10 +121,10 @@ typedef enum {
>> p2m_to_mask(p2m_map_foreign)))
>>
>> static inline
>> -void p2m_mem_access_emulate_check(struct vcpu *v,
>> +bool_t p2m_mem_access_emulate_check(struct vcpu *v,
>> const vm_event_response_t *rsp)
>
>
> s/bool_t/bool/ and please indent properly the second line.
Fine by me but bool_t is used throughout p2m.h and I see no use of
just bool. Is there actually any difference between the two to warrant
enforcing one over the other?
>
> Please indent properly the second line.
Ack.
>
> Regards,
>
> --
> Julien Grall
Thanks,
Tamas
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-14 15:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 18:12 [PATCH 1/2] vm_event: Sanitize vm_event response handling Tamas K Lengyel
2016-09-13 18:12 ` [PATCH 2/2] x86/vm_event: Allow returning i-cache for emulation Tamas K Lengyel
2016-09-14 7:58 ` Razvan Cojocaru
2016-09-15 16:36 ` Tamas K Lengyel
2016-09-15 17:08 ` Razvan Cojocaru
2016-09-16 7:21 ` Razvan Cojocaru
2016-09-16 15:37 ` Tamas K Lengyel
2016-09-16 16:09 ` Razvan Cojocaru
2016-09-14 15:55 ` Jan Beulich
2016-09-14 16:20 ` Tamas K Lengyel
2016-09-15 5:58 ` Jan Beulich
2016-09-15 15:27 ` Tamas K Lengyel
2016-09-15 16:09 ` Jan Beulich
2016-09-14 7:49 ` [PATCH 1/2] vm_event: Sanitize vm_event response handling Razvan Cojocaru
2016-09-14 9:33 ` Julien Grall
2016-09-14 15:14 ` Tamas K Lengyel [this message]
2016-09-14 15:15 ` Julien Grall
2016-09-14 15:19 ` Tamas K Lengyel
2016-09-14 13:38 ` George Dunlap
2016-09-14 15:11 ` Tamas K Lengyel
2016-09-15 10:35 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAErYnshjfFz+BZd6yH1j1icH-jmt6jUm5xWrz04NDHBin2RWdg@mail.gmail.com \
--to=tamas.lengyel@zentific.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.