From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C275C43381 for ; Mon, 11 Mar 2019 21:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB1F52087C for ; Mon, 11 Mar 2019 21:19:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="scmnTBde" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728535AbfCKVTM (ORCPT ); Mon, 11 Mar 2019 17:19:12 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:45211 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727686AbfCKVTM (ORCPT ); Mon, 11 Mar 2019 17:19:12 -0400 Received: by mail-oi1-f194.google.com with SMTP id t82so293402oie.12; Mon, 11 Mar 2019 14:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vl+etrAUgCpe9fsjHd06euM2vV1upm3SvdC8UB6mEEg=; b=scmnTBdeU1WLv8FGWntVQlu71VYSiwb4WArqky8UJw158K+g1Sx8hThMfpbl7Q72CT 3ur6NDyCChD8KP0nBAhniV/Ch1hgnjEvIbLXk8a5Q7JOMXXKS47ZwiWwSbXFMG2ForNA ry1QupgOMUBCcy2bzfw34YDPdfMNRN/1QkK2zbvtT0mLimwje9dX4XFjXFKTSLaIvxma QuaYTiYElUWcl2cXVKXM3yryobx937YrBmgwWHLDlvK3LFjloQFQ2fFtoRm6XeBBu8fk WKN578XSGV8T6hu0dwRXWEYSQSZfMllwjJmfCIScITddCVDkeEIErBzUULWZI4RbkkNv KPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vl+etrAUgCpe9fsjHd06euM2vV1upm3SvdC8UB6mEEg=; b=rZt0ZjPW9dCML5md+2pJgmK++ZAdsNU4fJ5rJ7Zc58QLqnW2sneytY57mDZlfjmge9 C+2AS/jc30b150JQjKryOYqUgNpiV3fkovgFo42QHRTOXM7L9UeW3UqLicHkQ1YUFnVZ kMIX8mXRpB+MjiwpLm9fnjYncQG6kkNs5xOlnm7Yq4QF9pbLa5rbxS7/nKAl3b5tJLQw tNEp+qvpMm2igxXaJprPjn3W0J7jE2IaI2XBKnOPoxwucSBAILnLwXI4hbY7XMFEsvjZ 0FaeGiGev7qTg4jTDwxo5XOEjrSPDQDvIkjdQG6AVvz0HTc5D3mZXEl7SlXf7Hofwc0x qx3Q== X-Gm-Message-State: APjAAAXnGM4H6rRh+XoU9e9Y5UJhP5wVSQx4QtAlJazPvYkgXFYLOTVE 8fkzlISlVH4iv+av9DGEFmnJ3+MIvDG9ESOMTx4= X-Google-Smtp-Source: APXvYqyHe9QPMFYdAufSMRbPPGqAb+8CcQWIIfPWsC828Moci52N5yUQIeMvh5JngJp06jz3riVakXooHaVEKj82QiE= X-Received: by 2002:aca:c286:: with SMTP id s128mr177191oif.39.1552339151283; Mon, 11 Mar 2019 14:19:11 -0700 (PDT) MIME-Version: 1.0 References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-9-narmstrong@baylibre.com> <1551924176.2210.104.camel@mhfsdcap03> <6eaff413-d2c7-125a-f165-e4226c7a153e@baylibre.com> In-Reply-To: <6eaff413-d2c7-125a-f165-e4226c7a153e@baylibre.com> From: Martin Blumenstingl Date: Mon, 11 Mar 2019 22:19:00 +0100 Message-ID: Subject: Re: [PATCH v2 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue To: Neil Armstrong Cc: Chunfeng Yun , balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 7, 2019 at 10:46 AM Neil Armstrong wrote: [...] > >> + /* Setup role switcher */ > >> + priv->switch_desc.usb2_port = dwc3_meson_g12_find_child(dev, > >> + "snps,dwc3"); > >> + priv->switch_desc.udc = dwc3_meson_g12_find_child(dev, "snps,dwc2"); > >> + priv->switch_desc.allow_userspace_control = true; > >> + priv->switch_desc.set = dwc3_meson_g12a_role_set; > >> + priv->switch_desc.get = dwc3_meson_g12a_role_get; > > to me, use a local variable for switch_desc > > I'm never fan of changing a local global variable for a driver instance, > is it strictly required ? usb_role_switch_register (which is called a few lines below this) copies all data from "struct usb_role_switch_desc" to a newly allocated "struct usb_role_switch" in other words: you could make it a stack-variable personally I have no preference so I leave the decision up to you Regards Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,8/8] usb: dwc3: Add Amlogic G12A DWC3 glue From: Martin Blumenstingl Message-Id: Date: Mon, 11 Mar 2019 22:19:00 +0100 To: Neil Armstrong Cc: Chunfeng Yun , balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-ID: T24gVGh1LCBNYXIgNywgMjAxOSBhdCAxMDo0NiBBTSBOZWlsIEFybXN0cm9uZyA8bmFybXN0cm9u Z0BiYXlsaWJyZS5jb20+IHdyb3RlOgpbLi4uXQo+ID4+ICsgICAgLyogU2V0dXAgcm9sZSBzd2l0 Y2hlciAqLwo+ID4+ICsgICAgcHJpdi0+c3dpdGNoX2Rlc2MudXNiMl9wb3J0ID0gZHdjM19tZXNv bl9nMTJfZmluZF9jaGlsZChkZXYsCj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJzbnBzLGR3YzMiKTsKPiA+PiArICAgIHBy aXYtPnN3aXRjaF9kZXNjLnVkYyA9IGR3YzNfbWVzb25fZzEyX2ZpbmRfY2hpbGQoZGV2LCAic25w cyxkd2MyIik7Cj4gPj4gKyAgICBwcml2LT5zd2l0Y2hfZGVzYy5hbGxvd191c2Vyc3BhY2VfY29u dHJvbCA9IHRydWU7Cj4gPj4gKyAgICBwcml2LT5zd2l0Y2hfZGVzYy5zZXQgPSBkd2MzX21lc29u X2cxMmFfcm9sZV9zZXQ7Cj4gPj4gKyAgICBwcml2LT5zd2l0Y2hfZGVzYy5nZXQgPSBkd2MzX21l c29uX2cxMmFfcm9sZV9nZXQ7Cj4gPiB0byBtZSwgdXNlIGEgbG9jYWwgdmFyaWFibGUgZm9yIHN3 aXRjaF9kZXNjCj4KPiBJJ20gbmV2ZXIgZmFuIG9mIGNoYW5naW5nIGEgbG9jYWwgZ2xvYmFsIHZh cmlhYmxlIGZvciBhIGRyaXZlciBpbnN0YW5jZSwKPiBpcyBpdCBzdHJpY3RseSByZXF1aXJlZCA/ CnVzYl9yb2xlX3N3aXRjaF9yZWdpc3RlciAod2hpY2ggaXMgY2FsbGVkIGEgZmV3IGxpbmVzIGJl bG93IHRoaXMpCmNvcGllcyBhbGwgZGF0YSBmcm9tICJzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoX2Rl c2MiIHRvIGEgbmV3bHkKYWxsb2NhdGVkICJzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoIgppbiBvdGhl ciB3b3JkczogeW91IGNvdWxkIG1ha2UgaXQgYSBzdGFjay12YXJpYWJsZQoKcGVyc29uYWxseSBJ IGhhdmUgbm8gcHJlZmVyZW5jZSBzbyBJIGxlYXZlIHRoZSBkZWNpc2lvbiB1cCB0byB5b3UKCgpS ZWdhcmRzCk1hcnRpbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C9F0C43381 for ; Mon, 11 Mar 2019 21:19:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E42E32087C for ; Mon, 11 Mar 2019 21:19:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="neiMn/2+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="scmnTBde" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E42E32087C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zq2roH18pOSJ3GV/LrsWD2WJyFebOSE4M/Kto+O46ic=; b=neiMn/2+RnP4Ys 9VPJYVaQtiGTgH3irYQfHA4Bk+qmb+62bAGtVQfUfvcADSqM1FrY+lNjX2qBbZF+iFsF8TLjPSN18 CLMA1/m1P9klAbkKLM5Hkd13tN+wDsPIqK/YjmaRvmUOg51qggBTmyTyT6ZHB1WiPc4ZMsrs6MNa/ UEiZ4TdM8zYphEjZJpgdwKee58+dvtEm0O/DLZnWYnVK53CPt6G1njs932j83Q1UvN3sqS3fLnro6 UN6Jq8jdXK9qHdsrrKRsYE8gjAY8puTDBDxWwnn92Uw0OB9BU1LR8tF3clvfz0VyswpmwLsEZQgrk g3IkZb67VRlhFIZ0MMjw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3SKM-0001x3-7j; Mon, 11 Mar 2019 21:19:18 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3SKH-0001w2-Jp; Mon, 11 Mar 2019 21:19:15 +0000 Received: by mail-oi1-x243.google.com with SMTP id i8so303607oib.10; Mon, 11 Mar 2019 14:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vl+etrAUgCpe9fsjHd06euM2vV1upm3SvdC8UB6mEEg=; b=scmnTBdeU1WLv8FGWntVQlu71VYSiwb4WArqky8UJw158K+g1Sx8hThMfpbl7Q72CT 3ur6NDyCChD8KP0nBAhniV/Ch1hgnjEvIbLXk8a5Q7JOMXXKS47ZwiWwSbXFMG2ForNA ry1QupgOMUBCcy2bzfw34YDPdfMNRN/1QkK2zbvtT0mLimwje9dX4XFjXFKTSLaIvxma QuaYTiYElUWcl2cXVKXM3yryobx937YrBmgwWHLDlvK3LFjloQFQ2fFtoRm6XeBBu8fk WKN578XSGV8T6hu0dwRXWEYSQSZfMllwjJmfCIScITddCVDkeEIErBzUULWZI4RbkkNv KPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vl+etrAUgCpe9fsjHd06euM2vV1upm3SvdC8UB6mEEg=; b=Shwb5J1U7KhbRPS3up/DTXlvW9Ne9Kt90FBl+eEKPJYLMEK0roHlC5GSwARzX04WII x7ZlVvBl8VlEVhE5qmn3luoFf6hpLNtDzo+FQoO1zqOoIoZ6zDk1PvaNRygeMZfTKZVl gZQPBBRKqwASnAqprkoYTKPa/HEQ22RkBA9M9GJzdFWSJjkF57Ho5Pm3HoTADTQzBbIv CcSkocYJHOL64/jZ89MbxYPz+ECIjp7tUVvtmxDRn0pXYOech8+KgHDWPHYa3nk8TgE9 scuO39TuJLjJFVYAclyEZyWiiYzOiZegl5tINxYKEE/Xusrmu8/YU/+GdtoXS3oz+0rr bzTw== X-Gm-Message-State: APjAAAXrd++Z4JDGOBpZZryfCy15stC3vkTCK0dyvDwBdbjNX5YB/xUU MUhsPlXPi9XAIW6Oexi8wzkaUzpzajmVthaTZtc= X-Google-Smtp-Source: APXvYqyHe9QPMFYdAufSMRbPPGqAb+8CcQWIIfPWsC828Moci52N5yUQIeMvh5JngJp06jz3riVakXooHaVEKj82QiE= X-Received: by 2002:aca:c286:: with SMTP id s128mr177191oif.39.1552339151283; Mon, 11 Mar 2019 14:19:11 -0700 (PDT) MIME-Version: 1.0 References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-9-narmstrong@baylibre.com> <1551924176.2210.104.camel@mhfsdcap03> <6eaff413-d2c7-125a-f165-e4226c7a153e@baylibre.com> In-Reply-To: <6eaff413-d2c7-125a-f165-e4226c7a153e@baylibre.com> From: Martin Blumenstingl Date: Mon, 11 Mar 2019 22:19:00 +0100 Message-ID: Subject: Re: [PATCH v2 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_141913_694277_58827B2D X-CRM114-Status: UNSURE ( 8.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, Chunfeng Yun , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 7, 2019 at 10:46 AM Neil Armstrong wrote: [...] > >> + /* Setup role switcher */ > >> + priv->switch_desc.usb2_port = dwc3_meson_g12_find_child(dev, > >> + "snps,dwc3"); > >> + priv->switch_desc.udc = dwc3_meson_g12_find_child(dev, "snps,dwc2"); > >> + priv->switch_desc.allow_userspace_control = true; > >> + priv->switch_desc.set = dwc3_meson_g12a_role_set; > >> + priv->switch_desc.get = dwc3_meson_g12a_role_get; > > to me, use a local variable for switch_desc > > I'm never fan of changing a local global variable for a driver instance, > is it strictly required ? usb_role_switch_register (which is called a few lines below this) copies all data from "struct usb_role_switch_desc" to a newly allocated "struct usb_role_switch" in other words: you could make it a stack-variable personally I have no preference so I leave the decision up to you Regards Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4FC8C43381 for ; Mon, 11 Mar 2019 21:19:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A40202087C for ; Mon, 11 Mar 2019 21:19:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="synEHKpp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="scmnTBde" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A40202087C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AdahkwH0f/y8e7BNGGit8tBn8OPGw6AJ0Hb4T2QxFXw=; b=synEHKppzxYaOK bOvUeojb5/prrdHNxk3GQ8ddDnGchvXwLWPCDPoe3J6TRBhV6pOFQVP47lsn7ILYISlf1ryJfz8VZ yFq0yG4ZXJm8j24Z5Lj9hfmDSGTZy1mAF9wimRahZ00MJOPlSf2qnVT1bGhJdlXoWCpeyF50ZHzaw pD4wayFRxJRdhlrbQcM2yp0CssW3WYLtjOq8JTV4DkzEoHx3UpOspALI2TSvI/SCzhZcJah7fEQmg PviZsdOXMhi91gtT0RSIJKDkqiAeLVO7gDA1T+T1ExC/rd6F8o28OIdhkNzQu8p3m/ZF/MJsJpnQe W+fhrmn9XLAseXKs78ew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3SKK-0001wS-S5; Mon, 11 Mar 2019 21:19:16 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3SKH-0001w2-Jp; Mon, 11 Mar 2019 21:19:15 +0000 Received: by mail-oi1-x243.google.com with SMTP id i8so303607oib.10; Mon, 11 Mar 2019 14:19:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vl+etrAUgCpe9fsjHd06euM2vV1upm3SvdC8UB6mEEg=; b=scmnTBdeU1WLv8FGWntVQlu71VYSiwb4WArqky8UJw158K+g1Sx8hThMfpbl7Q72CT 3ur6NDyCChD8KP0nBAhniV/Ch1hgnjEvIbLXk8a5Q7JOMXXKS47ZwiWwSbXFMG2ForNA ry1QupgOMUBCcy2bzfw34YDPdfMNRN/1QkK2zbvtT0mLimwje9dX4XFjXFKTSLaIvxma QuaYTiYElUWcl2cXVKXM3yryobx937YrBmgwWHLDlvK3LFjloQFQ2fFtoRm6XeBBu8fk WKN578XSGV8T6hu0dwRXWEYSQSZfMllwjJmfCIScITddCVDkeEIErBzUULWZI4RbkkNv KPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vl+etrAUgCpe9fsjHd06euM2vV1upm3SvdC8UB6mEEg=; b=Shwb5J1U7KhbRPS3up/DTXlvW9Ne9Kt90FBl+eEKPJYLMEK0roHlC5GSwARzX04WII x7ZlVvBl8VlEVhE5qmn3luoFf6hpLNtDzo+FQoO1zqOoIoZ6zDk1PvaNRygeMZfTKZVl gZQPBBRKqwASnAqprkoYTKPa/HEQ22RkBA9M9GJzdFWSJjkF57Ho5Pm3HoTADTQzBbIv CcSkocYJHOL64/jZ89MbxYPz+ECIjp7tUVvtmxDRn0pXYOech8+KgHDWPHYa3nk8TgE9 scuO39TuJLjJFVYAclyEZyWiiYzOiZegl5tINxYKEE/Xusrmu8/YU/+GdtoXS3oz+0rr bzTw== X-Gm-Message-State: APjAAAXrd++Z4JDGOBpZZryfCy15stC3vkTCK0dyvDwBdbjNX5YB/xUU MUhsPlXPi9XAIW6Oexi8wzkaUzpzajmVthaTZtc= X-Google-Smtp-Source: APXvYqyHe9QPMFYdAufSMRbPPGqAb+8CcQWIIfPWsC828Moci52N5yUQIeMvh5JngJp06jz3riVakXooHaVEKj82QiE= X-Received: by 2002:aca:c286:: with SMTP id s128mr177191oif.39.1552339151283; Mon, 11 Mar 2019 14:19:11 -0700 (PDT) MIME-Version: 1.0 References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-9-narmstrong@baylibre.com> <1551924176.2210.104.camel@mhfsdcap03> <6eaff413-d2c7-125a-f165-e4226c7a153e@baylibre.com> In-Reply-To: <6eaff413-d2c7-125a-f165-e4226c7a153e@baylibre.com> From: Martin Blumenstingl Date: Mon, 11 Mar 2019 22:19:00 +0100 Message-ID: Subject: Re: [PATCH v2 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_141913_694277_58827B2D X-CRM114-Status: UNSURE ( 8.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, Chunfeng Yun , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Thu, Mar 7, 2019 at 10:46 AM Neil Armstrong wrote: [...] > >> + /* Setup role switcher */ > >> + priv->switch_desc.usb2_port = dwc3_meson_g12_find_child(dev, > >> + "snps,dwc3"); > >> + priv->switch_desc.udc = dwc3_meson_g12_find_child(dev, "snps,dwc2"); > >> + priv->switch_desc.allow_userspace_control = true; > >> + priv->switch_desc.set = dwc3_meson_g12a_role_set; > >> + priv->switch_desc.get = dwc3_meson_g12a_role_get; > > to me, use a local variable for switch_desc > > I'm never fan of changing a local global variable for a driver instance, > is it strictly required ? usb_role_switch_register (which is called a few lines below this) copies all data from "struct usb_role_switch_desc" to a newly allocated "struct usb_role_switch" in other words: you could make it a stack-variable personally I have no preference so I leave the decision up to you Regards Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic