From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 167FBC48BE5 for ; Tue, 22 Jun 2021 12:05:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED1A861164 for ; Tue, 22 Jun 2021 12:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230273AbhFVMHP (ORCPT ); Tue, 22 Jun 2021 08:07:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbhFVMHO (ORCPT ); Tue, 22 Jun 2021 08:07:14 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FFB4C061574; Tue, 22 Jun 2021 05:04:58 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id t40so23475185oiw.8; Tue, 22 Jun 2021 05:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UXu33zooM1Crc13Vebp8C5tdePhjb755cOhdTYx1RhI=; b=IBxYEyz8qFrpyXjdmOhua9qpGyNdwX02NaojZVpftJeAz4cyuDCEAd0+qADxitTYR9 7LRSirAlbT/vLaBcd+EYJxNpTrceIy3pY9v4vL2s6kVGve2mWavF/S9gdoUEARKwK86J MRxtY7QJRKDwFpOVd1o8eFa7zoGV0XWD+kEyUY9F4Fya8NeamnK6jjoUDTk28fAgr6hp xtzu8p/laLWYbN9YzUjaZnlg2BzkAEBUrlpuilkihQrotRNoB1aKYIzadRsiBb/qRf5P 5eigpS//hdZK/xPV9k2CHEAQdna490dEykBfiNm2Sx4X4XKQnb3AfoUMJXKOf+KtYuYs /9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UXu33zooM1Crc13Vebp8C5tdePhjb755cOhdTYx1RhI=; b=k1ECK+fAcnROWxBvZQDQP/K9jTBoZmDvzERi+biK6ZlPeqvCd1b+jXbMbIM67oGxIw MODB2zi4V4IYd+8krZCYRho86jdoynSkr/5mYLS3pxjeG3BQZEl9fUh62LS6+s8x55sO iJnz7Uqq6MHOjdtKM/jTQXV+SQvbrnqmtha9YS47WayhTY+xfXrRbEagtw7UuPmXjJuw 0D0OSEAxBHpEV07Bpr9pcdivOG5ZvI+pFxPHbRLqd+BPxRkm4mmpPPNyVTV1jMsj0sDm bkGAUcOLJ3sEeGmXQ7IaF0y3EEB7A3hscArzl3/Z9ZzQxK2xLlOJ50Vcv0O+3leCN6Yx 6tqw== X-Gm-Message-State: AOAM533dFAztzj6MnI0PpH0SeaLyRSoHa0Cqx1QppMw6vZhwC8bFSwhz DPuxgM7TXchH+DhHRZFCGkgEuuek9gq2EVGQ39g= X-Google-Smtp-Source: ABdhPJz9eTOAYS/A5LDYycSvFHQxs/rBQ2qipYP0MTUC17z8ZF/zeA2uqIWquOAnXIrUs1z3RzFaGSzZm9SwmWCsolo= X-Received: by 2002:aca:ac02:: with SMTP id v2mr2855756oie.154.1624363497566; Tue, 22 Jun 2021 05:04:57 -0700 (PDT) MIME-Version: 1.0 References: <20210621141217.GE1096940@ziepe.ca> <20210621175511.GI1096940@ziepe.ca> <20210621232912.GK1096940@ziepe.ca> <20210622120142.GL1096940@ziepe.ca> In-Reply-To: <20210622120142.GL1096940@ziepe.ca> From: Oded Gabbay Date: Tue, 22 Jun 2021 15:04:30 +0300 Message-ID: Subject: Re: [Linaro-mm-sig] [PATCH v3 1/2] habanalabs: define uAPI to export FD for DMA-BUF To: Jason Gunthorpe Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= , Gal Pressman , sleybo@amazon.com, linux-rdma , Oded Gabbay , Christoph Hellwig , Linux Kernel Mailing List , dri-devel , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Doug Ledford , Tomer Tayar , amd-gfx list , Greg KH , Alex Deucher , Leon Romanovsky , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jun 22, 2021 at 3:01 PM Jason Gunthorpe wrote: > > On Tue, Jun 22, 2021 at 11:42:27AM +0300, Oded Gabbay wrote: > > On Tue, Jun 22, 2021 at 9:37 AM Christian K=C3=B6nig > > wrote: > > > > > > Am 22.06.21 um 01:29 schrieb Jason Gunthorpe: > > > > On Mon, Jun 21, 2021 at 10:24:16PM +0300, Oded Gabbay wrote: > > > > > > > >> Another thing I want to emphasize is that we are doing p2p only > > > >> through the export/import of the FD. We do *not* allow the user to > > > >> mmap the dma-buf as we do not support direct IO. So there is no ac= cess > > > >> to these pages through the userspace. > > > > Arguably mmaping the memory is a better choice, and is the directio= n > > > > that Logan's series goes in. Here the use of DMABUF was specificall= y > > > > designed to allow hitless revokation of the memory, which this isn'= t > > > > even using. > > > > > > The major problem with this approach is that DMA-buf is also used for > > > memory which isn't CPU accessible. > > That isn't an issue here because the memory is only intended to be > used with P2P transfers so it must be CPU accessible. > > > > That was one of the reasons we didn't even considered using the mappi= ng > > > memory approach for GPUs. > > Well, now we have DEVICE_PRIVATE memory that can meet this need > too.. Just nobody has wired it up to hmm_range_fault() > > > > > So you are taking the hit of very limited hardware support and redu= ced > > > > performance just to squeeze into DMABUF.. > > > > Thanks Jason for the clarification, but I honestly prefer to use > > DMA-BUF at the moment. > > It gives us just what we need (even more than what we need as you > > pointed out), it is *already* integrated and tested in the RDMA > > subsystem, and I'm feeling comfortable using it as I'm somewhat > > familiar with it from my AMD days. > > You still have the issue that this patch is doing all of this P2P > stuff wrong - following the already NAK'd AMD approach. Could you please point me exactly to the lines of code that are wrong in your opinion ? I find it hard to understand from your statement what exactly you think that we are doing wrong. The implementation is found in the second patch in this patch-set. Thanks, Oded > > > I'll go and read Logan's patch-set to see if that will work for us in > > the future. Please remember, as Daniel said, we don't have struct page > > backing our device memory, so if that is a requirement to connect to > > Logan's work, then I don't think we will want to do it at this point. > > It is trivial to get the struct page for a PCI BAR. > > Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E4DCC49EA6 for ; Tue, 22 Jun 2021 12:05:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FC24613B4 for ; Tue, 22 Jun 2021 12:05:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FC24613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9014B6E104; Tue, 22 Jun 2021 12:04:59 +0000 (UTC) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50E866E104; Tue, 22 Jun 2021 12:04:58 +0000 (UTC) Received: by mail-oi1-x234.google.com with SMTP id s17so653477oij.0; Tue, 22 Jun 2021 05:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UXu33zooM1Crc13Vebp8C5tdePhjb755cOhdTYx1RhI=; b=IBxYEyz8qFrpyXjdmOhua9qpGyNdwX02NaojZVpftJeAz4cyuDCEAd0+qADxitTYR9 7LRSirAlbT/vLaBcd+EYJxNpTrceIy3pY9v4vL2s6kVGve2mWavF/S9gdoUEARKwK86J MRxtY7QJRKDwFpOVd1o8eFa7zoGV0XWD+kEyUY9F4Fya8NeamnK6jjoUDTk28fAgr6hp xtzu8p/laLWYbN9YzUjaZnlg2BzkAEBUrlpuilkihQrotRNoB1aKYIzadRsiBb/qRf5P 5eigpS//hdZK/xPV9k2CHEAQdna490dEykBfiNm2Sx4X4XKQnb3AfoUMJXKOf+KtYuYs /9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UXu33zooM1Crc13Vebp8C5tdePhjb755cOhdTYx1RhI=; b=THpQIk1mCnxpKcsDANz9Vqn4PebibnggTp2D6qn1yorFJZeCyfTHOoARYGYZHxq9jb L925OVhEF8v3TSNrS6Fie/dh4D7Ex0gLV4nAxPyrUuhGaCwi0pgNyaLVfm9T9jKRW3u7 ilU1wTdsvxEIDm3nKybeMJThi6Q4/+gEkVF7wdZi7UukWePykEn8GdYhO9sbNrVlTbsO Ivi9ec24UVrReqhhz5+iw/Rjo9JRLr890vQzUGuRzZw8TDk7F7EW+6cxjSfOTv6+THR9 XkHAcfynVDS2EsAivdGHjNrjZEi/5AXYqzBO3oabElaJR02Mjtk0ERulIW8m/TX9nwyq vd6Q== X-Gm-Message-State: AOAM531EFIEXKmSjRnlYP9WEKIArA/Os48H0QhtqrheSWlb10qz5jcpj v6wY9Nn0bM1LoQFim+3E1Zi0zHEGrAC0Mraf2x4= X-Google-Smtp-Source: ABdhPJz9eTOAYS/A5LDYycSvFHQxs/rBQ2qipYP0MTUC17z8ZF/zeA2uqIWquOAnXIrUs1z3RzFaGSzZm9SwmWCsolo= X-Received: by 2002:aca:ac02:: with SMTP id v2mr2855756oie.154.1624363497566; Tue, 22 Jun 2021 05:04:57 -0700 (PDT) MIME-Version: 1.0 References: <20210621141217.GE1096940@ziepe.ca> <20210621175511.GI1096940@ziepe.ca> <20210621232912.GK1096940@ziepe.ca> <20210622120142.GL1096940@ziepe.ca> In-Reply-To: <20210622120142.GL1096940@ziepe.ca> From: Oded Gabbay Date: Tue, 22 Jun 2021 15:04:30 +0300 Message-ID: Subject: Re: [Linaro-mm-sig] [PATCH v3 1/2] habanalabs: define uAPI to export FD for DMA-BUF To: Jason Gunthorpe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-rdma , =?UTF-8?Q?Christian_K=C3=B6nig?= , sleybo@amazon.com, Gal Pressman , dri-devel , Christoph Hellwig , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Doug Ledford , Tomer Tayar , amd-gfx list , Greg KH , Alex Deucher , Leon Romanovsky , Oded Gabbay , Linux Kernel Mailing List , "open list:DMA BUFFER SHARING FRAMEWORK" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 22, 2021 at 3:01 PM Jason Gunthorpe wrote: > > On Tue, Jun 22, 2021 at 11:42:27AM +0300, Oded Gabbay wrote: > > On Tue, Jun 22, 2021 at 9:37 AM Christian K=C3=B6nig > > wrote: > > > > > > Am 22.06.21 um 01:29 schrieb Jason Gunthorpe: > > > > On Mon, Jun 21, 2021 at 10:24:16PM +0300, Oded Gabbay wrote: > > > > > > > >> Another thing I want to emphasize is that we are doing p2p only > > > >> through the export/import of the FD. We do *not* allow the user to > > > >> mmap the dma-buf as we do not support direct IO. So there is no ac= cess > > > >> to these pages through the userspace. > > > > Arguably mmaping the memory is a better choice, and is the directio= n > > > > that Logan's series goes in. Here the use of DMABUF was specificall= y > > > > designed to allow hitless revokation of the memory, which this isn'= t > > > > even using. > > > > > > The major problem with this approach is that DMA-buf is also used for > > > memory which isn't CPU accessible. > > That isn't an issue here because the memory is only intended to be > used with P2P transfers so it must be CPU accessible. > > > > That was one of the reasons we didn't even considered using the mappi= ng > > > memory approach for GPUs. > > Well, now we have DEVICE_PRIVATE memory that can meet this need > too.. Just nobody has wired it up to hmm_range_fault() > > > > > So you are taking the hit of very limited hardware support and redu= ced > > > > performance just to squeeze into DMABUF.. > > > > Thanks Jason for the clarification, but I honestly prefer to use > > DMA-BUF at the moment. > > It gives us just what we need (even more than what we need as you > > pointed out), it is *already* integrated and tested in the RDMA > > subsystem, and I'm feeling comfortable using it as I'm somewhat > > familiar with it from my AMD days. > > You still have the issue that this patch is doing all of this P2P > stuff wrong - following the already NAK'd AMD approach. Could you please point me exactly to the lines of code that are wrong in your opinion ? I find it hard to understand from your statement what exactly you think that we are doing wrong. The implementation is found in the second patch in this patch-set. Thanks, Oded > > > I'll go and read Logan's patch-set to see if that will work for us in > > the future. Please remember, as Daniel said, we don't have struct page > > backing our device memory, so if that is a requirement to connect to > > Logan's work, then I don't think we will want to do it at this point. > > It is trivial to get the struct page for a PCI BAR. > > Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D211C49EA5 for ; Tue, 22 Jun 2021 12:05:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2883961164 for ; Tue, 22 Jun 2021 12:05:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2883961164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B9EA16E112; Tue, 22 Jun 2021 12:04:59 +0000 (UTC) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50E866E104; Tue, 22 Jun 2021 12:04:58 +0000 (UTC) Received: by mail-oi1-x234.google.com with SMTP id s17so653477oij.0; Tue, 22 Jun 2021 05:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UXu33zooM1Crc13Vebp8C5tdePhjb755cOhdTYx1RhI=; b=IBxYEyz8qFrpyXjdmOhua9qpGyNdwX02NaojZVpftJeAz4cyuDCEAd0+qADxitTYR9 7LRSirAlbT/vLaBcd+EYJxNpTrceIy3pY9v4vL2s6kVGve2mWavF/S9gdoUEARKwK86J MRxtY7QJRKDwFpOVd1o8eFa7zoGV0XWD+kEyUY9F4Fya8NeamnK6jjoUDTk28fAgr6hp xtzu8p/laLWYbN9YzUjaZnlg2BzkAEBUrlpuilkihQrotRNoB1aKYIzadRsiBb/qRf5P 5eigpS//hdZK/xPV9k2CHEAQdna490dEykBfiNm2Sx4X4XKQnb3AfoUMJXKOf+KtYuYs /9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UXu33zooM1Crc13Vebp8C5tdePhjb755cOhdTYx1RhI=; b=THpQIk1mCnxpKcsDANz9Vqn4PebibnggTp2D6qn1yorFJZeCyfTHOoARYGYZHxq9jb L925OVhEF8v3TSNrS6Fie/dh4D7Ex0gLV4nAxPyrUuhGaCwi0pgNyaLVfm9T9jKRW3u7 ilU1wTdsvxEIDm3nKybeMJThi6Q4/+gEkVF7wdZi7UukWePykEn8GdYhO9sbNrVlTbsO Ivi9ec24UVrReqhhz5+iw/Rjo9JRLr890vQzUGuRzZw8TDk7F7EW+6cxjSfOTv6+THR9 XkHAcfynVDS2EsAivdGHjNrjZEi/5AXYqzBO3oabElaJR02Mjtk0ERulIW8m/TX9nwyq vd6Q== X-Gm-Message-State: AOAM531EFIEXKmSjRnlYP9WEKIArA/Os48H0QhtqrheSWlb10qz5jcpj v6wY9Nn0bM1LoQFim+3E1Zi0zHEGrAC0Mraf2x4= X-Google-Smtp-Source: ABdhPJz9eTOAYS/A5LDYycSvFHQxs/rBQ2qipYP0MTUC17z8ZF/zeA2uqIWquOAnXIrUs1z3RzFaGSzZm9SwmWCsolo= X-Received: by 2002:aca:ac02:: with SMTP id v2mr2855756oie.154.1624363497566; Tue, 22 Jun 2021 05:04:57 -0700 (PDT) MIME-Version: 1.0 References: <20210621141217.GE1096940@ziepe.ca> <20210621175511.GI1096940@ziepe.ca> <20210621232912.GK1096940@ziepe.ca> <20210622120142.GL1096940@ziepe.ca> In-Reply-To: <20210622120142.GL1096940@ziepe.ca> From: Oded Gabbay Date: Tue, 22 Jun 2021 15:04:30 +0300 Message-ID: Subject: Re: [Linaro-mm-sig] [PATCH v3 1/2] habanalabs: define uAPI to export FD for DMA-BUF To: Jason Gunthorpe X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-rdma , =?UTF-8?Q?Christian_K=C3=B6nig?= , sleybo@amazon.com, Gal Pressman , dri-devel , Christoph Hellwig , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Doug Ledford , Tomer Tayar , amd-gfx list , Greg KH , Alex Deucher , Leon Romanovsky , Oded Gabbay , Linux Kernel Mailing List , "open list:DMA BUFFER SHARING FRAMEWORK" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gVHVlLCBKdW4gMjIsIDIwMjEgYXQgMzowMSBQTSBKYXNvbiBHdW50aG9ycGUgPGpnZ0B6aWVw ZS5jYT4gd3JvdGU6Cj4KPiBPbiBUdWUsIEp1biAyMiwgMjAyMSBhdCAxMTo0MjoyN0FNICswMzAw LCBPZGVkIEdhYmJheSB3cm90ZToKPiA+IE9uIFR1ZSwgSnVuIDIyLCAyMDIxIGF0IDk6MzcgQU0g Q2hyaXN0aWFuIEvDtm5pZwo+ID4gPGNrb2VuaWcubGVpY2h0enVtZXJrZW5AZ21haWwuY29tPiB3 cm90ZToKPiA+ID4KPiA+ID4gQW0gMjIuMDYuMjEgdW0gMDE6Mjkgc2NocmllYiBKYXNvbiBHdW50 aG9ycGU6Cj4gPiA+ID4gT24gTW9uLCBKdW4gMjEsIDIwMjEgYXQgMTA6MjQ6MTZQTSArMDMwMCwg T2RlZCBHYWJiYXkgd3JvdGU6Cj4gPiA+ID4KPiA+ID4gPj4gQW5vdGhlciB0aGluZyBJIHdhbnQg dG8gZW1waGFzaXplIGlzIHRoYXQgd2UgYXJlIGRvaW5nIHAycCBvbmx5Cj4gPiA+ID4+IHRocm91 Z2ggdGhlIGV4cG9ydC9pbXBvcnQgb2YgdGhlIEZELiBXZSBkbyAqbm90KiBhbGxvdyB0aGUgdXNl ciB0bwo+ID4gPiA+PiBtbWFwIHRoZSBkbWEtYnVmIGFzIHdlIGRvIG5vdCBzdXBwb3J0IGRpcmVj dCBJTy4gU28gdGhlcmUgaXMgbm8gYWNjZXNzCj4gPiA+ID4+IHRvIHRoZXNlIHBhZ2VzIHRocm91 Z2ggdGhlIHVzZXJzcGFjZS4KPiA+ID4gPiBBcmd1YWJseSBtbWFwaW5nIHRoZSBtZW1vcnkgaXMg YSBiZXR0ZXIgY2hvaWNlLCBhbmQgaXMgdGhlIGRpcmVjdGlvbgo+ID4gPiA+IHRoYXQgTG9nYW4n cyBzZXJpZXMgZ29lcyBpbi4gSGVyZSB0aGUgdXNlIG9mIERNQUJVRiB3YXMgc3BlY2lmaWNhbGx5 Cj4gPiA+ID4gZGVzaWduZWQgdG8gYWxsb3cgaGl0bGVzcyByZXZva2F0aW9uIG9mIHRoZSBtZW1v cnksIHdoaWNoIHRoaXMgaXNuJ3QKPiA+ID4gPiBldmVuIHVzaW5nLgo+ID4gPgo+ID4gPiBUaGUg bWFqb3IgcHJvYmxlbSB3aXRoIHRoaXMgYXBwcm9hY2ggaXMgdGhhdCBETUEtYnVmIGlzIGFsc28g dXNlZCBmb3IKPiA+ID4gbWVtb3J5IHdoaWNoIGlzbid0IENQVSBhY2Nlc3NpYmxlLgo+Cj4gVGhh dCBpc24ndCBhbiBpc3N1ZSBoZXJlIGJlY2F1c2UgdGhlIG1lbW9yeSBpcyBvbmx5IGludGVuZGVk IHRvIGJlCj4gdXNlZCB3aXRoIFAyUCB0cmFuc2ZlcnMgc28gaXQgbXVzdCBiZSBDUFUgYWNjZXNz aWJsZS4KPgo+ID4gPiBUaGF0IHdhcyBvbmUgb2YgdGhlIHJlYXNvbnMgd2UgZGlkbid0IGV2ZW4g Y29uc2lkZXJlZCB1c2luZyB0aGUgbWFwcGluZwo+ID4gPiBtZW1vcnkgYXBwcm9hY2ggZm9yIEdQ VXMuCj4KPiBXZWxsLCBub3cgd2UgaGF2ZSBERVZJQ0VfUFJJVkFURSBtZW1vcnkgdGhhdCBjYW4g bWVldCB0aGlzIG5lZWQKPiB0b28uLiBKdXN0IG5vYm9keSBoYXMgd2lyZWQgaXQgdXAgdG8gaG1t X3JhbmdlX2ZhdWx0KCkKPgo+ID4gPiA+IFNvIHlvdSBhcmUgdGFraW5nIHRoZSBoaXQgb2YgdmVy eSBsaW1pdGVkIGhhcmR3YXJlIHN1cHBvcnQgYW5kIHJlZHVjZWQKPiA+ID4gPiBwZXJmb3JtYW5j ZSBqdXN0IHRvIHNxdWVlemUgaW50byBETUFCVUYuLgo+ID4KPiA+IFRoYW5rcyBKYXNvbiBmb3Ig dGhlIGNsYXJpZmljYXRpb24sIGJ1dCBJIGhvbmVzdGx5IHByZWZlciB0byB1c2UKPiA+IERNQS1C VUYgYXQgdGhlIG1vbWVudC4KPiA+IEl0IGdpdmVzIHVzIGp1c3Qgd2hhdCB3ZSBuZWVkIChldmVu IG1vcmUgdGhhbiB3aGF0IHdlIG5lZWQgYXMgeW91Cj4gPiBwb2ludGVkIG91dCksIGl0IGlzICph bHJlYWR5KiBpbnRlZ3JhdGVkIGFuZCB0ZXN0ZWQgaW4gdGhlIFJETUEKPiA+IHN1YnN5c3RlbSwg YW5kIEknbSBmZWVsaW5nIGNvbWZvcnRhYmxlIHVzaW5nIGl0IGFzIEknbSBzb21ld2hhdAo+ID4g ZmFtaWxpYXIgd2l0aCBpdCBmcm9tIG15IEFNRCBkYXlzLgo+Cj4gWW91IHN0aWxsIGhhdmUgdGhl IGlzc3VlIHRoYXQgdGhpcyBwYXRjaCBpcyBkb2luZyBhbGwgb2YgdGhpcyBQMlAKPiBzdHVmZiB3 cm9uZyAtIGZvbGxvd2luZyB0aGUgYWxyZWFkeSBOQUsnZCBBTUQgYXBwcm9hY2guCgpDb3VsZCB5 b3UgcGxlYXNlIHBvaW50IG1lIGV4YWN0bHkgdG8gdGhlIGxpbmVzIG9mIGNvZGUgdGhhdCBhcmUg d3JvbmcKaW4geW91ciBvcGluaW9uID8KSSBmaW5kIGl0IGhhcmQgdG8gdW5kZXJzdGFuZCBmcm9t IHlvdXIgc3RhdGVtZW50IHdoYXQgZXhhY3RseSB5b3UKdGhpbmsgdGhhdCB3ZSBhcmUgZG9pbmcg d3JvbmcuClRoZSBpbXBsZW1lbnRhdGlvbiBpcyBmb3VuZCBpbiB0aGUgc2Vjb25kIHBhdGNoIGlu IHRoaXMgcGF0Y2gtc2V0LgoKVGhhbmtzLApPZGVkCj4KPiA+IEknbGwgZ28gYW5kIHJlYWQgTG9n YW4ncyBwYXRjaC1zZXQgdG8gc2VlIGlmIHRoYXQgd2lsbCB3b3JrIGZvciB1cyBpbgo+ID4gdGhl IGZ1dHVyZS4gUGxlYXNlIHJlbWVtYmVyLCBhcyBEYW5pZWwgc2FpZCwgd2UgZG9uJ3QgaGF2ZSBz dHJ1Y3QgcGFnZQo+ID4gYmFja2luZyBvdXIgZGV2aWNlIG1lbW9yeSwgc28gaWYgdGhhdCBpcyBh IHJlcXVpcmVtZW50IHRvIGNvbm5lY3QgdG8KPiA+IExvZ2FuJ3Mgd29yaywgdGhlbiBJIGRvbid0 IHRoaW5rIHdlIHdpbGwgd2FudCB0byBkbyBpdCBhdCB0aGlzIHBvaW50Lgo+Cj4gSXQgaXMgdHJp dmlhbCB0byBnZXQgdGhlIHN0cnVjdCBwYWdlIGZvciBhIFBDSSBCQVIuCj4KPiBKYXNvbgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxp bmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK