From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33869)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bGS11-0006P9-Eh
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:23:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bGS0z-0005zY-Ic
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:23:26 -0400
Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:34960)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1bGS0z-0005zR-1U
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:23:25 -0400
Received: by mail-vk0-x22f.google.com with SMTP id j2so152451405vkg.2
	for <qemu-devel@nongnu.org>; Fri, 24 Jun 2016 07:23:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1466777957-5126-3-git-send-email-armbru@redhat.com>
References: <1466777957-5126-1-git-send-email-armbru@redhat.com>
	<1466777957-5126-3-git-send-email-armbru@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Fri, 24 Jun 2016 15:23:05 +0100
Message-ID: <CAFEAcA-S+VBrmjoZx0KX2ngGVjiY_a+eFiM0O4tBEL7khVjxLg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target
 check-source
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>

On 24 June 2016 at 15:19, Markus Armbruster <armbru@redhat.com> wrote:
> For now, this tests just a bit of header sanity: for each header
> "FOO.h", test whether
>
>         #include "qemu/osdep.h"
>         #include "FOO.h"
>         #include "FOO.h"
>
> compiles.  A large number of headers don't pass this test, by design
> or by accident.  These are all excluded for now.  Excluded headers
> contain a comment
>
>     /* FIXME Does not pass make check-headers, yet! */
>
> Many headers fail the test only with CONFIG_WIN32.  These contain a
> comment
>
>     /* FIXME Does not pass make check-headers with CONFIG_WIN32, yet! */
>
> Add make target check-excluded-headers to help with examining how they
> fail.
>
> These tests work only in a git tree, with git installed.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

>  disas/libvixl/vixl/a64/assembler-a64.h    |  2 ++
>  disas/libvixl/vixl/a64/constants-a64.h    |  2 ++
>  disas/libvixl/vixl/a64/cpu-a64.h          |  2 ++
>  disas/libvixl/vixl/a64/decoder-a64.h      |  2 ++
>  disas/libvixl/vixl/a64/disasm-a64.h       |  2 ++
>  disas/libvixl/vixl/a64/instructions-a64.h |  2 ++
>  disas/libvixl/vixl/code-buffer.h          |  2 ++
>  disas/libvixl/vixl/compiler-intrinsics.h  |  2 ++
>  disas/libvixl/vixl/globals.h              |  2 ++
>  disas/libvixl/vixl/invalset.h             |  2 ++
>  disas/libvixl/vixl/platform.h             |  2 ++
>  disas/libvixl/vixl/utils.h                |  2 ++

This is third-party code. We're not going to change it, so
we should avoid scanning it rather than adding tags which
will get lost next time we do an update to a new upstream
version...

thanks
-- PMM