From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3E0C2B9F8 for ; Tue, 25 May 2021 17:28:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F1A7610CE for ; Tue, 25 May 2021 17:28:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F1A7610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llarN-0004t9-N3 for qemu-devel@archiver.kernel.org; Tue, 25 May 2021 13:28:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llaf4-0002MX-Uk for qemu-devel@nongnu.org; Tue, 25 May 2021 13:16:12 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:36748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llaf1-0008Lc-60 for qemu-devel@nongnu.org; Tue, 25 May 2021 13:16:10 -0400 Received: by mail-ed1-x536.google.com with SMTP id df21so37180228edb.3 for ; Tue, 25 May 2021 10:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AiIiEAPDdf3Aw9ACm+daEGl74CzDEO+Rvmp7WJhXGBQ=; b=syWWEf++gSeLR5OzgRobDyVbefACXZsMMS0ExwZiXTleDA0TctIMF0rd+mUtWEkiQP 5mfsqhAhxBzEwlV3a+d4jSnbnJXVRVdKXnqRDr7RW4IswGYeaq3SK3YAw03CXxm/sBaS xsoB8858yKNayoCOmhpETn+AzZLJPIUxV4XlYv65KsXGIJfdxTcpCreTHszDN7T20MxQ snA3TchQq14R83iABsa5+e6gYZe86nK0xZIljSIrtQTcFOTx7T0tAFB6FyjpmI4CVOVG Pvy2Be/lcPRkhoDzO4llqwgwjUGg8viHmx5L+6Te6XmEEqXG4O/TWYKY6vzt571X4FVC B5mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AiIiEAPDdf3Aw9ACm+daEGl74CzDEO+Rvmp7WJhXGBQ=; b=eFGr8XSFAa3IbJBgNxEOBhXgxXWx9TiEPr++Wd4TKliAi2sPAiGm2LTkXWMheTk54x iy6WMbKJDholM+6YNNN8snHWBoMmS622D2obzJfrfUXOS1RXmIWXTjBlhoGsHHyt+MfF MpPD86aVZy5YwfdLOJRUQVEB8M4A1bNCuZiCNsiEkiNwASoNIYrRFOvkYYHscL2FXqS4 AaGhrt9vKDfHaLV3IjK2yXyc877kFZyK7en4Nlx1fRPiuXA6VhQmiMYWaKNQBnAr+BlS siNKPUqd/lDQO8rgBXpOfPFOA8AK6fA1QefzglKBDJJ98qLobLyfduzjXSS9+JkYqA8a X5HA== X-Gm-Message-State: AOAM532fbKQB99OxpAMFnByqCPJXtKBxe5/wMnf+2c7vbptbQpN4eIKH ouLBep5Dx8DwR83sb9A6g+qENtPAmrRg/YhHHcwkZQ== X-Google-Smtp-Source: ABdhPJxSFYTKUGKrHwj2zbScxJQGbw+8rsgmX+pwc1lngH/t+B2jmrGRoYsazX9OUC8sAeC3iSsmrmYEwAA3lvXsCg8= X-Received: by 2002:aa7:dc12:: with SMTP id b18mr32668792edu.52.1621962964967; Tue, 25 May 2021 10:16:04 -0700 (PDT) MIME-Version: 1.0 References: <20210525025823.3208218-1-swethajoshi139@gmail.com> <331a819e-1745-4d4b-cc4a-82521a58186a@linaro.org> In-Reply-To: From: Peter Maydell Date: Tue, 25 May 2021 18:15:40 +0100 Message-ID: Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled To: Swetha Joshi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Dongjiu Geng , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 25 May 2021 at 17:28, Swetha Joshi wrote= : > > Hey Peter, Phil, > > Yeah like Peter mentioned, when KVM is enabled and we don't want VIRT ena= bled, there are a couple of routines that are being called from virt.h and = ghes.h, which is resulting in errors. I came up with this simple fix but if= you think there is a better solution to it I'll let you/ other developers = who own it decide and fix it because I don't have much experience or visibi= lity into what happens internally, my knowledge is restricted to just using= the configs. Well, QEMU builds fine for me as-is, because the default config always enables the virt board. Do you have repro instructions for reproducing the build failure ? thanks -- PMM