From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBAD6C07E96 for ; Thu, 8 Jul 2021 12:38:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53FFE6139A for ; Thu, 8 Jul 2021 12:38:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53FFE6139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1THz-0006xU-8v for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 08:37:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1TF7-0003CY-1m for qemu-devel@nongnu.org; Thu, 08 Jul 2021 08:35:01 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:37617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1TF5-0001jd-DK for qemu-devel@nongnu.org; Thu, 08 Jul 2021 08:35:00 -0400 Received: by mail-ed1-x532.google.com with SMTP id cy23so3293742edb.4 for ; Thu, 08 Jul 2021 05:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UFL/IFla6NGF4FQJR0AC3grTjWj/Kw3/jm2dXhCUEr0=; b=QcNJDoYCXA0NBf7HLI6SMJrQ38dYKAIgbtxx6BlGpT1wdwba0bNqUBS3EFCKrLyuYn qErMEHqqT8fPi3dTZi6myo5ymr8hT3vqE9XMiqID6AyWMsFGzHt/MxBw+cAjqCqySYNA CHMhZzRorcvEJqmf+BErm2bKyZk/9FHIjl3DtQwZSlj85T0ZyI/+hBiO5EN7LXn3KqGG K4MbM7If76tB7q7+sQPxS86gJHSwjNtQSaCE59IXhloFFEM15K0PRHCBL7ZGrNBCAlfK BystqkxCp62qaXyHoQe4wENzDYfwBKd8HylJ3N7cC2mUf2M6uPcbJosY7aVlLkT/L8ji I4iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UFL/IFla6NGF4FQJR0AC3grTjWj/Kw3/jm2dXhCUEr0=; b=pP1SdM4xY5svScqlI0EU0qQXkOOwrp50TOXR+sllIsqaKxR9Df3OQ/ENDsj1tE6Ynl fGI9bed49/K8sbtCLs10cM240/+0wBI3pF8VG0R5f2GwHjmC6yJr3luC0Y6lRF0QEJiq u8/RRrYkTrrfIVZIkCRm3T776eAl/GsQkra4Y0uD7BBcf3lKYqvh56thUuL2x/FezrFe 2cASlqXr7KoB8ihERUmlV5cjQhWjlQl33qVGD63EYtWC97+A37o4iDXWQWuFne3vi+gh QT5ELB4OfuSvhRQnuYwOfhsAfPIN6u7vZmv1ZtHxyc/jViQocqyGIPzLtfrd/EgSnzzP eZDA== X-Gm-Message-State: AOAM530IJmZNu8+BrKlF3WHGImGCGI5wcnph0cm3K3Ur0qrASxlwaThQ kbWVtUhh68dod8JhwMmGkd1KjZN4DF/zOwXU5TkFJw== X-Google-Smtp-Source: ABdhPJzy/gzx6EyX0pWOMMZfbSTgnXs8v/TzSDIVKgpYjBlq9dAiqGQoly3TiIFtpXwZYIr41SGrywtVKtJ+ElWSTK8= X-Received: by 2002:a05:6402:1911:: with SMTP id e17mr37804389edz.36.1625747697109; Thu, 08 Jul 2021 05:34:57 -0700 (PDT) MIME-Version: 1.0 References: <20210630183226.3290849-1-richard.henderson@linaro.org> <20210630183226.3290849-3-richard.henderson@linaro.org> In-Reply-To: <20210630183226.3290849-3-richard.henderson@linaro.org> From: Peter Maydell Date: Thu, 8 Jul 2021 13:34:18 +0100 Message-ID: Subject: Re: [PATCH v2 02/28] target/alpha: Remove use_exit_tb To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 30 Jun 2021 at 19:39, Richard Henderson wrote: > > We have not needed to end a TB for I/O since ba3e7926691 > ("icount: clean up cpu_can_io at the entry to the block"). > We do not need to use exit_tb for singlestep, which only > means generate one insn per TB. > > Which leaves only singlestep_enabled, which means raise a > debug trap after every TB, which does not use exit_tb, > which would leave the function mis-named. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell I wonder if we should rename the 'singlestep' global to 'tcg_one_insn_per_tb' or something (and perhaps also provide a new command line flag, with the old one deprecated). It's very misleadingly named... thanks -- PMM