Re: [Qemu-devel] [RFC 2/4] Added flag in ARMCPU to track last execution mode

From: Peter Maydell <peter.maydell@linaro.org>
To: Alvise Rigo <a.rigo@virtualopensystems.com>
Cc: "tech@virtualopensystems.com" <tech@virtualopensystems.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC 2/4] Added flag in ARMCPU to track last execution mode
Date: Tue, 25 Feb 2014 18:19:20 +0000	[thread overview]
Message-ID: <CAFEAcA8ZFST+-tZFaBTZJjns9qaFybXWevOsnjyWvekbDOLaNA@mail.gmail.com> (raw)
In-Reply-To: <1393347170-28502-3-git-send-email-a.rigo@virtualopensystems.com>

On 25 February 2014 16:52, Alvise Rigo <a.rigo@virtualopensystems.com> wrote:
> The value of this flag indicates the execution mode of the CPU prior the
> migration. It is used to handle the KVM <-> TCG migration.
>
> Signed-off-by: Alvise Rigo <a.rigo@virtualopensystems.com>
> ---
>  target-arm/cpu-qom.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h
> index afbd422..6819bfc 100644
> --- a/target-arm/cpu-qom.h
> +++ b/target-arm/cpu-qom.h
> @@ -102,6 +102,9 @@ typedef struct ARMCPU {
>       */
>      uint32_t kvm_target;
>
> +    /* true if this cpu is using KVM. Read and set in cpu_pre/post_load */
> +    bool running_kvm;

This is definitely wrong. We should not care whether either
end of the migration connection is using KVM.

thanks
-- PMM