From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DF1C47088 for ; Wed, 26 May 2021 18:53:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48DED613BE for ; Wed, 26 May 2021 18:53:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48DED613BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llyeT-0007bg-8u for qemu-devel@archiver.kernel.org; Wed, 26 May 2021 14:53:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lly81-0000Uj-7i for qemu-devel@nongnu.org; Wed, 26 May 2021 14:19:38 -0400 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:45033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lly7z-0001Cz-EZ for qemu-devel@nongnu.org; Wed, 26 May 2021 14:19:36 -0400 Received: by mail-ed1-x530.google.com with SMTP id t15so2635302edr.11 for ; Wed, 26 May 2021 11:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QwV4GhApoNVUqgvh0vCDgT0m8jOlvKW+/rHy8uRm8vQ=; b=rCr2EYHANYA7GE2lIhsjKOS6PiNvAFatZsl4Lcka/uqc8v16gcJ8+8CTW21We8PQ8P r7cpVis+MhnS1o1zFAh9W3zChlRUKiaT+THZ7jwl+CXOFmtLkhehs6GCZ0q/xhuXWU6c hhmvGW0JnV/W6qMRJLCTD57+34CcOx+8my+nSIKSxvygB7wppsQNW81kiIVDEidaxICb uVIC2MXfocvTekjacUk3EJ8AKxWMjQESOm/1xbS4r4o3kyKOIiERsX+VXPTe86VGF0cS KioeTy63RhSMYbmWID8CNEq87qIFnSGUbG0Ysgk3KYboELsVmLJ6vjgBkFG9+DQ0CsqO +bug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QwV4GhApoNVUqgvh0vCDgT0m8jOlvKW+/rHy8uRm8vQ=; b=cBZJJshasCkV++OjGH11vdeDWcbLe2drPHBu5NZ+egZlsmSE+F8TGRlbDObRf3gsOI qrOEB+pZm8w5smU/nvnLX2CSVIj4ZNzx/1cIXg3FIksD/fHpWrcYCsq0ue5kN5yR1nfb 4sCI1vj4D0dGe4R64yoTpzTl81xsKC8liczMVZ9mvyh9w23Wv/60b05urUPUc4H7QJt3 /6uM/5jmvj+sOPj7SbXietPs4gGEhKq2+XlaGkTPJP+0TtMafLt/8JxAiPhb/4v7Ptk/ GcDPyY2pJNOo8XHGERtUAwx47ay1tg6GYFjkL1jd8nAwoS3jPxwj6A+qdIqjSVEpiNaZ nbHA== X-Gm-Message-State: AOAM532xhm+RKhlVgMhHZ/wjDJ0V4fXohxuD18v4HiE3NM/8t0QLmlOJ C3iF9vZhQ0B2Szty8320pESp4V89dz8nyxiH2QulgQ== X-Google-Smtp-Source: ABdhPJzOsnRoWpyObbHLswJ+MCW06XRZUSCL/GlmsmdHbCvcKVxXmSrgAETjgOY93qdGvfxcSoMEU6rdrhH8wDHuZHA= X-Received: by 2002:a05:6402:190e:: with SMTP id e14mr39437346edz.146.1622053173263; Wed, 26 May 2021 11:19:33 -0700 (PDT) MIME-Version: 1.0 References: <20210525025823.3208218-1-swethajoshi139@gmail.com> <331a819e-1745-4d4b-cc4a-82521a58186a@linaro.org> In-Reply-To: From: Peter Maydell Date: Wed, 26 May 2021 19:19:08 +0100 Message-ID: Subject: Re: [PATCH_V3] Adding ifdefs to call the respective routines only when their configs are enabled To: Swetha Joshi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Dongjiu Geng , Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 26 May 2021 at 18:32, Swetha Joshi wrote= : > > Hello, > > One of the qemu machines we use has KVM enabled, but we don't want the CO= NFIG_ARM_VIRT enabled as it pulls in emulation of a variety of physical har= dware that we don't need. The compilation errors I mentioned are not in the= qemu mainline per say but we see them in one of the qemu derived machines = we use. Sure, but unless you can give me a recipe for reproducing the build failure in mainline I can't really help... thanks -- PMM