Re: [Qemu-devel] [Qemu-arm] [PATCH 5/7] arm: Move condition-failed codepath generation out of if()

From: Peter Maydell <peter.maydell@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Richard Henderson <rth@twiddle.net>,
	"patches@linaro.org" <patches@linaro.org>
Subject: Re: [Qemu-devel] [Qemu-arm] [PATCH 5/7] arm: Move condition-failed codepath generation out of if()
Date: Mon, 10 Apr 2017 17:45:52 +0100	[thread overview]
Message-ID: <CAFEAcA9LAHe9=nnS8tAJLsW-xDXb2oLq8jU6tRTT9vnDe6bnmw@mail.gmail.com> (raw)
In-Reply-To: <6a8d54a6-cf11-38d3-390f-dd4536b2c2b6@amsat.org>

On 10 April 2017 at 14:22, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> I'm custom to think "let's change that and think how to protect the code to
> help the next one who will modify it" and wonder if it isn't safer to
> define:
>
> const bool singlestepping;
>
> singlestepping = cs->singlestep_enabled || dc->ss_active;
>
> Then use:
>
> if unlikely(singlestepping)
>
> At line 11993 and here, what do you think?

I think we could do this with a function (that takes the DisasContext*);
then we can use it in the new gen_bx_excret_final_code() too.

I'll add an extra patch to the set in v2 that does that.

thanks
-- PMM