From: Peter Maydell <peter.maydell@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] disas/libvixl: Suppress gcc 4.6.3 sign-compare warnings
Date: Tue, 12 Jan 2016 19:37:52 +0000 [thread overview]
Message-ID: <CAFEAcA9VXvk-BQzFcMpU=ex5=C4+Y3J2Qm-XRcybJSUhaDOF7w@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA-KL0=EXywZXO_xo5Rjw-Whadyfyrg2njUGWJ1zWVUPYw@mail.gmail.com>
On 12 January 2016 at 17:36, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 12 January 2016 at 16:35, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>>> The VIXL code includes some equality comparisons between signed
>>> and unsigned types. Modern gcc and clang do not complain about
>>> these, but older versions of gcc such as gcc 4.6.3 do. Since
>>> libvixl is an upstream library, the simplest approach is to
>>> suppress the warnings by applying -Wno-sign-compare to the
>>> relevant files.
>>>
>>> (GCC 4.6 is not quite yet irrelevant for us; it is the gcc
>>> shipped with Ubuntu Precise, for example, which is an LTS
>>> release not yet out of its support period.)
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>> I had mistakenly thought these warnings only happened with
>>> the totally ancient mingw gcc, but it turns out they're a
>>> bit more widespread. In particular this is causing our
>>> Travis builds to fail:
>>> https://travis-ci.org/qemu/qemu/jobs/101813358
>>>
>>> If somebody could review this then I'll apply it to master
>>> as a buildfix.
>>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
> Thanks; applied to master.
Unfortunately it doesn't seem to actually fix the travis
build; not sure why...
https://travis-ci.org/qemu/qemu/jobs/101902544
-- PMM
prev parent reply other threads:[~2016-01-12 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 13:10 [Qemu-devel] [PATCH] disas/libvixl: Suppress gcc 4.6.3 sign-compare warnings Peter Maydell
2016-01-12 16:35 ` Alex Bennée
2016-01-12 17:36 ` Peter Maydell
2016-01-12 19:37 ` Peter Maydell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA9VXvk-BQzFcMpU=ex5=C4+Y3J2Qm-XRcybJSUhaDOF7w@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.