From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD4FC2B9F4 for ; Mon, 14 Jun 2021 16:08:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D6D76120E for ; Mon, 14 Jun 2021 16:08:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D6D76120E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsp85-0001gd-H7 for qemu-devel@archiver.kernel.org; Mon, 14 Jun 2021 12:08:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsp6G-0008Lp-DT for qemu-devel@nongnu.org; Mon, 14 Jun 2021 12:06:08 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]:34773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lsp6C-0007VL-8n for qemu-devel@nongnu.org; Mon, 14 Jun 2021 12:06:08 -0400 Received: by mail-ej1-x62a.google.com with SMTP id g8so17567174ejx.1 for ; Mon, 14 Jun 2021 09:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UvJ+jp1yIu+Nxb9vm3TJBC9KuS0gXjvRmQ52pvGBb6w=; b=G15+5i6J0syCnKRKN4lbCvMBS0beEn2i/tsq8yTBNvNY/WH0S9Dbe0Oa6QANv1IgWT CKH1K2hSj8gY0JsoncRX20IWQ6F6qbIN1fLZTqI4cI7s9YcPjMoPcqaFGd4qXLP5T1T5 bFzQMIPj33n3JykttmMg8ky5UNxe1PVXdnyd46PeaQJlN/hZXSg9T3nBVH/AmSDchiOk GXRvxBK05xQ8kUIktaq5FqCTCUW79ujJowf17XywtULGt8/Y4Wmj2AGQm0AQtq6DvU1x 4x/9sOIEsohZJIBS+Ovs10yFksrzYKD5QxEQFWST1C989QITjZCXCucSmVwH3Q7R57Hx 5oeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UvJ+jp1yIu+Nxb9vm3TJBC9KuS0gXjvRmQ52pvGBb6w=; b=WPnaBWrQoxYo9d6KzndUoiL0kP4QWd+x+7VYr7gHW74CsscqVtZzJKzz8OMjPnNs1F AY9lYTUzpkca1e36r3m4qeT+JrZPyUrYwAJK7o8u4hWiPLXVog/fu/bJsAwOcYLkKBV8 e9zH1UOI14RouZIuQYBtodZf/L7a+RRlo2t17oJhhlBbW5U2Rzlvu1Hi9NHYG7NR1Rdr dXN8JUb96LbErpbLvbGds/rVgryC/cd3jIgZq5TjhyDeLPEf20pwkXFsDRULthfCl3Dq l+ViOGCxqEoyq67W+9TS2ejbyVv5E1W1/HBosQd5rSQKXiaTrmSJ9hj17T4Rx5dXLir8 uOsA== X-Gm-Message-State: AOAM531oS5nD+eE/1IeWTq43Q3kdufGqqHtLiforz8rYljDnyOpTsZ7z /YO51Gvfq06jh1/9TY+EdQ4JR4gdPNiEPm2Y7myGdQ== X-Google-Smtp-Source: ABdhPJzBAQglxzvBSxIjPvoIkeunQWvy2rTKjTKGrcDDdKaCY+SB/1o33iceoiVIevH49Ce8+Ca1Dr23hYto3Ci4Du0= X-Received: by 2002:a17:906:b294:: with SMTP id q20mr15683086ejz.382.1623686762733; Mon, 14 Jun 2021 09:06:02 -0700 (PDT) MIME-Version: 1.0 References: <20210608161028.4159582-1-erdnaxe@crans.org> In-Reply-To: <20210608161028.4159582-1-erdnaxe@crans.org> From: Peter Maydell Date: Mon, 14 Jun 2021 17:05:28 +0100 Message-ID: Subject: Re: [PATCH 0/2] STM32VLDISCOVERY Machine Model To: Alexandre Iooss Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=peter.maydell@linaro.org; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:STM32F100" , "open list:All patches CC here" , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 8 Jun 2021 at 17:10, Alexandre Iooss wrote: > > This patch series adds the STM32VLDISCOVERY Machine to QEMU > > Information on the board is available at: > https://www.st.com/en/evaluation-tools/stm32vldiscovery.html > > Alexandre Iooss (2): > stm32f100: Add the stm32f100 SoC > stm32vldiscovery: Add the STM32VLDISCOVERY Machine > > MAINTAINERS | 12 ++ > default-configs/devices/arm-softmmu.mak | 1 + > hw/arm/Kconfig | 10 ++ > hw/arm/meson.build | 2 + > hw/arm/stm32f100_soc.c | 182 ++++++++++++++++++++++++ > hw/arm/stm32vldiscovery.c | 66 +++++++++ > include/hw/arm/stm32f100_soc.h | 58 ++++++++ > 7 files changed, 331 insertions(+) > create mode 100644 hw/arm/stm32f100_soc.c > create mode 100644 hw/arm/stm32vldiscovery.c > create mode 100644 include/hw/arm/stm32f100_soc.h Looks generally OK to me, but cc'ing Alistair who wrote the STM32F405 model in case he wants to have a look at it. thanks -- PMM