From: Peter Maydell <peter.maydell@linaro.org>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/3] hw/char: renesas_sci Add SCI and SCIF support.
Date: Tue, 29 Jun 2021 13:37:08 +0100 [thread overview]
Message-ID: <CAFEAcA_paLV8eeEyAb=-TtxdA=3_Lc8191huZ8riHSHr8kDXKg@mail.gmail.com> (raw)
In-Reply-To: <20210616091244.33049-3-ysato@users.sourceforge.jp>
On Wed, 16 Jun 2021 at 10:20, Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
>
> This peripheral using SH7750.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> include/hw/char/renesas_sci.h | 43 ++-
> hw/char/renesas_sci.c | 489 ++++++++++++++++++++++++++++++++++
> 2 files changed, 531 insertions(+), 1 deletion(-)
> enum {
> ERI = 0,
> @@ -32,6 +38,7 @@ enum {
> };
>
> enum {
> + RXTOUT,
> RXNEXT,
> TXEMPTY,
> TXEND,
> @@ -49,13 +56,14 @@ typedef struct RenesasSCIBaseState {
> SysBusDevice parent_obj;
>
> MemoryRegion memory;
> + MemoryRegion memory_p4;
> + MemoryRegion memory_a7;
> QEMUTimer *event_timer;
>
> /*< public >*/
> uint64_t input_freq;
> int64_t etu;
> int64_t trtime;
> - int64_t tx_start_time;
It looks like you added this field in patch 1, where it wasn't used,
and then deleted it again in patch 2...
thanks
-- PMM
next prev parent reply other threads:[~2021-06-29 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:12 [PATCH 0/3] renesas_sci update Yoshinori Sato
2021-06-16 9:12 ` [PATCH 1/3] hw/char: renesas_sci: Refactor for merge all SCI variant Yoshinori Sato
2021-06-29 12:33 ` Peter Maydell
2021-06-16 9:12 ` [PATCH 2/3] hw/char: renesas_sci Add SCI and SCIF support Yoshinori Sato
2021-06-29 12:37 ` Peter Maydell [this message]
2021-06-16 9:12 ` [PATCH 3/3] hw/sh4: sh7750 using renesas_sci Yoshinori Sato
2021-06-29 13:23 ` Peter Maydell
2021-06-30 15:15 ` Yoshinori Sato
2021-06-16 9:27 ` [PATCH 0/3] renesas_sci update no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA_paLV8eeEyAb=-TtxdA=3_Lc8191huZ8riHSHr8kDXKg@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.