From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E56C432BE for ; Wed, 1 Sep 2021 09:53:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 445C960F3A for ; Wed, 1 Sep 2021 09:53:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 445C960F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLMvl-00024P-3m for qemu-devel@archiver.kernel.org; Wed, 01 Sep 2021 05:53:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLMpH-00016b-99 for qemu-devel@nongnu.org; Wed, 01 Sep 2021 05:46:35 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:37533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLMpF-0004Ps-6E for qemu-devel@nongnu.org; Wed, 01 Sep 2021 05:46:35 -0400 Received: by mail-wm1-x32c.google.com with SMTP id c8-20020a7bc008000000b002e6e462e95fso4299828wmb.2 for ; Wed, 01 Sep 2021 02:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=revcarSj6np8LZ7OO5CWS3GjDmDv5IaOhcyAlm58VXM=; b=xjmD+YlHSPuso9/pKY8Uhg/pR8sMSSn83fzKQIfo+uISfaN83A1F6sDqfiGz+7qZ+U BcvUlB3JTTEUpn3Czz/gdp5hbEoCI926TqeV/XfX5Kz8lJoUMWl5s6RQXY99V1oMIFMC pywybdlNyO2jS43EKXVxgVs8lRQlndXMEM9l0fmzikDN12j32y6NDIPzKpBK6P5T0MNS rB9ASBnLJLIXG8GB1LdMgbBu75azbOx11mMO654rjPFGxnF6LynqUsqg1ozZtO1mQxZi CiDyFSE34bwTZnJy31EWl/ki6NZrbN9wkx+/Ini1YWHhQgJ9r3iE7NSw11vulRGZZAi5 0w2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=revcarSj6np8LZ7OO5CWS3GjDmDv5IaOhcyAlm58VXM=; b=b+p+HL2Sey8W/RUwg992RdLIjd7KbwUyUaOXADTkDJhe6/IpCTNNO/4j0qzi8D5D0L LXDatXAYArHEfpjTBUWtxsAdLkHYPittJKYXJmpKunkkahehcvnKHgCv84zvfmVK/14X oDEfI8CmQGGwmz4D0nVvT0g1hincsexHlO3dpRmVPFEnO3i7dMvqfnSvhUwHFusH8gpF YAZWbZruovXMCnW6/5EfIbtPTkXz6ULRxDcmOp0hRy8ZIfEsLMnEMOskdTCfB2/XAHgz JFxlplDIYs2kDGcAGxeIxWXl2w56dCEcFyldORLukdaYQtmEeNYB1nlv809tcF9LJ6rf zvng== X-Gm-Message-State: AOAM532cQTmIvnmu7btrPG6J5TCapbT0tmhujKPqnTPiVVOZAvEfz067 ChtBc28wC1F0o887G1ceb45GDdGznIle77Tor9iY+A== X-Google-Smtp-Source: ABdhPJxH3Nld0YOJH9A8Z+DO4JRzrt2F7MQtLQhKiBfqQJgTfWrg3oD+ieAhE/nZkA3wM1AnYF4pmls3kB5liIAwN34= X-Received: by 2002:a7b:cd83:: with SMTP id y3mr8708926wmj.126.1630489591715; Wed, 01 Sep 2021 02:46:31 -0700 (PDT) MIME-Version: 1.0 References: <20210805223002.144855-1-shashi.mallela@linaro.org> <20210805223002.144855-11-shashi.mallela@linaro.org> <20210901100324.3ce458f6@redhat.com> <20210901110207.13b3e34d@redhat.com> In-Reply-To: <20210901110207.13b3e34d@redhat.com> From: Peter Maydell Date: Wed, 1 Sep 2021 10:45:43 +0100 Message-ID: Subject: Re: [PATCH v7 10/10] tests/data/acpi/virt: Update IORT files for ITS To: Igor Mammedov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Shashi Mallela , Radoslaw Biernacki , QEMU Developers , Eric Auger , qemu-arm , Leif Lindholm Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 1 Sept 2021 at 10:02, Igor Mammedov wrote: > > On Wed, 1 Sep 2021 09:06:41 +0100 > Peter Maydell wrote: > > > On Wed, 1 Sept 2021 at 09:03, Igor Mammedov wrote= : > > > > > > not directly related to the patch but while I was testing IORT testca= se > > > (https://github.com/imammedo/qemu acpi-tests) > > > after rebase to 6.1, I get test failure due to change in MADT table v= s > > > expected blobs made in 6.0 time and it does look like ABI change > > > (what is bad, it also happens to virt-6.0 machine type). > > > Can ARM folks check if we didn't break something? > > > > > [02Ch 0044 1] Subtable Type : 0C [Generic Interrupt= Distributor] > > > [02Dh 0045 1] Length : 18 > > > [02Eh 0046 2] Reserved : 0000 > > > [030h 0048 4] Local GIC Hardware ID : 00000000 > > > [034h 0052 8] Base Address : 0000000008000000 > > > [03Ch 0060 4] Interrupt Base : 00000000 > > > -[040h 0064 1] Version : 02 > > > +[040h 0064 1] Version : 03 > > > > This says the GIC changed from GICv2 to v3. What QEMU command line are > For the test case, I'm more interested in if the rest of numbers are corr= ect for defaut virt machine type. > > But in case of virt-6.0 we might have problem. > > > you using here ? > > -machine virt -accel kvm -accel tcg -nodefaults -nographic -drive if=3Dpf= lash,format=3Draw,file=3Dpc-bios/edk2-aarch64-code.fd,readonly=3Don -drive = if=3Dpflash,format=3Draw,file=3Dpc-bios/edk2-arm-vars.fd,snapshot=3Don -cdr= om tests/data/uefi-boot-images/bios-tables-test.aarch64.iso.qcow2 -cpu host= -machine virt-6.0 > = ^^^^^^^^ With KVM enabled you get "whatever interrupt controller the host has", so the configuration is not stable across different host machines. So this is not a usable setup to generate or cross-check the ACPI test blobs. (It should get you the same configuration across QEMU versions but on the same host machine, though.) (All the diffs you quote are interrupt-controller related in one way or another.) -- PMM