All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Duskett <aduskett@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Joseph Kogut <joseph.kogut@gmail.com>,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/sentry-cli: remove package
Date: Thu, 19 Aug 2021 09:08:49 -0700	[thread overview]
Message-ID: <CAFSsvmqmKHD0k4fOWAV+Zdj+m=jSvafFYtw1vMsOj1Jf5rRMSA@mail.gmail.com> (raw)
In-Reply-To: <20210818235437.78a7826a@windsurf>

Hey Thomas;

On Wed, Aug 18, 2021 at 2:54 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Adam,
>
> On Wed, 18 Aug 2021 13:36:58 -0700
> Adam Duskett <aduskett@gmail.com> wrote:
>
> > It seems like version 1.68.0 fixes the build failures. I have tested
> > two different
> > defconfigs that are on the failure list:
> >   - bf7361dc482d8f3f97d523b7d56eabe5bc515ae8
> >   - 97aa03f497536462abc85011ba1c94874d18f237
> >
> > And the new version doesn't produce the failures that are plaguing the
> > autobuilders.
> >
> > Instead of removing the package, I would suggest updating it to 1.68.0 instead.
>
> Thanks for looking into this. Did you confirm that you were able to
> reproduce the failures *before* the version bump ?
>
Interestingly enough, my testing method was flawed. While I did spin
up a debian 9
docker container and the exact git hash that failed, I made the
mistake of running
`make host-sentry-cli` and not `make`

When calling host-sentry-cli directly, there isn't a failure, but when
running just `make`
the failure does appear. I am not sure how to pass include paths to
cargo, but it seems
like the only failure now is the missing zlib.h library if the package
is bumped to 1.68, as
the git repository error is indeed resolved.

Thanks!
Adam

> One of the issue seems to because by the host-sentry-cli calling into
> Git, which would probably work with in-tree builds, but not out-of-tree
> builds for example. Another issue seems to be related to zlib being
> available on the host system or not.
>
> So to know if the 1.68.0 update fixes the issue, we need to make sure
> that you were able to reproduce the failures with the current version,
> in the same setup as the one you tested the version bump with.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-19 16:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 20:22 [Buildroot] [PATCH] package/sentry-cli: remove package Thomas Petazzoni
2021-08-18 20:36 ` Adam Duskett
2021-08-18 21:54   ` Thomas Petazzoni
2021-08-19 16:08     ` Adam Duskett [this message]
2021-08-19 16:19       ` Thomas Petazzoni
2021-08-19 16:30         ` Adam Duskett
2021-08-19 17:56           ` Thomas Petazzoni
2021-08-19 20:50 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFSsvmqmKHD0k4fOWAV+Zdj+m=jSvafFYtw1vMsOj1Jf5rRMSA@mail.gmail.com' \
    --to=aduskett@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=joseph.kogut@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.