From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D34C48BE5 for ; Wed, 23 Jun 2021 01:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C7A16128C for ; Wed, 23 Jun 2021 01:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbhFWBRa (ORCPT ); Tue, 22 Jun 2021 21:17:30 -0400 Received: from linux.microsoft.com ([13.77.154.182]:44100 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbhFWBR3 (ORCPT ); Tue, 22 Jun 2021 21:17:29 -0400 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by linux.microsoft.com (Postfix) with ESMTPSA id 4100C20B83DE; Tue, 22 Jun 2021 18:15:13 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4100C20B83DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624410913; bh=l5w3e6a6uV45UCOPO09+HzRVeLGtrESc4iOLHXlLq40=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eeYWpJspNWBJwXVAAozA8nBj+r/ixX8Dlm+JJh+n64jeFEUJ7S/qji3vdmFeyzQbt o2riDk6C172kqvkolzAULl0Prm52N4EhZD+iNa6WslrYt/Zk2nv49Tgs7oXLEOlbUM SA+1cOODscth8UflP4gI2UwYnyL9Sma4U9qTv0kk= Received: by mail-pj1-f51.google.com with SMTP id pf4-20020a17090b1d84b029016f6699c3f2so2830143pjb.0; Tue, 22 Jun 2021 18:15:13 -0700 (PDT) X-Gm-Message-State: AOAM531HN9tl4pq5T/zalL6tlu0N2nme0etR/T3KGdk4iimkbQkexN5m l/CkOpe20Hnna7uOJt9X0VRF0oyayITVJ1mPTdk= X-Google-Smtp-Source: ABdhPJzLLexTZpICwihNJqNqUYtS2rIt+NYxLY8qUvXTajsE+vUnH89AEaOgxElegimr8XtRQl94Vvtz1Ub5nK9dW5E= X-Received: by 2002:a17:90a:650b:: with SMTP id i11mr6657767pjj.39.1624410912716; Tue, 22 Jun 2021 18:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20210617152754.17960-1-mcroce@linux.microsoft.com> <20210617152754.17960-4-mcroce@linux.microsoft.com> <17cd289430f08f2b75b7f04242c646f6@mailhost.ics.forth.gr> In-Reply-To: From: Matteo Croce Date: Wed, 23 Jun 2021 03:14:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/3] riscv: optimized memset To: David Laight Cc: Nick Kossifidis , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , Emil Renner Berthing , Akira Tsukamoto , Drew Fustini , Bin Meng , Guo Ren Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 10:38 AM David Laight wro= te: > > From: Nick Kossifidis > > Sent: 22 June 2021 02:08 > > > > =CE=A3=CF=84=CE=B9=CF=82 2021-06-17 18:27, Matteo Croce =CE=AD=CE=B3=CF= =81=CE=B1=CF=88=CE=B5: > > > + > > > +void *__memset(void *s, int c, size_t count) > > > +{ > > > + union types dest =3D { .u8 =3D s }; > > > + > > > + if (count >=3D MIN_THRESHOLD) { > > > + const int bytes_long =3D BITS_PER_LONG / 8; > > > > You could make 'const int bytes_long =3D BITS_PER_LONG / 8;' > > What is wrong with sizeof (long) ? > ... Nothing, I guess that BITS_PER_LONG is just (sizeof(long) * 8) anyway > > > + unsigned long cu =3D (unsigned long)c; > > > + > > > + /* Compose an ulong with 'c' repeated 4/8 times */ > > > + cu |=3D cu << 8; > > > + cu |=3D cu << 16; > > > +#if BITS_PER_LONG =3D=3D 64 > > > + cu |=3D cu << 32; > > > +#endif > > > + > > > > You don't have to create cu here, you'll fill dest buffer with 'c' > > anyway so after filling up enough 'c's to be able to grab an aligned > > word full of them from dest, you can just grab that word and keep > > filling up dest with it. > > That will be a lot slower - especially if run on something like x86. > A write-read of the same size is optimised by the store-load forwarder. > But the byte write, word read will have to go via the cache. > > You can just write: > cu =3D (unsigned long)c * 0x0101010101010101ull; > and let the compiler sort out the best way to generate the constant. > Interesting. I see that most compilers do an integer multiplication, is it faster than three shift and three or? clang on riscv generates even more instructions to create the immediate: unsigned long repeat_shift(int c) { unsigned long cu =3D (unsigned long)c; cu |=3D cu << 8; cu |=3D cu << 16; cu |=3D cu << 32; return cu; } unsigned long repeat_mul(int c) { return (unsigned long)c * 0x0101010101010101ull; } repeat_shift: slli a1, a0, 8 or a0, a0, a1 slli a1, a0, 16 or a0, a0, a1 slli a1, a0, 32 or a0, a0, a1 ret repeat_mul: lui a1, 4112 addiw a1, a1, 257 slli a1, a1, 16 addi a1, a1, 257 slli a1, a1, 16 addi a1, a1, 257 mul a0, a0, a1 ret > > > > > +#ifndef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS > > > + /* Fill the buffer one byte at time until the destination > > > + * is aligned on a 32/64 bit boundary. > > > + */ > > > + for (; count && dest.uptr % bytes_long; count--) > > > > You could reuse & mask here instead of % bytes_long. > > > > > + *dest.u8++ =3D c; > > > +#endif > > > > I noticed you also used CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS on your > > memcpy patch, is it worth it here ? To begin with riscv doesn't set it > > and even if it did we are talking about a loop that will run just a few > > times to reach the alignment boundary (worst case scenario it'll run 7 > > times), I don't think we gain much here, even for archs that have > > efficient unaligned access. > > With CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS it probably isn't worth > even checking the alignment. > While aligning the copy will be quicker for an unaligned buffer they > almost certainly don't happen often enough to worry about. > In any case you'd want to do a misaligned word write to the start > of the buffer - not separate byte writes. > Provided the buffer is long enough you can also do a misaligned write > to the end of the buffer before filling from the start. > I don't understand this one, a misaligned write here is ~30x slower than an aligned one because it gets trapped and emulated in SBI. How can this be convenient? > I suspect you may need either barrier() or use a ptr to packed > to avoid the perverted 'undefined behaviour' fubar.' > Which UB are you referring to? Regards, -- per aspera ad upstream From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44A22C2B9F4 for ; Wed, 23 Jun 2021 01:15:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4D0761166 for ; Wed, 23 Jun 2021 01:15:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4D0761166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dmOlwS65VytC+Vd1nahL3TCTV/NDfYe5hvNC36Fp8BI=; b=Kj6tG9Y3qURJbu x7/l1+cDCJLzas6GNwJAwHmMo05ZkxcIceYfr+E9WsagD4nFGGaRCqjmx3r4Fgj/dvHul4otpZLIF GLqjf6ioMcc2bw1Pr4ztPVZ2XSVX+n+D0FIO9s19i5T0/dtbwc3zG0b5+v4h3KQra5G0Nsg9Opnc1 +LtbICbE442Lskse6fk2t3gREfNo2aCFW8h6866dtNO2dGfVJT+mLncD/4IlAVxFnnpIqnLJjZQPP zw2C+I7ZQSSjY8GjfE0DHi8uagTGmPc73bwog0iq9HWC1HElUhDSux5xcLz8iP3dGAp2O5hwl4szF /h9i5wNODIOkSlXT9Arw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvrU5-008v4h-Av; Wed, 23 Jun 2021 01:15:17 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvrU2-008v3r-C3 for linux-riscv@lists.infradead.org; Wed, 23 Jun 2021 01:15:15 +0000 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by linux.microsoft.com (Postfix) with ESMTPSA id 3C85B20B6C14 for ; Tue, 22 Jun 2021 18:15:13 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3C85B20B6C14 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624410913; bh=l5w3e6a6uV45UCOPO09+HzRVeLGtrESc4iOLHXlLq40=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eeYWpJspNWBJwXVAAozA8nBj+r/ixX8Dlm+JJh+n64jeFEUJ7S/qji3vdmFeyzQbt o2riDk6C172kqvkolzAULl0Prm52N4EhZD+iNa6WslrYt/Zk2nv49Tgs7oXLEOlbUM SA+1cOODscth8UflP4gI2UwYnyL9Sma4U9qTv0kk= Received: by mail-pj1-f48.google.com with SMTP id c7-20020a17090ad907b029016faeeab0ccso2794248pjv.4 for ; Tue, 22 Jun 2021 18:15:13 -0700 (PDT) X-Gm-Message-State: AOAM531CpU2ywhd4tNvO1pm7Lb1v6gG1JzRAg+GQYfHNM0N1cvuHkfTk 443BqyuJNw6oYZkHlMd9/Ver897QFyZxX149VfY= X-Google-Smtp-Source: ABdhPJzLLexTZpICwihNJqNqUYtS2rIt+NYxLY8qUvXTajsE+vUnH89AEaOgxElegimr8XtRQl94Vvtz1Ub5nK9dW5E= X-Received: by 2002:a17:90a:650b:: with SMTP id i11mr6657767pjj.39.1624410912716; Tue, 22 Jun 2021 18:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20210617152754.17960-1-mcroce@linux.microsoft.com> <20210617152754.17960-4-mcroce@linux.microsoft.com> <17cd289430f08f2b75b7f04242c646f6@mailhost.ics.forth.gr> In-Reply-To: From: Matteo Croce Date: Wed, 23 Jun 2021 03:14:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/3] riscv: optimized memset To: David Laight Cc: Nick Kossifidis , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , Emil Renner Berthing , Akira Tsukamoto , Drew Fustini , Bin Meng , Guo Ren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_181514_626295_BC64C8C4 X-CRM114-Status: GOOD ( 31.03 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMjIsIDIwMjEgYXQgMTA6MzggQU0gRGF2aWQgTGFpZ2h0IDxEYXZpZC5MYWln aHRAYWN1bGFiLmNvbT4gd3JvdGU6Cj4KPiBGcm9tOiBOaWNrIEtvc3NpZmlkaXMKPiA+IFNlbnQ6 IDIyIEp1bmUgMjAyMSAwMjowOAo+ID4KPiA+IM6jz4TOuc+CIDIwMjEtMDYtMTcgMTg6MjcsIE1h dHRlbyBDcm9jZSDOrc6zz4HOsc+IzrU6Cj4gPiA+ICsKPiA+ID4gK3ZvaWQgKl9fbWVtc2V0KHZv aWQgKnMsIGludCBjLCBzaXplX3QgY291bnQpCj4gPiA+ICt7Cj4gPiA+ICsgICB1bmlvbiB0eXBl cyBkZXN0ID0geyAudTggPSBzIH07Cj4gPiA+ICsKPiA+ID4gKyAgIGlmIChjb3VudCA+PSBNSU5f VEhSRVNIT0xEKSB7Cj4gPiA+ICsgICAgICAgICAgIGNvbnN0IGludCBieXRlc19sb25nID0gQklU U19QRVJfTE9ORyAvIDg7Cj4gPgo+ID4gWW91IGNvdWxkIG1ha2UgJ2NvbnN0IGludCBieXRlc19s b25nID0gQklUU19QRVJfTE9ORyAvIDg7Jwo+Cj4gV2hhdCBpcyB3cm9uZyB3aXRoIHNpemVvZiAo bG9uZykgPwo+IC4uLgoKTm90aGluZywgSSBndWVzcyB0aGF0IEJJVFNfUEVSX0xPTkcgaXMganVz dCAoc2l6ZW9mKGxvbmcpICogOCkgYW55d2F5Cgo+ID4gPiArICAgICAgICAgICB1bnNpZ25lZCBs b25nIGN1ID0gKHVuc2lnbmVkIGxvbmcpYzsKPiA+ID4gKwo+ID4gPiArICAgICAgICAgICAvKiBD b21wb3NlIGFuIHVsb25nIHdpdGggJ2MnIHJlcGVhdGVkIDQvOCB0aW1lcyAqLwo+ID4gPiArICAg ICAgICAgICBjdSB8PSBjdSA8PCA4Owo+ID4gPiArICAgICAgICAgICBjdSB8PSBjdSA8PCAxNjsK PiA+ID4gKyNpZiBCSVRTX1BFUl9MT05HID09IDY0Cj4gPiA+ICsgICAgICAgICAgIGN1IHw9IGN1 IDw8IDMyOwo+ID4gPiArI2VuZGlmCj4gPiA+ICsKPiA+Cj4gPiBZb3UgZG9uJ3QgaGF2ZSB0byBj cmVhdGUgY3UgaGVyZSwgeW91J2xsIGZpbGwgZGVzdCBidWZmZXIgd2l0aCAnYycKPiA+IGFueXdh eSBzbyBhZnRlciBmaWxsaW5nIHVwIGVub3VnaCAnYydzIHRvIGJlIGFibGUgdG8gZ3JhYiBhbiBh bGlnbmVkCj4gPiB3b3JkIGZ1bGwgb2YgdGhlbSBmcm9tIGRlc3QsIHlvdSBjYW4ganVzdCBncmFi IHRoYXQgd29yZCBhbmQga2VlcAo+ID4gZmlsbGluZyB1cCBkZXN0IHdpdGggaXQuCj4KPiBUaGF0 IHdpbGwgYmUgYSBsb3Qgc2xvd2VyIC0gZXNwZWNpYWxseSBpZiBydW4gb24gc29tZXRoaW5nIGxp a2UgeDg2Lgo+IEEgd3JpdGUtcmVhZCBvZiB0aGUgc2FtZSBzaXplIGlzIG9wdGltaXNlZCBieSB0 aGUgc3RvcmUtbG9hZCBmb3J3YXJkZXIuCj4gQnV0IHRoZSBieXRlIHdyaXRlLCB3b3JkIHJlYWQg d2lsbCBoYXZlIHRvIGdvIHZpYSB0aGUgY2FjaGUuCj4KPiBZb3UgY2FuIGp1c3Qgd3JpdGU6Cj4g ICAgICAgICBjdSA9ICh1bnNpZ25lZCBsb25nKWMgKiAweDAxMDEwMTAxMDEwMTAxMDF1bGw7Cj4g YW5kIGxldCB0aGUgY29tcGlsZXIgc29ydCBvdXQgdGhlIGJlc3Qgd2F5IHRvIGdlbmVyYXRlIHRo ZSBjb25zdGFudC4KPgoKSW50ZXJlc3RpbmcuIEkgc2VlIHRoYXQgbW9zdCBjb21waWxlcnMgZG8g YW4gaW50ZWdlciBtdWx0aXBsaWNhdGlvbiwKaXMgaXQgZmFzdGVyIHRoYW4gdGhyZWUgc2hpZnQg YW5kIHRocmVlIG9yPwoKY2xhbmcgb24gcmlzY3YgZ2VuZXJhdGVzIGV2ZW4gbW9yZSBpbnN0cnVj dGlvbnMgdG8gY3JlYXRlIHRoZSBpbW1lZGlhdGU6Cgp1bnNpZ25lZCBsb25nIHJlcGVhdF9zaGlm dChpbnQgYykKewogIHVuc2lnbmVkIGxvbmcgY3UgPSAodW5zaWduZWQgbG9uZyljOwogIGN1IHw9 IGN1IDw8IDg7CiAgY3UgfD0gY3UgPDwgMTY7CiAgY3UgfD0gY3UgPDwgMzI7CgogIHJldHVybiBj dTsKfQoKdW5zaWduZWQgbG9uZyByZXBlYXRfbXVsKGludCBjKQp7CiAgcmV0dXJuICh1bnNpZ25l ZCBsb25nKWMgKiAweDAxMDEwMTAxMDEwMTAxMDF1bGw7Cn0KCnJlcGVhdF9zaGlmdDoKICBzbGxp IGExLCBhMCwgOAogIG9yIGEwLCBhMCwgYTEKICBzbGxpIGExLCBhMCwgMTYKICBvciBhMCwgYTAs IGExCiAgc2xsaSBhMSwgYTAsIDMyCiAgb3IgYTAsIGEwLCBhMQogIHJldAoKcmVwZWF0X211bDoK ICBsdWkgYTEsIDQxMTIKICBhZGRpdyBhMSwgYTEsIDI1NwogIHNsbGkgYTEsIGExLCAxNgogIGFk ZGkgYTEsIGExLCAyNTcKICBzbGxpIGExLCBhMSwgMTYKICBhZGRpIGExLCBhMSwgMjU3CiAgbXVs IGEwLCBhMCwgYTEKICByZXQKCj4gPgo+ID4gPiArI2lmbmRlZiBDT05GSUdfSEFWRV9FRkZJQ0lF TlRfVU5BTElHTkVEX0FDQ0VTUwo+ID4gPiArICAgICAgICAgICAvKiBGaWxsIHRoZSBidWZmZXIg b25lIGJ5dGUgYXQgdGltZSB1bnRpbCB0aGUgZGVzdGluYXRpb24KPiA+ID4gKyAgICAgICAgICAg ICogaXMgYWxpZ25lZCBvbiBhIDMyLzY0IGJpdCBib3VuZGFyeS4KPiA+ID4gKyAgICAgICAgICAg ICovCj4gPiA+ICsgICAgICAgICAgIGZvciAoOyBjb3VudCAmJiBkZXN0LnVwdHIgJSBieXRlc19s b25nOyBjb3VudC0tKQo+ID4KPiA+IFlvdSBjb3VsZCByZXVzZSAmIG1hc2sgaGVyZSBpbnN0ZWFk IG9mICUgYnl0ZXNfbG9uZy4KPiA+Cj4gPiA+ICsgICAgICAgICAgICAgICAgICAgKmRlc3QudTgr KyA9IGM7Cj4gPiA+ICsjZW5kaWYKPiA+Cj4gPiBJIG5vdGljZWQgeW91IGFsc28gdXNlZCBDT05G SUdfSEFWRV9FRkZJQ0lFTlRfVU5BTElHTkVEX0FDQ0VTUyBvbiB5b3VyCj4gPiBtZW1jcHkgcGF0 Y2gsIGlzIGl0IHdvcnRoIGl0IGhlcmUgPyBUbyBiZWdpbiB3aXRoIHJpc2N2IGRvZXNuJ3Qgc2V0 IGl0Cj4gPiBhbmQgZXZlbiBpZiBpdCBkaWQgd2UgYXJlIHRhbGtpbmcgYWJvdXQgYSBsb29wIHRo YXQgd2lsbCBydW4ganVzdCBhIGZldwo+ID4gdGltZXMgdG8gcmVhY2ggdGhlIGFsaWdubWVudCBi b3VuZGFyeSAod29yc3QgY2FzZSBzY2VuYXJpbyBpdCdsbCBydW4gNwo+ID4gdGltZXMpLCBJIGRv bid0IHRoaW5rIHdlIGdhaW4gbXVjaCBoZXJlLCBldmVuIGZvciBhcmNocyB0aGF0IGhhdmUKPiA+ IGVmZmljaWVudCB1bmFsaWduZWQgYWNjZXNzLgo+Cj4gV2l0aCBDT05GSUdfSEFWRV9FRkZJQ0lF TlRfVU5BTElHTkVEX0FDQ0VTUyBpdCBwcm9iYWJseSBpc24ndCB3b3J0aAo+IGV2ZW4gY2hlY2tp bmcgdGhlIGFsaWdubWVudC4KPiBXaGlsZSBhbGlnbmluZyB0aGUgY29weSB3aWxsIGJlIHF1aWNr ZXIgZm9yIGFuIHVuYWxpZ25lZCBidWZmZXIgdGhleQo+IGFsbW9zdCBjZXJ0YWlubHkgZG9uJ3Qg aGFwcGVuIG9mdGVuIGVub3VnaCB0byB3b3JyeSBhYm91dC4KPiBJbiBhbnkgY2FzZSB5b3UnZCB3 YW50IHRvIGRvIGEgbWlzYWxpZ25lZCB3b3JkIHdyaXRlIHRvIHRoZSBzdGFydAo+IG9mIHRoZSBi dWZmZXIgLSBub3Qgc2VwYXJhdGUgYnl0ZSB3cml0ZXMuCj4gUHJvdmlkZWQgdGhlIGJ1ZmZlciBp cyBsb25nIGVub3VnaCB5b3UgY2FuIGFsc28gZG8gYSBtaXNhbGlnbmVkIHdyaXRlCj4gdG8gdGhl IGVuZCBvZiB0aGUgYnVmZmVyIGJlZm9yZSBmaWxsaW5nIGZyb20gdGhlIHN0YXJ0Lgo+CgpJIGRv bid0IHVuZGVyc3RhbmQgdGhpcyBvbmUsIGEgbWlzYWxpZ25lZCB3cml0ZSBoZXJlIGlzIH4zMHgg c2xvd2VyCnRoYW4gYW4gYWxpZ25lZCBvbmUgYmVjYXVzZSBpdCBnZXRzIHRyYXBwZWQgYW5kIGVt dWxhdGVkIGluIFNCSS4KSG93IGNhbiB0aGlzIGJlIGNvbnZlbmllbnQ/Cgo+IEkgc3VzcGVjdCB5 b3UgbWF5IG5lZWQgZWl0aGVyIGJhcnJpZXIoKSBvciB1c2UgYSBwdHIgdG8gcGFja2VkCj4gdG8g YXZvaWQgdGhlIHBlcnZlcnRlZCAndW5kZWZpbmVkIGJlaGF2aW91cicgZnViYXIuJwo+CgpXaGlj aCBVQiBhcmUgeW91IHJlZmVycmluZyB0bz8KClJlZ2FyZHMsCi0tCnBlciBhc3BlcmEgYWQgdXBz dHJlYW0KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK