From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B78C433B4 for ; Tue, 13 Apr 2021 20:21:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 413D1613D2 for ; Tue, 13 Apr 2021 20:21:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346488AbhDMUVr (ORCPT ); Tue, 13 Apr 2021 16:21:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231985AbhDMUVp (ORCPT ); Tue, 13 Apr 2021 16:21:45 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97294C061574 for ; Tue, 13 Apr 2021 13:21:24 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id e8-20020a17090a7288b029014e51f5a6baso4279213pjg.2 for ; Tue, 13 Apr 2021 13:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5vd4hM8TIUo1RzgqEpGrao+8fNPd8c1Sl3okjl2RgvE=; b=UgQsWVZdRVQjOVJF5/lChHhgFrkLrfGkEpmZe1BnJBVnMSYFbM1Sjmbu4KBbIr6Ure AqtAfm90wlS5eO7S1LVe5jR2mkXdAiITLN3SkID6bE/KaQiOFl8foEC5PJAmWtJY/WeR afuoY61aoDYYXFaesMICWF2dTx3JYwO4TIFsXt+TbbukHA3S87shTHxYuOA1Iz+zsu+P 3P1nS+5HjYUUInaHaeSH3L7KOhcRrfFlNnMuxsEdppKd1zj/jzskDie/RrKIqf7RNd2t HwRBvMHe1PnDKCtTknuP7IzEA+5AZIeCVjDxpKX39H2FXRqJKI/Hk6CBPvj6R9aQtdXj cvpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5vd4hM8TIUo1RzgqEpGrao+8fNPd8c1Sl3okjl2RgvE=; b=JFi0wAOmKvddobULNf7vcSWhLhoEtjM9FnNEL5ljTdhPwE2D8rI+OHWgXdyyor7Tmj /S/NoD55YuM9W4we/oid4K/X/1sO0li7T1ZYLd2cN2bjZNpiNii0TfM9UEpJppITIWZq lBI8piC4RNSaLzzO/zwB+U2mQKAO3HxohywNhJszfJu0j1RTHwlVftmDAcN16IcgGLXT +L7rJ4XcyFaw94tddP/JCcpiSJBwaDbLyXYwj5Tn5kllNmIk4stMYR6hWq/ZtIJt+PyT g9xaR+ZJcrc0kWiT+WYpeuOG1rs4CXidAhX3n4U8eoYXM76LY2Zp2FfBY4b0r7KJ+lUO h/Kg== X-Gm-Message-State: AOAM533dKJHGE7ffH8sIkBaN06jjqNibuXWCu7WL0eoCu9M8wyyz8d8l MwnJSOzD5mpL7wRmMDBOsGFE9vfDk/eptG3xg0HhEA== X-Google-Smtp-Source: ABdhPJx2Q6trbmEyBPGMNkyaEggQB8G9ymoTlSsx6e9e4BsAJxS4fWCVAK1KopE210nmGmxkN456S/yZaq4pzyRbTkA= X-Received: by 2002:a17:90a:4a8f:: with SMTP id f15mr1900457pjh.19.1618345283988; Tue, 13 Apr 2021 13:21:23 -0700 (PDT) MIME-Version: 1.0 References: <20210412154648.3719153-1-narmstrong@baylibre.com> <20210412154648.3719153-3-narmstrong@baylibre.com> In-Reply-To: <20210412154648.3719153-3-narmstrong@baylibre.com> From: Robert Foss Date: Tue, 13 Apr 2021 22:21:13 +0200 Message-ID: Subject: Re: [PATCH v3 2/3] drm: bridge: add it66121 driver To: Neil Armstrong Cc: Andrzej Hajda , Laurent Pinchart , paul@crapouillou.net, Jonas Karlman , Jernej Skrabec , dri-devel , linux-kernel , Phong LE Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Neil & Phong, Thanks for submitting this series! > + > +static const struct drm_bridge_funcs it66121_bridge_funcs = { > + .attach = it66121_bridge_attach, > + .enable = it66121_bridge_enable, > + .disable = it66121_bridge_disable, > + .mode_set = it66121_bridge_mode_set, > + .mode_valid = it66121_bridge_mode_valid, > + .detect = it66121_bridge_detect, > + .get_edid = it66121_bridge_get_edid, > + .atomic_get_output_bus_fmts = it66121_bridge_atomic_get_output_bus_fmts, > + .atomic_get_input_bus_fmts = it66121_bridge_atomic_get_input_bus_fmts, > +}; I would like to see an implementation of HPD, since it is supported by the hardware[1] (and required by the documentation). IRQ status bit 0 seems to be the responsible for notifying us about hot plug detection events. [1] https://rockchip.fr/radxa/IT66121_Programming_Guide.v1.05.pdf Rob. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D9FC433ED for ; Tue, 13 Apr 2021 20:21:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24C39611C9 for ; Tue, 13 Apr 2021 20:21:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24C39611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0662D6E196; Tue, 13 Apr 2021 20:21:25 +0000 (UTC) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by gabe.freedesktop.org (Postfix) with ESMTPS id 657A36E3EB for ; Tue, 13 Apr 2021 20:21:24 +0000 (UTC) Received: by mail-pj1-x1030.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so11300660pjh.1 for ; Tue, 13 Apr 2021 13:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5vd4hM8TIUo1RzgqEpGrao+8fNPd8c1Sl3okjl2RgvE=; b=UgQsWVZdRVQjOVJF5/lChHhgFrkLrfGkEpmZe1BnJBVnMSYFbM1Sjmbu4KBbIr6Ure AqtAfm90wlS5eO7S1LVe5jR2mkXdAiITLN3SkID6bE/KaQiOFl8foEC5PJAmWtJY/WeR afuoY61aoDYYXFaesMICWF2dTx3JYwO4TIFsXt+TbbukHA3S87shTHxYuOA1Iz+zsu+P 3P1nS+5HjYUUInaHaeSH3L7KOhcRrfFlNnMuxsEdppKd1zj/jzskDie/RrKIqf7RNd2t HwRBvMHe1PnDKCtTknuP7IzEA+5AZIeCVjDxpKX39H2FXRqJKI/Hk6CBPvj6R9aQtdXj cvpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5vd4hM8TIUo1RzgqEpGrao+8fNPd8c1Sl3okjl2RgvE=; b=gI7na3cywmVIx6XuYoxHbkowIepM2TZiYDEwei3kxeV/X6/j47xILFnISBi37r9zSV wAWs+6lZmsKe6qJPM0GIi77rzqNjQTj0eLPufwzylUDGo1jMbYUmXwBTi5JVgEB9O53k VDWZXjeEl8+0SntMmoP5FAt4OzLrxx7gmKtEe0Qw4pqtJFsWCZyxmN6iFA/OU6GwjOgl nK3wNBaPT5mk1TgpSS6dGhLtUn+hhcNEQdEHH2oXuf+OeX7z82ZkfIozXXnf50Fw0ltB yAHMqBC80/Nx13oiGEcaUBbFRucBHYpMeEQATf6Fc/s0C0vA1MFOxUlsL5DzEPt5W/2v 9shg== X-Gm-Message-State: AOAM531j06cTdwen9Uu6o9Rb6CCKNMHvbX+Rs3bipKPtNC+w4XzwytcG nQMQMad9pe7finDPlXX9MVNwyhhWz8QO5paxJWENbQ== X-Google-Smtp-Source: ABdhPJx2Q6trbmEyBPGMNkyaEggQB8G9ymoTlSsx6e9e4BsAJxS4fWCVAK1KopE210nmGmxkN456S/yZaq4pzyRbTkA= X-Received: by 2002:a17:90a:4a8f:: with SMTP id f15mr1900457pjh.19.1618345283988; Tue, 13 Apr 2021 13:21:23 -0700 (PDT) MIME-Version: 1.0 References: <20210412154648.3719153-1-narmstrong@baylibre.com> <20210412154648.3719153-3-narmstrong@baylibre.com> In-Reply-To: <20210412154648.3719153-3-narmstrong@baylibre.com> From: Robert Foss Date: Tue, 13 Apr 2021 22:21:13 +0200 Message-ID: Subject: Re: [PATCH v3 2/3] drm: bridge: add it66121 driver To: Neil Armstrong X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Phong LE , Jernej Skrabec , Jonas Karlman , linux-kernel , dri-devel , paul@crapouillou.net, Andrzej Hajda , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hey Neil & Phong, Thanks for submitting this series! > + > +static const struct drm_bridge_funcs it66121_bridge_funcs = { > + .attach = it66121_bridge_attach, > + .enable = it66121_bridge_enable, > + .disable = it66121_bridge_disable, > + .mode_set = it66121_bridge_mode_set, > + .mode_valid = it66121_bridge_mode_valid, > + .detect = it66121_bridge_detect, > + .get_edid = it66121_bridge_get_edid, > + .atomic_get_output_bus_fmts = it66121_bridge_atomic_get_output_bus_fmts, > + .atomic_get_input_bus_fmts = it66121_bridge_atomic_get_input_bus_fmts, > +}; I would like to see an implementation of HPD, since it is supported by the hardware[1] (and required by the documentation). IRQ status bit 0 seems to be the responsible for notifying us about hot plug detection events. [1] https://rockchip.fr/radxa/IT66121_Programming_Guide.v1.05.pdf Rob. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel