From: "Zoran" <zoran.stojsavljevic@gmail.com>
To: Yann Dirson <yann.dirson@blade-group.com>
Cc: Yocto Project <yocto@yoctoproject.org>,
twoerner@gmail.com, Yann Dirson <yann@blade-group.com>
Subject: Re: [yocto] [meta-rockchip][PATCH] trusted-firmware-a: use 1500000 baud for serial console
Date: Wed, 7 Apr 2021 06:07:16 +0200 [thread overview]
Message-ID: <CAGAf8Lwh8vP8K+ppSY1nefdw_Rx0eGnjz=P4=tyztPKPhMniqg@mail.gmail.com> (raw)
In-Reply-To: <20210406234700.2493404-1-yann@blade-group.com>
> +-#define RK3399_BAUDRATE 115200
> ++#define RK3399_BAUDRATE 1500000
> + #define RK3399_UART_CLOCK 24000000
Interesting... For years (a few decades) everybody has used 115200 as
the standard setup for UART, as global definition.
Why suddenly somebody changed the UART baud rate to be non-standard?
From the speed point of view???
Don't think so.
Should U-Boot be adjusted to the standard baud rate of 115200 for RK3399?
My two cent addendum/thinking,
Zee
_______
On Wed, Apr 7, 2021 at 1:47 AM Yann Dirson <yann.dirson@blade-group.com> wrote:
>
> From: Yann Dirson <yann@blade-group.com>
>
> TF-A runs between two u-boot stages which both uses 1500000 baud, it
> just makes no sense to use the same UART at a different rate.
>
> Here is a sample session with the successive stages, with TF-A artificially
> separated for emphasis:
>
> [20210406-175438.135934] U-Boot TPL 2021.01 (Jan 11 2021 - 18:11:43)
> [20210406-175438.135956] Channel 0: DDR3, 933MHz
> [20210406-175438.236974] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16 Size=1024MB
> [20210406-175438.237000] Channel 1: DDR3, 933MHz
> [20210406-175438.237004] BW=32 Col=10 Bk=8 CS0 Row=15 CS=1 Die BW=16 Size=1024MB
> [20210406-175438.237008] 256B stride
> [20210406-175438.237012] Trying to boot from BOOTROM
> [20210406-175438.237015] Returning to boot ROM...
> [20210406-175438.237018]
> [20210406-175438.573394] U-Boot SPL 2021.01 (Jan 11 2021 - 18:11:43 +0000)
> [20210406-175438.573431] Trying to boot from MMC1
>
> [20210406-175438.589254] NOTICE: BL31: v2.3():v2.3-dirty
> [20210406-175440.534055] NOTICE: BL31: Built : 15:56:43, Apr 20 2020
>
> [20210406-175441.393423] U-Boot 2021.01 (Jan 11 2021 - 18:11:43 +0000)
> [20210406-175441.393429]
> [20210406-175441.393433] SoC: Rockchip rk3399
>
> Signed-off-by: Yann Dirson <yann@blade-group.com>
> ---
> .../files/serial-console-baudrate.patch | 35 +++++++++++++++++++
> .../trusted-firmware-a_%.bbappend | 5 +++
> 2 files changed, 40 insertions(+)
> create mode 100644 recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
>
> diff --git a/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
> new file mode 100644
> index 0000000..10b5a2b
> --- /dev/null
> +++ b/recipes-bsp/trusted-firmware-a/files/serial-console-baudrate.patch
> @@ -0,0 +1,35 @@
> +From 840d6b6420e1fd8cdf6e4de7fa58a6f8de151622 Mon Sep 17 00:00:00 2001
> +From: Yann Dirson <yann@blade-group.com>
> +Date: Tue, 6 Apr 2021 17:28:45 +0200
> +Subject: [PATCH] Set serial console baudrate back to 1500000.
> +
> +TF-A runs between two u-boot stages which both uses 1500000 baud, it
> +just makes no sense to use the same UART at a different rate.
> +
> +This effectively reverts part of 0c05748bdebfad9fa43a80962186438bb8fbce62.
> +Main reason for that change stated in https://developer.trustedfirmware.org/T762
> +is ChromeOS compatibility.
> +
> +Looks like this patch may become unnecessary in the future, when
> +u-boot and TF-A get to communicate this value.
> +
> +---
> + plat/rockchip/rk3399/rk3399_def.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/plat/rockchip/rk3399/rk3399_def.h b/plat/rockchip/rk3399/rk3399_def.h
> +index ba83242eb..8d6ecfbe6 100644
> +--- a/plat/rockchip/rk3399/rk3399_def.h
> ++++ b/plat/rockchip/rk3399/rk3399_def.h
> +@@ -17,7 +17,7 @@
> + /**************************************************************************
> + * UART related constants
> + **************************************************************************/
> +-#define RK3399_BAUDRATE 115200
> ++#define RK3399_BAUDRATE 1500000
> + #define RK3399_UART_CLOCK 24000000
> +
> + /******************************************************************************
> +--
> +2.30.2
> +
> diff --git a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> index 442dee8..1942c17 100644
> --- a/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> +++ b/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
> @@ -4,3 +4,8 @@ DEPENDS_append_rk3399 = " virtual/arm-none-eabi-gcc-native"
>
> COMPATIBLE_MACHINE_append_rk3399 = "|rk3399"
> COMPATIBLE_MACHINE_append_rk3328 = "|rk3328"
> +
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> +SRC_URI += "\
> + file://serial-console-baudrate.patch \
> +"
> --
> 2.30.2
>
>
>
>
next prev parent reply other threads:[~2021-04-07 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 23:47 [meta-rockchip][PATCH] trusted-firmware-a: use 1500000 baud for serial console Yann Dirson
2021-04-07 4:07 ` Zoran [this message]
2021-04-07 8:54 ` [yocto] " Yann Dirson
2021-04-07 9:33 ` Zoran
2021-04-07 13:27 ` Joshua Watt
2021-04-07 13:45 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGAf8Lwh8vP8K+ppSY1nefdw_Rx0eGnjz=P4=tyztPKPhMniqg@mail.gmail.com' \
--to=zoran.stojsavljevic@gmail.com \
--cc=twoerner@gmail.com \
--cc=yann.dirson@blade-group.com \
--cc=yann@blade-group.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.