From: Kees Cook <keescook@chromium.org>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86, vsyscall: add CONFIG to control default
Date: Mon, 31 Aug 2015 13:13:14 -0700 [thread overview]
Message-ID: <CAGXu5jK4ezPO+i1Q5VjfBkuipn-jxCcoq_Rn5nJqHH-Hzh6R-w@mail.gmail.com> (raw)
In-Reply-To: <20150813022336.GA26334@x>
On Wed, Aug 12, 2015 at 7:23 PM, Josh Triplett <josh@joshtriplett.org> wrote:
> On Wed, Aug 12, 2015 at 05:55:19PM -0700, Kees Cook wrote:
>> Most modern systems can run with vsyscall=none. In an effort to provide
>> a way for build-time defaults to lack legacy settings, this adds a new
>> CONFIG to select the type of vsyscall mapping to use, similar to the
>> existing "vsyscall" command line parameter.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Seems reasonable to me. One question, though: is there *any* reason to
> choose "native" over "emulate"? (Does "emulate" have a sufficient
> performance penalty to matter, and do people running old glibc really
> care about that performance while still not wanting to upgrade?)
> If there is a reason, could you please document it in the
> descriptions of the "native" and "emulate" options (as an upside and a
> downside, respectively)? If there isn't, you might consider a patch to
> remove "native".
I think "native" is available out of an abundance of caution. Andy
left it available, though I'm not sure if he had plans to remove
"native" entirely.
Can someone from the x86 tree take this patch, or are there other
things to improve?
Thanks!
-Kees
--
Kees Cook
Chrome OS Security
next prev parent reply other threads:[~2015-08-31 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 0:55 [PATCH] x86, vsyscall: add CONFIG to control default Kees Cook
2015-08-13 2:23 ` Josh Triplett
2015-08-31 20:13 ` Kees Cook [this message]
2015-08-31 21:23 ` Andy Lutomirski
2015-09-03 21:08 ` Kees Cook
2015-09-20 11:29 ` [tip:x86/asm] x86/entry/vsyscall: Add " tip-bot for Kees Cook
2015-09-21 7:48 ` Borislav Petkov
2015-09-21 8:00 ` [tip:x86/asm] x86/entry/vsyscall: Fix undefined symbol warning tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jK4ezPO+i1Q5VjfBkuipn-jxCcoq_Rn5nJqHH-Hzh6R-w@mail.gmail.com \
--to=keescook@chromium.org \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.