From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB58C2B9F7 for ; Wed, 26 May 2021 07:28:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9562261355 for ; Wed, 26 May 2021 07:28:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9562261355 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 347F082AF4; Wed, 26 May 2021 09:28:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="bqk4KNkE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8879481D48; Wed, 26 May 2021 09:28:40 +0200 (CEST) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 42ED881D48 for ; Wed, 26 May 2021 09:28:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rfried.dev@gmail.com Received: by mail-oi1-x22c.google.com with SMTP id d21so603585oic.11 for ; Wed, 26 May 2021 00:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o9Laxak5/8Hi77ZL75CGpGbL0nfHAj9Sm0hPuEMwAQc=; b=bqk4KNkEoRj4rFuNkRQ3g9Twz3OEMYg7EYyUAbIHa0csAhWGgfR1UnEiHmddhdBxL8 uBYpZDm9rhGZ4VZXDf8ktyu3CGr2ihHw/xmflLBa5b89blqRGADUT+z5YzOLgXTDrPQn VE1Aije372Y15t0ZGlTVP2WqNTsDbXAadv3dCf3y6+vCsVApazPxgiEp7AFvGd5SQVVR HdZqjVNv/om36KpppwWqc8i7cf5BZUKmb+gRm91H6GkqdBMql9l9Dqw9P8v5nT+OZFAe upAwskMLwxxoO+D6HgfoBtO7gj83q7jzk3JpVXPiEq0aAxEaUHcKv1YBGLC5LLgSxybX HC1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o9Laxak5/8Hi77ZL75CGpGbL0nfHAj9Sm0hPuEMwAQc=; b=KhjpSg5s65uRBpa+NHe2yypWCU9YcIm+DpPAphI3hAyr+e3v6D0y8EW1L2W4J5chdA JxMCNL55xIhCaGJAN9av53u/B7Or3JoAdVNZDx1c/gpJ48m7HlNNWbyeZSjKPjrbpMi8 JsjciSLyOoXQ1bLDr6V4/hnY19HY/Vr/ebdDn8g2jbwQ0Nk3kfXSHq1PJt8C1Otf9DiF JqoYzowPkG9pREXHiKqmjAuHcQW7PpEq/zSkj/hnIJ1LpvLlkG9peAtFu7IgeT97PeI5 zD75WH6YVemzEJbR2uyHuH/lQXIzR3mNuUX0i/MHClm7q4qcKz53L1mss9BePsobPwaT N5yQ== X-Gm-Message-State: AOAM530TtVEn2BdR24jetL/qVdfUqGyMvVHlbNcQ+TlVbOVn0sf7R8dN 2n4KFu2KCvuF7QrmKC7Vmv3Iwc1Adb4Gu8i8nOw= X-Google-Smtp-Source: ABdhPJyu1nLWDBMMz1mQVbPdxVEx6lynjccqDgkRyuhopwp+atDprEIPRmbo+x600b+/tn94RpeIPzZXbgpw/LViz74= X-Received: by 2002:aca:a9c6:: with SMTP id s189mr965838oie.92.1622014114560; Wed, 26 May 2021 00:28:34 -0700 (PDT) MIME-Version: 1.0 References: <20210525175240.380140-1-aford173@gmail.com> In-Reply-To: <20210525175240.380140-1-aford173@gmail.com> From: Ramon Fried Date: Wed, 26 May 2021 10:28:23 +0300 Message-ID: Subject: Re: [PATCH] net: ravb: Add additional refclk To: Adam Ford Cc: U-Boot Mailing List , Joe Hershberger , charles.stevens@logicpd.com, aford@beaconembedded.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On Tue, May 25, 2021 at 8:52 PM Adam Ford wrote: > > The ethernet requires an external reference clock, and the driver > currently assumes the clock is always running. For devices using > a programmable clock, this may not be true. Add an optional clock > called 'refclk' to open and enable the refclk for hardware running > with programmable clocks. > > Signed-off-by: Adam Ford > --- > This was also done in the Linux kernel, see: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/renesas/ravb_main.c?id=8ef7adc6beb2ef0bce83513dc9e4505e7b21e8c2 > > diff --git a/drivers/net/ravb.c b/drivers/net/ravb.c > index 6953b7286a..ced80485de 100644 > --- a/drivers/net/ravb.c > +++ b/drivers/net/ravb.c > @@ -130,6 +130,7 @@ struct ravb_priv { > struct mii_dev *bus; > void __iomem *iobase; > struct clk clk; > + struct clk *refclk; > struct gpio_desc reset_gpio; > }; > > @@ -489,6 +490,8 @@ static int ravb_probe(struct udevice *dev) > if (ret < 0) > goto err_mdio_alloc; > > + eth->refclk = devm_clk_get_optional(dev, "refclk"); > + > ret = dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0, &phandle_args); > if (!ret) { > gpio_request_by_name_nodev(phandle_args.node, "reset-gpios", 0, > @@ -522,6 +525,10 @@ static int ravb_probe(struct udevice *dev) > if (ret) > goto err_mdio_register; > > + ret = clk_enable(eth->refclk); > + if (ret) > + goto err_disable_clk; > + > ret = ravb_reset(dev); > if (ret) > goto err_mdio_reset; > @@ -533,6 +540,8 @@ static int ravb_probe(struct udevice *dev) > return 0; > > err_mdio_reset: > + clk_disable(eth->refclk); > +err_disable_clk: > clk_disable(ð->clk); > err_mdio_register: > mdio_free(mdiodev); > @@ -545,6 +554,7 @@ static int ravb_remove(struct udevice *dev) > { > struct ravb_priv *eth = dev_get_priv(dev); > > + clk_disable(eth->refclk); > clk_disable(ð->clk); > > free(eth->phydev); > -- > 2.25.1 > Reviewed-by: Ramon Fried