All of lore.kernel.org
 help / color / mirror / Atom feed
From: Barry Song <21cnbao@gmail.com>
To: hangdianqj@163.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	jslaby@suse.com, linux-serial@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr
Date: Tue, 28 Aug 2018 16:36:38 +0800	[thread overview]
Message-ID: <CAGsJ_4yLruLKnKc6kpr1JZ8BSSS4wAyvxeGm6A+S7-rLAZAVmg@mail.gmail.com> (raw)
In-Reply-To: <20180827144904.17226-1-hangdianqj@163.com>

jun qian <hangdianqj@163.com> 于2018年8月27日周一 下午10:49写道：
>
> Before the program enters the uart ISR, the local interrupt has been
> disabled by the system, so it's not appropriate to use spin_lock_irqsave
> interface in the ISR.
>
> Signed-off-by: jun qian <hangdianqj@163.com>

many discussions have been done with jun in wechat regarding this patch. and

Reviewed-by: Barry Song <21cnbao@gmail.com>

> ---
>  drivers/tty/serial/imx.c | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)
>

  reply	other threads:[~2018-08-28  8:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 14:49 [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr jun qian
2018-08-28  8:36 ` Barry Song [this message]
2018-10-01  8:52 ` Uwe Kleine-König
     [not found]   ` <5205c4b4.20a1.166326bb238.Coremail.hangdianqj@163.com>
2018-10-02 20:37     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGsJ_4yLruLKnKc6kpr1JZ8BSSS4wAyvxeGm6A+S7-rLAZAVmg@mail.gmail.com \
    --to=21cnbao@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hangdianqj@163.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.