From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F37C43603 for ; Tue, 10 Dec 2019 02:25:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED08320726 for ; Tue, 10 Dec 2019 02:25:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="rUHufGCp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbfLJCZx (ORCPT ); Mon, 9 Dec 2019 21:25:53 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:41010 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfLJCZx (ORCPT ); Mon, 9 Dec 2019 21:25:53 -0500 Received: by mail-lj1-f193.google.com with SMTP id h23so17990695ljc.8 for ; Mon, 09 Dec 2019 18:25:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hGHO2M5txop41S0pm7dDz8V62aTHzW6Nn2xeNv86ayQ=; b=rUHufGCp6EIf5KY8l3khfho84MdZP2MW0bW/pAL4vexbHeUugMe4fewy1MBR8OLfZB 9kEZg/8gBhBaPuYlaIRyIV2tEeBcZbUJKBpcnK9GnbrmVPHV5dO9CoaFP1b5FOYvCm6F HnLqHZxL/iepXS5n2ZwrBZIGAQaIYurJ81aF3d/Tz6yq2JtV3W7RPnf2sLp57DJ66l9q TRKr2b51NokEpFLSzN+433yT08nm3NfFsAOlLF7QxM1oRaz4nVM0tarfE2FKoptyHKgb 4jBQChzEQvvvuKCcUAlu7FzFZXURFn8FV2NJBujpKNbqTtgk2SekOZMALKbYLp2EnXIL wadg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hGHO2M5txop41S0pm7dDz8V62aTHzW6Nn2xeNv86ayQ=; b=A43xFjVvT8AweSLl0cpmeKEEu2h+6AAuTSdqYeuFJbiyq8ZTcobnB0zSrtgLx0SDPc jSlQg3Ez9uwFrBmYFlHLy8uyX/gXm+cwXZ9s7qPsqZD+7dtUHkpJ8S+XiwtLkTaS2fpo TnzyXcG/5+/mFG9mWLcjNShOnWcqj75RpHPYndIN0gXCTKh8SN6J0KXEbOwCb5MbClvY TSyOV6h9q2N+K893I8P6Q5rgdoSEoDIIi7fgzy0QQo57hyhAUgxvGs34FtmrHz98hwRm yuoi0dnUWSJHpFE4fPdDrFpEpO3B+4enFjmaPpjhQ05dUhMAX66O4JOOrjEUMAKoZsO9 trZg== X-Gm-Message-State: APjAAAUcxn1rQjxSKNUDkcDBLCFibfNDCyRMVk+cFKtagvE1zCndtm5f vwwn2/BFpGSMSlDcPNqx9iqSuzqqGuSUyyOPX/DW X-Google-Smtp-Source: APXvYqwaDMumZX1i/jL/oy22xRgwcKrHm1W5A0eXWF9G0Y2YJ22oQrnCcbln71FUczdl/ECUsqJi5ZNyZeKGBdsGNUI= X-Received: by 2002:a2e:89da:: with SMTP id c26mr19242792ljk.54.1575944751067; Mon, 09 Dec 2019 18:25:51 -0800 (PST) MIME-Version: 1.0 References: <20191210124047.40852ade@canb.auug.org.au> In-Reply-To: <20191210124047.40852ade@canb.auug.org.au> From: Paul Moore Date: Mon, 9 Dec 2019 21:25:40 -0500 Message-ID: Subject: Re: linux-next: build failure after merge of the selinux tree To: Stephen Rothwell Cc: Linux Next Mailing List , Linux Kernel Mailing List , Stephen Smalley , James Morris Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 9, 2019 at 8:40 PM Stephen Rothwell wrote: > Hi all, > > After merging the selinux tree, today's linux-next build (powerpc > pseries_le_defconfig) failed like this: > > ld: security/lsm_audit.o:(.toc+0x0): undefined reference to `lockdown_reasons' > > Caused by commit > > 59438b46471a ("security,lockdown,selinux: implement SELinux lockdown") > > CONFIG_SECURITY is not set for this build, but CONFIG_AUDIT is set. > > I applied the following hack for today: > > From: Stephen Rothwell > Date: Tue, 10 Dec 2019 12:28:16 +1100 > Subject: [PATCH] security,lockdown,selinux: hack for !CONFIG_SECURITY > > Signed-off-by: Stephen Rothwell > --- > security/lsm_audit.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/security/lsm_audit.c b/security/lsm_audit.c > index 2d2bf49016f4..f97a3337f307 100644 > --- a/security/lsm_audit.c > +++ b/security/lsm_audit.c > @@ -427,8 +427,10 @@ static void dump_common_audit_data(struct audit_buffer *ab, > a->u.ibendport->port); > break; > case LSM_AUDIT_DATA_LOCKDOWN: > +#ifdef CONFIG_SECURITY > audit_log_format(ab, " lockdown_reason="); > audit_log_string(ab, lockdown_reasons[a->u.reason]); > +#endif > break; > } /* switch (a->type) */ > } Thanks for letting me know. I'm sorry about that Stephen, I'll send out a little more generic patch in just a minute as a RFC. -- paul moore www.paul-moore.com