From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com ([209.85.167.65]:45298 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726499AbeJOXZu (ORCPT ); Mon, 15 Oct 2018 19:25:50 -0400 Received: by mail-lf1-f65.google.com with SMTP id v22-v6so2629562lfe.12 for ; Mon, 15 Oct 2018 08:40:03 -0700 (PDT) MIME-Version: 1.0 References: <20180904160632.21210-1-jack@suse.cz> <20180904160632.21210-13-jack@suse.cz> <20181009074023.GD11150@quack2.suse.cz> <20181011113937.GD8418@quack2.suse.cz> <166655f3fa8.2781.85c95baa4474aabc7814e68940a78392@paul-moore.com> <20181015100403.GA30927@quack2.suse.cz> In-Reply-To: <20181015100403.GA30927@quack2.suse.cz> From: Paul Moore Date: Mon, 15 Oct 2018 11:39:51 -0400 Message-ID: Subject: Re: [PATCH 12/11 TESTSUITE] audit_testsuite: Add stress test for tree watches To: jack@suse.cz Cc: viro@zeniv.linux.org.uk, linux-audit@redhat.com, linux-fsdevel@vger.kernel.org, rgb@redhat.com, amir73il@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Oct 15, 2018 at 6:04 AM Jan Kara wrote: > On Thu 11-10-18 19:03:53, Paul Moore wrote: > > On October 11, 2018 7:39:39 AM Jan Kara wrote: > > > On Wed 10-10-18 02:43:46, Paul Moore wrote: > > >> On Tue, Oct 9, 2018 at 3:40 AM Jan Kara wrote: > > >>> On Fri 05-10-18 17:06:22, Paul Moore wrote: > > >>>> On Tue, Sep 4, 2018 at 12:06 PM Jan Kara wrote: > > >>>>> Add stress test for stressing audit tree watches by adding and deleting > > >>>>> rules while events are generated and watched filesystems are mounted and > > >>>>> unmounted in parallel. > > >>>>> > > >>>>> Signed-off-by: Jan Kara > > >>>>> --- > > >>>>> tests/stress_tree/Makefile | 8 +++ > > >>>>> tests/stress_tree/test | 171 +++++++++++++++++++++++++++++++++++++++++++++ > > >>>>> 2 files changed, 179 insertions(+) > > >>>>> create mode 100644 tests/stress_tree/Makefile > > >>>>> create mode 100755 tests/stress_tree/test > > >>>> > > >>>> No commentary on the test itself, other than perhaps it should live > > >>>> under test_manual/, but in running the tests in a loop today I am > > >>>> reliably able to panic my test kernel after ~30m or so. > > >>> > > >>> Interesting. How do you run the test? > > >> > > >> Nothing fancy, just a simple bash loop: > > >> > > >> # cd tests/stress_tree > > >> # while ./test; do /bin/true; done > > > > > > OK, I did succeed in reproducing some problems with my patches - once I was > > > able to trigger a livelock and following softlockup warning - this is > > > actually a problem introduced by my patches, and once a use after free > > > issue (not sure what that was since after I've added some debugging I > > > wasn't able to trigger it anymore). Anyway, I'll try more after fixing the > > > livelock. Do you want me to add fixes on top of my series or just fixup the > > > original series? > > > > Since these are pretty serious bugs, and I try to avoid merging > > known-broken patches which will go up to Linus, why don't you go ahead > > and respin the patchset with the new fixes included. You can also use > > the opportunity to squash in the rename patch and fix that mid-patchset > > compilation problem that I fixed up during the merge. > > OK, I'm now testing a version with the softlockup fixed and some locking > around untag_chunk() simplified when I had to meddle with that anyway. I'll > see if I can hit further failures... Thanks for the update, let me know how the testing goes ... -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH 12/11 TESTSUITE] audit_testsuite: Add stress test for tree watches Date: Mon, 15 Oct 2018 11:39:51 -0400 Message-ID: References: <20180904160632.21210-1-jack@suse.cz> <20180904160632.21210-13-jack@suse.cz> <20181009074023.GD11150@quack2.suse.cz> <20181011113937.GD8418@quack2.suse.cz> <166655f3fa8.2781.85c95baa4474aabc7814e68940a78392@paul-moore.com> <20181015100403.GA30927@quack2.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (ext-mx05.extmail.prod.ext.phx2.redhat.com [10.5.110.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 06CE15D6B5 for ; Mon, 15 Oct 2018 15:40:06 +0000 (UTC) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E73E3B7F for ; Mon, 15 Oct 2018 15:40:04 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id y10-v6so14449643lfj.1 for ; Mon, 15 Oct 2018 08:40:04 -0700 (PDT) In-Reply-To: <20181015100403.GA30927@quack2.suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: jack@suse.cz Cc: linux-fsdevel@vger.kernel.org, rgb@redhat.com, linux-audit@redhat.com, amir73il@gmail.com, viro@zeniv.linux.org.uk List-Id: linux-audit@redhat.com On Mon, Oct 15, 2018 at 6:04 AM Jan Kara wrote: > On Thu 11-10-18 19:03:53, Paul Moore wrote: > > On October 11, 2018 7:39:39 AM Jan Kara wrote: > > > On Wed 10-10-18 02:43:46, Paul Moore wrote: > > >> On Tue, Oct 9, 2018 at 3:40 AM Jan Kara wrote: > > >>> On Fri 05-10-18 17:06:22, Paul Moore wrote: > > >>>> On Tue, Sep 4, 2018 at 12:06 PM Jan Kara wrote: > > >>>>> Add stress test for stressing audit tree watches by adding and deleting > > >>>>> rules while events are generated and watched filesystems are mounted and > > >>>>> unmounted in parallel. > > >>>>> > > >>>>> Signed-off-by: Jan Kara > > >>>>> --- > > >>>>> tests/stress_tree/Makefile | 8 +++ > > >>>>> tests/stress_tree/test | 171 +++++++++++++++++++++++++++++++++++++++++++++ > > >>>>> 2 files changed, 179 insertions(+) > > >>>>> create mode 100644 tests/stress_tree/Makefile > > >>>>> create mode 100755 tests/stress_tree/test > > >>>> > > >>>> No commentary on the test itself, other than perhaps it should live > > >>>> under test_manual/, but in running the tests in a loop today I am > > >>>> reliably able to panic my test kernel after ~30m or so. > > >>> > > >>> Interesting. How do you run the test? > > >> > > >> Nothing fancy, just a simple bash loop: > > >> > > >> # cd tests/stress_tree > > >> # while ./test; do /bin/true; done > > > > > > OK, I did succeed in reproducing some problems with my patches - once I was > > > able to trigger a livelock and following softlockup warning - this is > > > actually a problem introduced by my patches, and once a use after free > > > issue (not sure what that was since after I've added some debugging I > > > wasn't able to trigger it anymore). Anyway, I'll try more after fixing the > > > livelock. Do you want me to add fixes on top of my series or just fixup the > > > original series? > > > > Since these are pretty serious bugs, and I try to avoid merging > > known-broken patches which will go up to Linus, why don't you go ahead > > and respin the patchset with the new fixes included. You can also use > > the opportunity to squash in the rename patch and fix that mid-patchset > > compilation problem that I fixed up during the merge. > > OK, I'm now testing a version with the softlockup fixed and some locking > around untag_chunk() simplified when I had to meddle with that anyway. I'll > see if I can hit further failures... Thanks for the update, let me know how the testing goes ... -- paul moore www.paul-moore.com