From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933995AbdCWUcF (ORCPT ); Thu, 23 Mar 2017 16:32:05 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:33418 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933090AbdCWUcE (ORCPT ); Thu, 23 Mar 2017 16:32:04 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <66451d7e-f9ff-1d53-e919-d237a24ca8a2@users.sourceforge.net> References: <66451d7e-f9ff-1d53-e919-d237a24ca8a2@users.sourceforge.net> From: Paul Moore Date: Thu, 23 Mar 2017 16:32:02 -0400 Message-ID: Subject: Re: [PATCH 04/46] selinux: Use kmalloc_array() in hashtab_create() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:01 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 12:06:13 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/hashtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c > index 2cc496149842..dc99fff64ecb 100644 > --- a/security/selinux/ss/hashtab.c > +++ b/security/selinux/ss/hashtab.c > @@ -24,7 +24,7 @@ struct hashtab *hashtab_create(u32 (*hash_value)(struct hashtab *h, const void * > p->nel = 0; > p->hash_value = hash_value; > p->keycmp = keycmp; > - p->htable = kmalloc(sizeof(*(p->htable)) * size, GFP_KERNEL); > + p->htable = kmalloc_array(size, sizeof(*p->htable), GFP_KERNEL); > if (p->htable == NULL) { > kfree(p); > return NULL; > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Thu, 23 Mar 2017 20:32:02 +0000 Subject: Re: [PATCH 04/46] selinux: Use kmalloc_array() in hashtab_create() Message-Id: List-Id: References: <66451d7e-f9ff-1d53-e919-d237a24ca8a2@users.sourceforge.net> In-Reply-To: <66451d7e-f9ff-1d53-e919-d237a24ca8a2@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org On Sun, Jan 15, 2017 at 10:01 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 12:06:13 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/hashtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c > index 2cc496149842..dc99fff64ecb 100644 > --- a/security/selinux/ss/hashtab.c > +++ b/security/selinux/ss/hashtab.c > @@ -24,7 +24,7 @@ struct hashtab *hashtab_create(u32 (*hash_value)(struct hashtab *h, const void * > p->nel = 0; > p->hash_value = hash_value; > p->keycmp = keycmp; > - p->htable = kmalloc(sizeof(*(p->htable)) * size, GFP_KERNEL); > + p->htable = kmalloc_array(size, sizeof(*p->htable), GFP_KERNEL); > if (p->htable = NULL) { > kfree(p); > return NULL; > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Thu, 23 Mar 2017 16:32:02 -0400 Subject: [PATCH 04/46] selinux: Use kmalloc_array() in hashtab_create() In-Reply-To: <66451d7e-f9ff-1d53-e919-d237a24ca8a2@users.sourceforge.net> References: <66451d7e-f9ff-1d53-e919-d237a24ca8a2@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Jan 15, 2017 at 10:01 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 12:06:13 +0100 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/hashtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c > index 2cc496149842..dc99fff64ecb 100644 > --- a/security/selinux/ss/hashtab.c > +++ b/security/selinux/ss/hashtab.c > @@ -24,7 +24,7 @@ struct hashtab *hashtab_create(u32 (*hash_value)(struct hashtab *h, const void * > p->nel = 0; > p->hash_value = hash_value; > p->keycmp = keycmp; > - p->htable = kmalloc(sizeof(*(p->htable)) * size, GFP_KERNEL); > + p->htable = kmalloc_array(size, sizeof(*p->htable), GFP_KERNEL); > if (p->htable == NULL) { > kfree(p); > return NULL; > -- > 2.11.0 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html