From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756312AbdCWVW2 (ORCPT ); Thu, 23 Mar 2017 17:22:28 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:33813 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755092AbdCWVW0 (ORCPT ); Thu, 23 Mar 2017 17:22:26 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <1370e095-265d-9ca5-8184-b975fc75ead7@users.sourceforge.net> References: <1370e095-265d-9ca5-8184-b975fc75ead7@users.sourceforge.net> From: Paul Moore Date: Thu, 23 Mar 2017 17:22:24 -0400 Message-ID: Subject: Re: [PATCH 08/46] selinux: Delete an unnecessary return statement in policydb_destroy() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:06 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 14:00:02 +0100 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: void function return statements are not generally useful > > Thus remove such a statement in the affected function. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 2 -- > 1 file changed, 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 4d4ba1ad910d..fe8992382a71 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -878,8 +878,6 @@ void policydb_destroy(struct policydb *p) > ebitmap_destroy(&p->filename_trans_ttypes); > ebitmap_destroy(&p->policycaps); > ebitmap_destroy(&p->permissive_map); > - > - return; > } > > /* > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Thu, 23 Mar 2017 21:22:24 +0000 Subject: Re: [PATCH 08/46] selinux: Delete an unnecessary return statement in policydb_destroy() Message-Id: List-Id: References: <1370e095-265d-9ca5-8184-b975fc75ead7@users.sourceforge.net> In-Reply-To: <1370e095-265d-9ca5-8184-b975fc75ead7@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org On Sun, Jan 15, 2017 at 10:06 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 14:00:02 +0100 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: void function return statements are not generally useful > > Thus remove such a statement in the affected function. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 2 -- > 1 file changed, 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 4d4ba1ad910d..fe8992382a71 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -878,8 +878,6 @@ void policydb_destroy(struct policydb *p) > ebitmap_destroy(&p->filename_trans_ttypes); > ebitmap_destroy(&p->policycaps); > ebitmap_destroy(&p->permissive_map); > - > - return; > } > > /* > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Thu, 23 Mar 2017 17:22:24 -0400 Subject: [PATCH 08/46] selinux: Delete an unnecessary return statement in policydb_destroy() In-Reply-To: <1370e095-265d-9ca5-8184-b975fc75ead7@users.sourceforge.net> References: <1370e095-265d-9ca5-8184-b975fc75ead7@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Jan 15, 2017 at 10:06 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 14:00:02 +0100 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: void function return statements are not generally useful > > Thus remove such a statement in the affected function. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 2 -- > 1 file changed, 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 4d4ba1ad910d..fe8992382a71 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -878,8 +878,6 @@ void policydb_destroy(struct policydb *p) > ebitmap_destroy(&p->filename_trans_ttypes); > ebitmap_destroy(&p->policycaps); > ebitmap_destroy(&p->permissive_map); > - > - return; > } > > /* > -- > 2.11.0 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html