From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C08E6C04FF3 for ; Fri, 21 May 2021 20:20:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5C28613EC for ; Fri, 21 May 2021 20:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231239AbhEUUVe (ORCPT ); Fri, 21 May 2021 16:21:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230409AbhEUUVM (ORCPT ); Fri, 21 May 2021 16:21:12 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33B06C06138A for ; Fri, 21 May 2021 13:19:39 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id et19so25177402ejc.4 for ; Fri, 21 May 2021 13:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HdFvc7fptOa2U/lZENFnDrQgRiZEVZLgg6sKDbnUzyg=; b=aG3bBjgVeg6slH6NXO/4ixHXPGXGELFb98HmduPBE+sk25y//o2bRRKcaARiDg1p7r Ozu6MToPEGXm2IsakqX3NYJXJMtB2pgtfkj0HRlt/O3XV6FPK+ZmafBVMw397fb3siBV Ym6c6OhgQ/BbBPgcaUrSg/ObB813tXqU6lqYivpVGYTSEyEAHMHc+9ExoYvMQSqhYrcp qObmfIZLSwbX29/TiIs9l7krP5U/BWdae6GVoJKcyPw1I+PrcjPYoDRf4JWY0JWBa5z2 ArQYV3pvf/0S/Vh55fioWORYr/OIioK3LtSKT9AZIiY9Sd3ggrtQ9uqaKsfmhj95+znj hpOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HdFvc7fptOa2U/lZENFnDrQgRiZEVZLgg6sKDbnUzyg=; b=Tu+IDqVxqm/cYcmM7Mrkrt4GO8grwsJaPlYirGrLTERdJVbrqwlO5woU5hi6WlKsKL a95KhDwDNN5I+nH40M5dKoa0umvhfCwNFNo+fY7yRLDlrr4crMRweWNEYW8qT2YZDd2T kQrdvuUVLv25vv3RCNvipwIU1DXolekTNS6uDhljGdln13nZiIfaw2cb+xOW9xfemZzM 3Y7Y5skanpPC/tSxc0HiqMjWXSWAnCFlcQDblmB7TYqsagXzaVjK5IPsaPf4sTwCbBw8 av0G1gZBvbkTcuP8wgFETzv2wX3SKqGAOXlzyn6LaItmxUYNZlt+/C/rucgnDCCgSQ1V U11Q== X-Gm-Message-State: AOAM533otCHJFL818oxoY3jTunQs9WYK2JU+C9wcO9TngjgzE7h6TDIK yLAvGRmzwReAWJ3cXq8yB0nXCUQLfbo98pox+2IVw6GeRA== X-Google-Smtp-Source: ABdhPJz6RI+DFTaAZKp1yYFkI36BapBPZgGOSGg8oZyqUJOh8WRI4wf9Oyp08Zz6Th80x+gDaI37+ox3yh/PXrCSCRM= X-Received: by 2002:a17:907:1749:: with SMTP id lf9mr12367624ejc.178.1621628377771; Fri, 21 May 2021 13:19:37 -0700 (PDT) MIME-Version: 1.0 References: <20210513200807.15910-1-casey@schaufler-ca.com> <20210513200807.15910-22-casey@schaufler-ca.com> In-Reply-To: <20210513200807.15910-22-casey@schaufler-ca.com> From: Paul Moore Date: Fri, 21 May 2021 16:19:26 -0400 Message-ID: Subject: Re: [PATCH v26 21/25] audit: add support for non-syscall auxiliary records To: Casey Schaufler Cc: casey.schaufler@intel.com, James Morris , linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-audit@redhat.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, Stephen Smalley , linux-kernel@vger.kernel.org, Richard Guy Briggs Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 13, 2021 at 4:31 PM Casey Schaufler wrote: > > Standalone audit records have the timestamp and serial number generated > on the fly and as such are unique, making them standalone. This new > function audit_alloc_local() generates a local audit context that will > be used only for a standalone record and its auxiliary record(s). The > context is discarded immediately after the local associated records are > produced. > > Signed-off-by: Richard Guy Briggs > Signed-off-by: Casey Schaufler > Cc: linux-audit@redhat.com > To: Richard Guy Briggs > --- > include/linux/audit.h | 8 ++++++++ > kernel/audit.h | 1 + > kernel/auditsc.c | 33 ++++++++++++++++++++++++++++----- > 3 files changed, 37 insertions(+), 5 deletions(-) At some point I suspect we will need to add filtering for these "local" records, but that is a problem for another day. Acked-by: Paul Moore -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F13C4707F for ; Fri, 21 May 2021 20:19:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 811B8613EE for ; Fri, 21 May 2021 20:19:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 811B8613EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=paul-moore.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-DmRVbQHNPLGgU_rARhSKVA-1; Fri, 21 May 2021 16:19:47 -0400 X-MC-Unique: DmRVbQHNPLGgU_rARhSKVA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54A8F100945E; Fri, 21 May 2021 20:19:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41CCC5D705; Fri, 21 May 2021 20:19:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 23FD8180B463; Fri, 21 May 2021 20:19:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14LKJfHX012271 for ; Fri, 21 May 2021 16:19:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5C7F720BB90C; Fri, 21 May 2021 20:19:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 581B720BB912 for ; Fri, 21 May 2021 20:19:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 40407185A79C for ; Fri, 21 May 2021 20:19:41 +0000 (UTC) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-cADMedLAPlelfq-JIYImEA-1; Fri, 21 May 2021 16:19:39 -0400 X-MC-Unique: cADMedLAPlelfq-JIYImEA-1 Received: by mail-ej1-f50.google.com with SMTP id lg14so32202362ejb.9 for ; Fri, 21 May 2021 13:19:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HdFvc7fptOa2U/lZENFnDrQgRiZEVZLgg6sKDbnUzyg=; b=W+RP7P+fLNuAiHXqkBJ50Z7B4MJECcdVPK4td4uGNd1p52YV4IRSznBCYf6Y9jbILj krcLKv6eyKx3hxxhadIGlO8iGDnzUepbjKzW4B80Pymzgv7tqh4AxdCj5y+TCSYuChJg 3KN9uWEe8VzORa1ghV/LdKn1zc0twl5FSIEFQl7zaHcniaqFt2sRkfzv/FgQvKuFz2rk KLrBBG6bq7mrMm164vJ8Hp+kBJIpumys701HwPz6TSWATa47muY3SqZVXzQyrJawQ04X XluAhNu0fRsK6V4opbpet3U7/dcLpA78S0HN8c4MPSEiOa9iN4w+OfmCD6pEliWvO0b8 R+QA== X-Gm-Message-State: AOAM532pVAAWzO5q/UKOvd4MgxCiokJ5hyLGtSjLFLsqCHo1irKGbTCr XaJpd97+6sILNNDYM81mEo7+iecuuFaNA2a239T3 X-Google-Smtp-Source: ABdhPJz6RI+DFTaAZKp1yYFkI36BapBPZgGOSGg8oZyqUJOh8WRI4wf9Oyp08Zz6Th80x+gDaI37+ox3yh/PXrCSCRM= X-Received: by 2002:a17:907:1749:: with SMTP id lf9mr12367624ejc.178.1621628377771; Fri, 21 May 2021 13:19:37 -0700 (PDT) MIME-Version: 1.0 References: <20210513200807.15910-1-casey@schaufler-ca.com> <20210513200807.15910-22-casey@schaufler-ca.com> In-Reply-To: <20210513200807.15910-22-casey@schaufler-ca.com> From: Paul Moore Date: Fri, 21 May 2021 16:19:26 -0400 Message-ID: Subject: Re: [PATCH v26 21/25] audit: add support for non-syscall auxiliary records To: Casey Schaufler X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: linux-audit@redhat.com Cc: john.johansen@canonical.com, selinux@vger.kernel.org, Richard Guy Briggs , James Morris , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, casey.schaufler@intel.com, Stephen Smalley X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, May 13, 2021 at 4:31 PM Casey Schaufler wrote: > > Standalone audit records have the timestamp and serial number generated > on the fly and as such are unique, making them standalone. This new > function audit_alloc_local() generates a local audit context that will > be used only for a standalone record and its auxiliary record(s). The > context is discarded immediately after the local associated records are > produced. > > Signed-off-by: Richard Guy Briggs > Signed-off-by: Casey Schaufler > Cc: linux-audit@redhat.com > To: Richard Guy Briggs > --- > include/linux/audit.h | 8 ++++++++ > kernel/audit.h | 1 + > kernel/auditsc.c | 33 ++++++++++++++++++++++++++++----- > 3 files changed, 37 insertions(+), 5 deletions(-) At some point I suspect we will need to add filtering for these "local" records, but that is a problem for another day. Acked-by: Paul Moore -- paul moore www.paul-moore.com -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit