From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754483AbdC2PkT (ORCPT ); Wed, 29 Mar 2017 11:40:19 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:32957 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754345AbdC2PkP (ORCPT ); Wed, 29 Mar 2017 11:40:15 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <2c370330-a80c-9879-2013-3a99a21dc06d@users.sourceforge.net> References: <2c370330-a80c-9879-2013-3a99a21dc06d@users.sourceforge.net> From: Paul Moore Date: Wed, 29 Mar 2017 11:40:13 -0400 Message-ID: Subject: Re: [PATCH 40/46] selinux: Return directly after a failed kzalloc() in roles_init() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:40 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 12:10:09 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 8b9ed3f1b132..ccc146bfd4c2 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -178,10 +178,9 @@ static int roles_init(struct policydb *p) > int rc; > struct role_datum *role; > > - rc = -ENOMEM; > role = kzalloc(sizeof(*role), GFP_KERNEL); > if (!role) > - goto out; > + return -ENOMEM; > > rc = -EINVAL; > role->value = ++p->p_roles.nprim; > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Date: Wed, 29 Mar 2017 15:40:13 +0000 Subject: Re: [PATCH 40/46] selinux: Return directly after a failed kzalloc() in roles_init() Message-Id: List-Id: References: <2c370330-a80c-9879-2013-3a99a21dc06d@users.sourceforge.net> In-Reply-To: <2c370330-a80c-9879-2013-3a99a21dc06d@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-security-module@vger.kernel.org On Sun, Jan 15, 2017 at 10:40 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 12:10:09 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 8b9ed3f1b132..ccc146bfd4c2 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -178,10 +178,9 @@ static int roles_init(struct policydb *p) > int rc; > struct role_datum *role; > > - rc = -ENOMEM; > role = kzalloc(sizeof(*role), GFP_KERNEL); > if (!role) > - goto out; > + return -ENOMEM; > > rc = -EINVAL; > role->value = ++p->p_roles.nprim; > -- > 2.11.0 > -- paul moore www.paul-moore.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: paul@paul-moore.com (Paul Moore) Date: Wed, 29 Mar 2017 11:40:13 -0400 Subject: [PATCH 40/46] selinux: Return directly after a failed kzalloc() in roles_init() In-Reply-To: <2c370330-a80c-9879-2013-3a99a21dc06d@users.sourceforge.net> References: <2c370330-a80c-9879-2013-3a99a21dc06d@users.sourceforge.net> Message-ID: To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Sun, Jan 15, 2017 at 10:40 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 15 Jan 2017 12:10:09 +0100 > > Return directly after a call of the function "kzalloc" failed > at the beginning. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 8b9ed3f1b132..ccc146bfd4c2 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -178,10 +178,9 @@ static int roles_init(struct policydb *p) > int rc; > struct role_datum *role; > > - rc = -ENOMEM; > role = kzalloc(sizeof(*role), GFP_KERNEL); > if (!role) > - goto out; > + return -ENOMEM; > > rc = -EINVAL; > role->value = ++p->p_roles.nprim; > -- > 2.11.0 > -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html