From: Greg Thelen <gthelen@google.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: ak@linux.intel.com, Steven Rostedt <rostedt@goodmis.org>,
Dave Chinner <david@fromorbit.com>,
dchinner@redhat.com, linux-xfs@vger.kernel.org,
Linux MM <linux-mm@kvack.org>,
osandov@fb.com
Subject: Re: [PATCH] Makefile: Fix backtrace breakage
Date: Wed, 20 Jun 2018 22:56:04 -0700 [thread overview]
Message-ID: <CAHH2K0YqWswbfKdi915PJToJUngAbdKqN_2cgtG9CzS1FJRHdg@mail.gmail.com> (raw)
In-Reply-To: <201806210547.w5L5l5Mh029257@www262.sakura.ne.jp>
On Wed, Jun 20, 2018 at 10:47 PM Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
>
> From 7208bf13827fa7c7d6196ee20f7678eff0d29b36 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Thu, 21 Jun 2018 14:15:10 +0900
> Subject: [PATCH] Makefile: Fix backtrace breakage
>
> Dave Chinner noticed that backtrace part is missing in a lockdep report.
>
> [ 68.760085] the existing dependency chain (in reverse order) is:
> [ 69.258520]
> [ 69.258520] -> #1 (fs_reclaim){+.+.}:
> [ 69.623516]
> [ 69.623516] -> #0 (sb_internal){.+.+}:
> [ 70.152322]
> [ 70.152322] other info that might help us debug this:
>
> Since the kernel was using CONFIG_FTRACE_MCOUNT_RECORD=n &&
> CONFIG_FRAME_POINTER=n, objtool_args was not properly calculated
> due to incorrectly placed "endif" in commit 96f60dfa5819a065 ("trace:
> Use -mcount-record for dynamic ftrace").
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Dave Chinner <david@fromorbit.com>
> Cc: Andi Kleen <ak@linux.intel.com>
> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
This looks similar to https://lkml.org/lkml/2018/6/8/545
> ---
> scripts/Makefile.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 34d9e9c..55f22f4 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -239,6 +239,7 @@ cmd_record_mcount = \
> "$(CC_FLAGS_FTRACE)" ]; then \
> $(sub_cmd_record_mcount) \
> fi;
> +endif
> endif # CONFIG_FTRACE_MCOUNT_RECORD
>
> ifdef CONFIG_STACK_VALIDATION
> @@ -263,7 +264,6 @@ ifneq ($(RETPOLINE_CFLAGS),)
> objtool_args += --retpoline
> endif
> endif
> -endif
>
>
> ifdef CONFIG_MODVERSIONS
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2018-06-21 5:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 11:25 xfs: circular locking dependency between fs_reclaim and sb_internal [kernel 4.18] Tetsuo Handa
2018-06-20 23:35 ` Dave Chinner
2018-06-21 0:15 ` Dave Chinner
2018-06-21 5:47 ` [PATCH] Makefile: Fix backtrace breakage Tetsuo Handa
2018-06-21 5:47 ` Tetsuo Handa
2018-06-21 5:56 ` Greg Thelen [this message]
2018-06-21 20:48 ` Andi Kleen
2018-06-21 21:30 ` Steven Rostedt
2018-06-21 21:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHH2K0YqWswbfKdi915PJToJUngAbdKqN_2cgtG9CzS1FJRHdg@mail.gmail.com \
--to=gthelen@google.com \
--cc=ak@linux.intel.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@fb.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.