From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bpf-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id F17BEC433F5
	for <bpf@archiver.kernel.org>; Thu,  3 Feb 2022 16:07:50 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1352060AbiBCQHu (ORCPT <rfc822;bpf@archiver.kernel.org>);
        Thu, 3 Feb 2022 11:07:50 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52262 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1349017AbiBCQHt (ORCPT <rfc822;bpf@vger.kernel.org>);
        Thu, 3 Feb 2022 11:07:49 -0500
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 357F3C06173B
        for <bpf@vger.kernel.org>; Thu,  3 Feb 2022 08:07:49 -0800 (PST)
Received: by mail-lf1-x132.google.com with SMTP id x23so7116374lfc.0
        for <bpf@vger.kernel.org>; Thu, 03 Feb 2022 08:07:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=kinvolk.io; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=U8C94DRdIZGAroYerjdGjoFnF/GC8q7KFZokkTOxUZs=;
        b=gDpiugQBFCZYvMpY47vTeHN5scolnvYBOB4bSGLZnNX3gB7Mf/6B1iTEQQ3UCu7D1K
         jw1x3PlIPKkZ5sv4//YSSWYiMc59xSiVaTDkx8PMqwhfbC292fbKu0dy8NVXPuSOY3jj
         N5alIlpk1mTLEtAfHFIjo9SS807hGfxRYRFtU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=U8C94DRdIZGAroYerjdGjoFnF/GC8q7KFZokkTOxUZs=;
        b=SrSUBXOpXQBBupf0b+s7oHXKteXQYAn1fYQG0XRXbWXo/wU+bDWES4IfkngpapeJLy
         idQIbdY5smwA69kRpYkJfXabbs4klS9k6NoxCbaNQ+ZgIXMfGGeS10S+70L6nKMez5Uw
         LadHm/xwjMsPk20nObjF8lBZxy/Ado4mU/oZQE3qFMesIvMFYxkV4DULvec5CWVXLv8R
         eZmOl+df21QeDfjp37uyGcXsDZFRYs9VcThSGKVbGKk09swt9cDbyHpTXu0H+laCLo90
         ZcyMyeu4gvds80o0/S8y92RGC3FCOWjjUxSvVnr+DHSJQi52u2oWuAadWFRr/XIAgC1/
         hhZw==
X-Gm-Message-State: AOAM532NBsp+tCEborxTqWyVon5Gsvp6tL26qgWie0nYke426V9Tmd3K
        slmIj/KoeAi8Z5jkX/YV3Q3zP+vwrfBzvsbXKQDXMA==
X-Google-Smtp-Source: ABdhPJwWN6XUZynoQwdD2Uk4RznsvF2cwOFpad/pcBwo8RfeX5K/zELXa30kkC2ev6EIldXn8xHa8+DW+ArbBJaqW00=
X-Received: by 2002:a05:6512:2342:: with SMTP id p2mr27218556lfu.382.1643904467469;
 Thu, 03 Feb 2022 08:07:47 -0800 (PST)
MIME-Version: 1.0
References: <20220128223312.1253169-1-mauricio@kinvolk.io> <20220128223312.1253169-4-mauricio@kinvolk.io>
 <CAEf4BzYW54DRsJxgeXKcHPLSXs45DsCVKumV7WNd2UH=1G4MPA@mail.gmail.com>
In-Reply-To: <CAEf4BzYW54DRsJxgeXKcHPLSXs45DsCVKumV7WNd2UH=1G4MPA@mail.gmail.com>
From:   =?UTF-8?Q?Mauricio_V=C3=A1squez_Bernal?= <mauricio@kinvolk.io>
Date:   Thu, 3 Feb 2022 11:07:36 -0500
Message-ID: <CAHap4zumCF_pC6-J+dpSiT+qzZVt=scb-AMdpcFSFfz6iSx1HQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next v5 3/9] bpftool: Implement btf_save_raw()
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc:     Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Quentin Monnet <quentin@isovalent.com>,
        Rafael David Tinoco <rafaeldtinoco@gmail.com>,
        Lorenzo Fontana <lorenzo.fontana@elastic.co>,
        Leonardo Di Donato <leonardo.didonato@elastic.co>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <bpf.vger.kernel.org>
X-Mailing-List: bpf@vger.kernel.org

> The logic looks good, but you need to merge adding this static
> function with the patch that's using that static function. Otherwise
> you will break bisectability because compiler will warn about unused
> static function.
>

It only emits a warning but it compiles fine. Is that still an issue?