From: Linus Torvalds <torvalds@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linux-MM <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] Page cache for 5.17
Date: Wed, 12 Jan 2022 12:44:01 -0800 [thread overview]
Message-ID: <CAHk-=wh3M_BHhGJynEcX4O1WDwu5e7DY9ZMeK7kcL37y3M25xQ@mail.gmail.com> (raw)
In-Reply-To: <YdyuuBCe4EPmr3k2@casper.infradead.org>
On Mon, Jan 10, 2022 at 2:10 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> Convert much of the page cache to use folios
So I note that you tend to still sometimes use 'page' in the commit
messages and leave them in the comments.
For example:
> filemap: Drop the refcount while waiting for page lock
or the comment (and function name) in next_uptodate_page():
/* Has the page moved or been split? */
and obviously also function names for first_map_page()/next_map_page().
I don't mind, but it's an odd kind of inconsistency, where the code
all uses 'folio', but then the function name and comment wasn't
updated.
Sometimes you _do_ update the function name, sometimes you don't.
Maybe there's a pattern I'm not seeing.
Anyway, regardless of that small nit - pulled.
Linus
next prev parent reply other threads:[~2022-01-12 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 22:10 [GIT PULL] Page cache for 5.17 Matthew Wilcox
2022-01-12 20:44 ` Linus Torvalds [this message]
2022-01-12 21:07 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh3M_BHhGJynEcX4O1WDwu5e7DY9ZMeK7kcL37y3M25xQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.