All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Jörg Otte" <jrg.otte@gmail.com>,
	linux-efi <linux-efi@vger.kernel.org>,
	"Arvind Sankar" <nivedita@alum.mit.edu>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: Kernel V5.7-rc1 doesn't boot (EFI?)
Date: Tue, 14 Apr 2020 11:27:04 -0700	[thread overview]
Message-ID: <CAHk-=wi-s0mmLAVg-aSmNU55=cE8ES7mC=Mc3Wn62P8W9VjY-A@mail.gmail.com> (raw)
In-Reply-To: <CAMj1kXGuMjHi=E6cVGGpwrKF_-KXcj0VRcvAdFS_vmwV7PudCQ@mail.gmail.com>

On Tue, Apr 14, 2020 at 3:50 AM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> [*] GRUB on x86 turns out not to zero initialize BSS when it invokes
> the EFI stub as a PE/COFF executable

The fix seems to be to put all globals in the .data section, even if
they don't have initializers.

That seems very fragile. Very easy to forget to not declare some
static variable with __efistub_global.

Could we not make the EFI stub code zero out the BSS itself? Perhaps
setting a warning flag (for a later printout) if it wasn't already
zero, so that people could point fingers are buggy loaders..

             Linus

  parent reply	other threads:[~2020-04-14 18:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 10:40 Kernel V5.7-rc1 doesn't boot (EFI?) Jörg Otte
2020-04-14 10:50 ` Ard Biesheuvel
2020-04-14 16:32   ` Jörg Otte
2020-04-14 16:35     ` Ard Biesheuvel
2020-04-15  7:45       ` Ingo Molnar
2020-04-15  8:35       ` Jörg Otte
2020-04-15  9:58         ` Ard Biesheuvel
2020-04-14 18:27   ` Linus Torvalds [this message]
2020-04-14 18:32     ` Ard Biesheuvel
2020-04-14 18:44       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wi-s0mmLAVg-aSmNU55=cE8ES7mC=Mc3Wn62P8W9VjY-A@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=jrg.otte@gmail.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nivedita@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.