From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F9D7C433E0 for ; Sun, 27 Dec 2020 23:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46A83224F9 for ; Sun, 27 Dec 2020 23:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726340AbgL0Xlh (ORCPT ); Sun, 27 Dec 2020 18:41:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbgL0Xlg (ORCPT ); Sun, 27 Dec 2020 18:41:36 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B3B8C061794 for ; Sun, 27 Dec 2020 15:40:56 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id o19so20524932lfo.1 for ; Sun, 27 Dec 2020 15:40:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2g/tw1CfRfSS28JS/E5UEQtXF4RogkgHtVGCAK+cqLg=; b=hmk+nXUKCLprIED87lepHbqNo9/5jDD/zPgpKqfdGUAfyt5eQN8IPSx+3kRgMMUEUo WENraXsqaYlObe0ODWSqZ3r0hKg3rOLnExPsZHKeesNCNNc0ihW35MuIOnqY4fkAS3BZ dhMQhiHVyIoLXszKYVzPhcMPZpMIyqz7BTmxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2g/tw1CfRfSS28JS/E5UEQtXF4RogkgHtVGCAK+cqLg=; b=E3JfffUfv9CMn6lS5WFUEzasa/uaWFCQzZoalZyQZnZutRtzFS8MHZK8s35Rdp6tjc dUxVqniO74pC47ONP1hMRnlI94qalzoeUf1Jnl5xJqHX9qmtBwBYLICxq0PItAjc8MAF vd+a/OXeYhnvm607iaHgbiUBwqZnTHWxnf16lMQaI5Oe7MyyEWVtnZujcN6dpw34YzyC XOgS6LKpeGEpD2wgLPp+h+oD1+dou5CtdDmcW1kxbn17E1MU5B1UXthS07KEmXGxLnOz cgZRf1qY9NyHX8EBT/tKuTQw0ejbONDfNh8HUp83dfEpx7otj1zwzGO+M+DZe9YGDQef faYw== X-Gm-Message-State: AOAM533NR45whXk65F7Q2kdZGj3t1eQoCEYkm620ZfjFE8yqpnPRJQNO 09/mOntHr0MSKzNT7vDBj0zWja0ikDeTKA== X-Google-Smtp-Source: ABdhPJw5xn0+MKwDqAUrME+yR0dHR0L+PtJbFosr8HJHXTKHpahDCPGSu4wlAcVhhggU8bNeJYpWmQ== X-Received: by 2002:a05:6512:3e6:: with SMTP id n6mr17346428lfq.262.1609112454075; Sun, 27 Dec 2020 15:40:54 -0800 (PST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id y13sm5161653lfg.189.2020.12.27.15.40.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 15:40:52 -0800 (PST) Received: by mail-lf1-f42.google.com with SMTP id o17so20476312lfg.4 for ; Sun, 27 Dec 2020 15:40:52 -0800 (PST) X-Received: by 2002:a2e:9ad7:: with SMTP id p23mr19677994ljj.465.1609112452213; Sun, 27 Dec 2020 15:40:52 -0800 (PST) MIME-Version: 1.0 References: <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> <20201226224016.dxjmordcfj75xgte@box> In-Reply-To: From: Linus Torvalds Date: Sun, 27 Dec 2020 15:40:36 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting To: Hugh Dickins , Andrew Morton Cc: Damian Tometzki , "Kirill A. Shutemov" , Matthew Wilcox , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Vinayak Menon , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 27, 2020 at 3:12 PM Linus Torvalds wrote: > > Ok, your fix for that folded in, and here's yet another version. Still not good. I don't know what happened, but the change of - vm_fault_t ret = 0; + vm_fault_t ret; is very very wrong. The next user is + if (!(vma->vm_flags & VM_SHARED)) + ret = check_stable_address_space(vma->vm_mm); + if (ret) + return ret; so now 'ret' will potentially be used uninitialized (although this is the kind of thing that a compiler might almost accidentally end up fixing - with a single dominating assignment, I could imagine the compiler moving the test to that assignment and thus "fixing" the code without really even meaning to). I think Kirill was intending to move the "if (ret)" up into the path that sets it, IOW something like + if (!(vma->vm_flags & VM_SHARED)) { + ret = check_stable_address_space(vma->vm_mm); + if (ret) + return ret; + } instead. But that patch as-is is broken. Kirill? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337E6C433DB for ; Sun, 27 Dec 2020 23:40:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ABA1A224DE for ; Sun, 27 Dec 2020 23:40:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABA1A224DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D78878D000F; Sun, 27 Dec 2020 18:40:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D289C8D0003; Sun, 27 Dec 2020 18:40:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C66C48D000F; Sun, 27 Dec 2020 18:40:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id B16468D0003 for ; Sun, 27 Dec 2020 18:40:56 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7099B180AD80F for ; Sun, 27 Dec 2020 23:40:56 +0000 (UTC) X-FDA: 77640684912.15.rain52_1c096eb2748f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 4A31F1814B0C1 for ; Sun, 27 Dec 2020 23:40:56 +0000 (UTC) X-HE-Tag: rain52_1c096eb2748f X-Filterd-Recvd-Size: 5467 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Sun, 27 Dec 2020 23:40:55 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id o19so20524923lfo.1 for ; Sun, 27 Dec 2020 15:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2g/tw1CfRfSS28JS/E5UEQtXF4RogkgHtVGCAK+cqLg=; b=hmk+nXUKCLprIED87lepHbqNo9/5jDD/zPgpKqfdGUAfyt5eQN8IPSx+3kRgMMUEUo WENraXsqaYlObe0ODWSqZ3r0hKg3rOLnExPsZHKeesNCNNc0ihW35MuIOnqY4fkAS3BZ dhMQhiHVyIoLXszKYVzPhcMPZpMIyqz7BTmxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2g/tw1CfRfSS28JS/E5UEQtXF4RogkgHtVGCAK+cqLg=; b=Sd/1IGugvkkQKUxTvmeesSOxMoM07u9dMwOJkzrCnIY/o7DnRbR1D9X4f4OqwoBsy5 g9C5n6UQ7YWKbfAsmMFM/QJSxD1cVoITXVjWKw+cR9c1McnmdTMEK8F5e40QWZRzCbJ0 5ksaJD/2DDgz6Ms57r2q6l8Cjx3uIVpNkGPGmvv7cgCyIWb5kLYtqe6v1lmNOBfo97MX ZRFwkisQBVaCNjDN6Y7moTGZDAuBqEG5jWlLhwlfSSVOK2zPldIN//FW3tqGvdSi9ubP sIbGLUaZa8/fNNJXgtPelphpHSLlRQJrJyATCDx7XXQLxFje3EcXuakbyQXybQ7TnxVt aApA== X-Gm-Message-State: AOAM530BMDpE7ZknvebyO5Ar07lgp6dSKsffdUrCopmtg5UEMsdHSy+1 TPVLHNSRj0F14jdVYbJEKNePofM1QgaiCg== X-Google-Smtp-Source: ABdhPJwVcSuPMSCc8Tq3jBCuRLwQKegXqTjGcFJDccu7o/KOIUwsVYxyD6BlxA3c3Bvv7ncc8T85iA== X-Received: by 2002:a19:3d5:: with SMTP id 204mr16821327lfd.21.1609112453912; Sun, 27 Dec 2020 15:40:53 -0800 (PST) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id e9sm5153959lfc.253.2020.12.27.15.40.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 15:40:52 -0800 (PST) Received: by mail-lf1-f47.google.com with SMTP id y19so20330183lfa.13 for ; Sun, 27 Dec 2020 15:40:52 -0800 (PST) X-Received: by 2002:a2e:9ad7:: with SMTP id p23mr19677994ljj.465.1609112452213; Sun, 27 Dec 2020 15:40:52 -0800 (PST) MIME-Version: 1.0 References: <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> <20201226224016.dxjmordcfj75xgte@box> In-Reply-To: From: Linus Torvalds Date: Sun, 27 Dec 2020 15:40:36 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting To: Hugh Dickins , Andrew Morton Cc: Damian Tometzki , "Kirill A. Shutemov" , Matthew Wilcox , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Vinayak Menon , Android Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 27, 2020 at 3:12 PM Linus Torvalds wrote: > > Ok, your fix for that folded in, and here's yet another version. Still not good. I don't know what happened, but the change of - vm_fault_t ret = 0; + vm_fault_t ret; is very very wrong. The next user is + if (!(vma->vm_flags & VM_SHARED)) + ret = check_stable_address_space(vma->vm_mm); + if (ret) + return ret; so now 'ret' will potentially be used uninitialized (although this is the kind of thing that a compiler might almost accidentally end up fixing - with a single dominating assignment, I could imagine the compiler moving the test to that assignment and thus "fixing" the code without really even meaning to). I think Kirill was intending to move the "if (ret)" up into the path that sets it, IOW something like + if (!(vma->vm_flags & VM_SHARED)) { + ret = check_stable_address_space(vma->vm_mm); + if (ret) + return ret; + } instead. But that patch as-is is broken. Kirill? Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A54C433DB for ; Sun, 27 Dec 2020 23:43:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66358224DE for ; Sun, 27 Dec 2020 23:43:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66358224DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TscBFw9ToyVpiG+A28ypil5wEcv6INQC7VWZxgqHGm4=; b=jXplgWFF+PiVmuWBKu74QNy4T OQ9n79bANAMSVUwUAUoFb6L995upBfxDfpJQLa9OP0zJGPuRrjnvQYD31KOdZEXJjLWARN7erU7h5 qiPKFprVCs+KAPuTthR3EuZK3rk5swl/Vl2CmKUlPwBunprGiv2NEt89boFkYHeBwlj0eX7n+9k3q sxMj1IUZoXdCwhtLTJRlkxgeIzTj4uxY1bj9CK4ApVui2PdG3bdoAn5xm5opQTGZ6Jh3aHr2gmH8O MtNjVAN87WWt2d4vAx62uJ4V+OIL0Id3jOh5tEmDT0bTgXu2+L2z8Co1PPa0jwwb+vxiUIwGvU8ID yxO8fBe4g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktfek-0000Wm-9R; Sun, 27 Dec 2020 23:40:58 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktfei-0000Vr-66 for linux-arm-kernel@lists.infradead.org; Sun, 27 Dec 2020 23:40:57 +0000 Received: by mail-lf1-x131.google.com with SMTP id m12so20452252lfo.7 for ; Sun, 27 Dec 2020 15:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2g/tw1CfRfSS28JS/E5UEQtXF4RogkgHtVGCAK+cqLg=; b=hmk+nXUKCLprIED87lepHbqNo9/5jDD/zPgpKqfdGUAfyt5eQN8IPSx+3kRgMMUEUo WENraXsqaYlObe0ODWSqZ3r0hKg3rOLnExPsZHKeesNCNNc0ihW35MuIOnqY4fkAS3BZ dhMQhiHVyIoLXszKYVzPhcMPZpMIyqz7BTmxg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2g/tw1CfRfSS28JS/E5UEQtXF4RogkgHtVGCAK+cqLg=; b=pPG0eTiTlnOMIOxLblN4h+uruDog9ymC4b9Ia5h0m4L6OhgOs59AH5iw2KyErpkydh 1TYvmc6DjhXEcVTlKIEq8sbltMg9CR+w99dKSG7lm2BsYY6b83xIvEQycTxoxSF70DQT y/Z/UAckIlICrpiqOYxT2m0HYkg8Vcoxp+gsCtDJfpzqZrHPtQT/D3afQX+1zIF3UvAI KY+zvMtVFbeHwVCNkhvwU7udmC1dLM3WoKBZjgNg/F1MWMEga5IYmuIdf62BltQpO/OQ NfIdLhJn1YVijryggyeFbutaWipXPGOhzhgPpeEj/zDIE1j3Sa4PAhxfzyWLsAMOzMIE ejsg== X-Gm-Message-State: AOAM5326xsPvvEUHjavlyK6Xb1lEWD+W03L/RGDF8QTLaFsS8evfi3fk mEJlrsCJljVk/najUIPNHRJV7YjRKMoPYw== X-Google-Smtp-Source: ABdhPJyrbdcmo5obOOaAOrktmy65Fvl24/2+dBCgnSBoXw4UHQEBe5PVn0KAoVLoArNx3fAIrn8//g== X-Received: by 2002:a19:8c8:: with SMTP id 191mr17257512lfi.492.1609112454269; Sun, 27 Dec 2020 15:40:54 -0800 (PST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id y3sm6036092ljh.107.2020.12.27.15.40.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Dec 2020 15:40:52 -0800 (PST) Received: by mail-lf1-f53.google.com with SMTP id 23so20398637lfg.10 for ; Sun, 27 Dec 2020 15:40:52 -0800 (PST) X-Received: by 2002:a2e:9ad7:: with SMTP id p23mr19677994ljj.465.1609112452213; Sun, 27 Dec 2020 15:40:52 -0800 (PST) MIME-Version: 1.0 References: <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> <20201226224016.dxjmordcfj75xgte@box> In-Reply-To: From: Linus Torvalds Date: Sun, 27 Dec 2020 15:40:36 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting To: Hugh Dickins , Andrew Morton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201227_184056_242777_F56E03B8 X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Android Kernel Team , Jan Kara , Linux-MM , Catalin Marinas , Minchan Kim , Linux Kernel Mailing List , Matthew Wilcox , Damian Tometzki , Vinayak Menon , Linux ARM , "Kirill A. Shutemov" , Will Deacon , "Kirill A. Shutemov" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Dec 27, 2020 at 3:12 PM Linus Torvalds wrote: > > Ok, your fix for that folded in, and here's yet another version. Still not good. I don't know what happened, but the change of - vm_fault_t ret = 0; + vm_fault_t ret; is very very wrong. The next user is + if (!(vma->vm_flags & VM_SHARED)) + ret = check_stable_address_space(vma->vm_mm); + if (ret) + return ret; so now 'ret' will potentially be used uninitialized (although this is the kind of thing that a compiler might almost accidentally end up fixing - with a single dominating assignment, I could imagine the compiler moving the test to that assignment and thus "fixing" the code without really even meaning to). I think Kirill was intending to move the "if (ret)" up into the path that sets it, IOW something like + if (!(vma->vm_flags & VM_SHARED)) { + ret = check_stable_address_space(vma->vm_mm); + if (ret) + return ret; + } instead. But that patch as-is is broken. Kirill? Linus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel