From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4CAC433FE for ; Tue, 15 Feb 2022 15:44:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241020AbiBOPo6 (ORCPT ); Tue, 15 Feb 2022 10:44:58 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240323AbiBOPov (ORCPT ); Tue, 15 Feb 2022 10:44:51 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04374108BF1; Tue, 15 Feb 2022 07:39:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4FCF461719; Tue, 15 Feb 2022 15:39:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DC15C340ED; Tue, 15 Feb 2022 15:39:09 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="fKlwMQmG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1644939546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MR8uETDJg9Xeaqk+LtV2lrW0K+3vcdxP9bkf45PeWiI=; b=fKlwMQmGGl+XsuXaJRJANlEQmKW31rbgKKnwOwuHDVYuAgsiz75OzV6KyNYigUqakpATd+ lrKV0EL0geEgSp2Iq13ZZFv3iyCO+axNLOZtKL6VfJRlHJOthZNR0OUCsth1F82w/glyFa VGZJ6UBhjWAcHfat12nc6HCCT987kgg= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 840e6152 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 15 Feb 2022 15:39:06 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id c6so57273205ybk.3; Tue, 15 Feb 2022 07:39:05 -0800 (PST) X-Gm-Message-State: AOAM53206orcEkIrcBafJxYIYkg6F8QbOvOpOjloJcQjqERCVqQsFlvL qUCJJc3dnR6GcGnJDiNlLvQI2yX7a1G5iKiBab4= X-Google-Smtp-Source: ABdhPJx6EkevGOE04tDjGHfHD2+6REo3QOFWHcWoX1VRu7eS0/CeK2AEid1T7UKuH9ZZD7sSfy+PGSjfiEvFPJW00fQ= X-Received: by 2002:a25:ba49:: with SMTP id z9mr4233199ybj.32.1644939544595; Tue, 15 Feb 2022 07:39:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "Jason A. Donenfeld" Date: Tue, 15 Feb 2022 16:38:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: ath9k should perhaps use hw_random api? To: miaoqing@codeaurora.org, Jason Cooper , "Sepehrdad, Pouyan" , ath9k-devel , "linux-wireless@vger.kernel.org" , Kalle Valo , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Dominik Brodowski , Linux Crypto Mailing List , Herbert Xu , LKML , Netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Ath9k Maintainers, I'm emailing you because I've noticed that ath9k's rng.c is the *only* driver in the whole of the tree that calls add_hwgenerator_randomness() directly, rather than going through Herbert's hw_random API, as every single other hardware RNG does. I'm wondering if you'd consider converting your driver into something suitable for the hw_random API (in drivers/char/hw_random/), rather than adhoc rolling your own ath9k rng kthread. Is this something you're actively maintaining and would be interested in doing? Regards, Jason