From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Sun, 27 Dec 2020 18:28:25 +0200 Subject: [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default In-Reply-To: <20201129165252.6350-1-pali@kernel.org> References: <20201129164618.5829-1-pali@kernel.org> <20201129165252.6350-1-pali@kernel.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Nov 29, 2020 at 6:53 PM Pali Roh?r wrote: > > Now when usbtty serial console is fixed in U-Boot enable it for Nokia RX-51 > board by default. > > CONFIG_CONSOLE_MUX is already used and U-Boot console is available for > all in/out devices. Therefore there is no need to have separate commands > 'run sercon', 'run usbcon' and 'run vgacon', so remove them. > > As space for U-Boot is limited to 256kB, disable some other unused options > so CONFIG_USB_TTY can be enabled. > > Nokia RX-51 does not have easily accessible UART serial console so the only > option for easy debugging is to use device's keyboard+screen or this usbtty > serial console over USB. I think it's not a good idea to revive usbtty. I was recently playing around f_serial.c (I can send you the half baked stuff, which by a lot of twisted code in DWC3 driver is not working properly, actually almost not working) and I think that would be the right thing to do. usbtty quite old, intrusive way of serial console via USB supported only by outdated hardware (like this Nokia N-900), while f_serial gotta work on better recent base. And I believe musb should be, if needed, patched to support composite devices. So, kinda disagreement from my side as a summary on this. But disclaimer, I'm not a maintainer here, just my 2 cents. -- With Best Regards, Andy Shevchenko